All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org,
	ben.dooks@codethink.co.uk
Subject: Re: [PATCH] micrel: fix masking off LED bits
Date: Thu, 20 Mar 2014 17:44:13 +0000	[thread overview]
Message-ID: <532B36F5.20605@cogentembedded.com> (raw)
In-Reply-To: <20140319.174205.1425627653050633421.davem@davemloft.net>

Hello.

On 03/20/2014 12:42 AM, David Miller wrote:

>> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the
>> obvious mistake when masking off  the LED mode bits: forgot to do a logical NOT
>> to the mask with which it ANDs the register value, so that unrelated bits are
>> cleared instead.

    I'm seeing now that I hadn't finished editing the changelog before 
submitting -- the verbs have inconsistent times. So much for my haste... :-)

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Applied to net-next, thanks.

    Thanks.

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org,
	ben.dooks@codethink.co.uk
Subject: Re: [PATCH] micrel: fix masking off LED bits
Date: Thu, 20 Mar 2014 21:44:05 +0300	[thread overview]
Message-ID: <532B36F5.20605@cogentembedded.com> (raw)
In-Reply-To: <20140319.174205.1425627653050633421.davem@davemloft.net>

Hello.

On 03/20/2014 12:42 AM, David Miller wrote:

>> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the
>> obvious mistake when masking off  the LED mode bits: forgot to do a logical NOT
>> to the mask with which it ANDs the register value, so that unrelated bits are
>> cleared instead.

    I'm seeing now that I hadn't finished editing the changelog before 
submitting -- the verbs have inconsistent times. So much for my haste... :-)

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Applied to net-next, thanks.

    Thanks.

WBR, Sergei

  reply	other threads:[~2014-03-20 17:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 22:58 [PATCH] micrel: fix masking off LED bits Sergei Shtylyov
2014-03-18 23:58 ` Sergei Shtylyov
2014-03-18 23:27 ` Laurent Pinchart
2014-03-18 23:27   ` Laurent Pinchart
2014-03-19  8:12 ` Ben Dooks
2014-03-19  8:12   ` Ben Dooks
2014-03-19 16:21   ` Florian Fainelli
2014-03-19 16:21     ` Florian Fainelli
2014-03-19 18:35     ` Sergei Shtylyov
2014-03-19 19:35       ` Sergei Shtylyov
2014-03-19 21:42 ` David Miller
2014-03-19 21:42   ` David Miller
2014-03-20 17:44   ` Sergei Shtylyov [this message]
2014-03-20 18:44     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532B36F5.20605@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=davem@davemloft.net \
    --cc=linux-sh@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.