All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: David Miller <davem@davemloft.net>
Cc: jesse@nicira.com, pshelar@nicira.com, tgraf@redhat.com,
	dev@openvswitch.org, pablo@netfilter.org, kaber@trash.net,
	kadlec@blackhole.kfki.hu, edumazet@google.com,
	dborkman@redhat.com, therbert@google.com, jasowang@redhat.com,
	fw@strlen.de, joe@perches.com, horms@verge.net.au,
	jiri@resnulli.us, mst@redhat.com, Paul.Durrant@citrix.com,
	JBeulich@suse.com, herbert@gondor.apana.org.au, mszeredi@suse.cz,
	netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	coreteam@netfilter.org, xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Wed, 19 Mar 2014 20:39:33 +0000	[thread overview]
Message-ID: <532A0085.6070104@citrix.com> (raw)
In-Reply-To: <20140319.162459.897793286761249454.davem@davemloft.net>

On 19/03/14 20:24, David Miller wrote:
> From: Zoltan Kiss <zoltan.kiss@citrix.com>
> Date: Tue, 18 Mar 2014 21:17:35 +0000
>
>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
>> orphan them. Also, it doesn't handle errors, so this patch takes care of that
>> as well.
>>
>> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
>> ---
>>   net/openvswitch/datapath.c |    6 ++++++
>
> Something is seriously wrong with the diffstat generated for
> your submission, please fix this and resubmit.

Sorry, I've turned off diffstat in guilt a while ago, but this patch had 
an old version of it. I've resent it.

Zoli

WARNING: multiple messages have this Message-ID (diff)
From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: David Miller <davem@davemloft.net>
Cc: <jesse@nicira.com>, <pshelar@nicira.com>, <tgraf@redhat.com>,
	<dev@openvswitch.org>, <pablo@netfilter.org>, <kaber@trash.net>,
	<kadlec@blackhole.kfki.hu>, <edumazet@google.com>,
	<dborkman@redhat.com>, <therbert@google.com>,
	<jasowang@redhat.com>, <fw@strlen.de>, <joe@perches.com>,
	<horms@verge.net.au>, <jiri@resnulli.us>, <mst@redhat.com>,
	<Paul.Durrant@citrix.com>, <JBeulich@suse.com>,
	<herbert@gondor.apana.org.au>, <mszeredi@suse.cz>,
	<netfilter-devel@vger.kernel.org>, <netfilter@vger.kernel.org>,
	<coreteam@netfilter.org>, <xen-devel@lists.xenproject.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>
Subject: Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Wed, 19 Mar 2014 20:39:33 +0000	[thread overview]
Message-ID: <532A0085.6070104@citrix.com> (raw)
In-Reply-To: <20140319.162459.897793286761249454.davem@davemloft.net>

On 19/03/14 20:24, David Miller wrote:
> From: Zoltan Kiss <zoltan.kiss@citrix.com>
> Date: Tue, 18 Mar 2014 21:17:35 +0000
>
>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
>> orphan them. Also, it doesn't handle errors, so this patch takes care of that
>> as well.
>>
>> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
>> ---
>>   net/openvswitch/datapath.c |    6 ++++++
>
> Something is seriously wrong with the diffstat generated for
> your submission, please fix this and resubmit.

Sorry, I've turned off diffstat in guilt a while ago, but this patch had 
an old version of it. I've resent it.

Zoli

  reply	other threads:[~2014-03-19 20:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 21:17 [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Zoltan Kiss
2014-03-18 21:17 ` Zoltan Kiss
2014-03-18 21:17 ` Zoltan Kiss
     [not found] ` <1395177455-2077-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-03-19 20:24   ` David Miller
2014-03-19 20:24     ` David Miller
2014-03-19 20:39     ` Zoltan Kiss [this message]
2014-03-19 20:39       ` Zoltan Kiss
2014-03-19 20:39     ` Zoltan Kiss
2014-03-19 20:24 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-03-19 20:38 Zoltan Kiss
2014-03-19 20:38 Zoltan Kiss
2014-03-19 20:38 ` Zoltan Kiss
2014-03-19 20:38 ` Zoltan Kiss
     [not found] ` <1395261516-305-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-03-19 20:47   ` Thomas Graf
2014-03-19 20:47     ` Thomas Graf
     [not found]     ` <532A026E.5070609-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-03-19 21:07       ` Zoltan Kiss
2014-03-19 21:07         ` Zoltan Kiss
2014-03-19 21:07         ` Zoltan Kiss
2014-03-19 21:07     ` Zoltan Kiss
2014-03-19 20:47 ` Thomas Graf
2014-03-18 21:17 Zoltan Kiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532A0085.6070104@citrix.com \
    --to=zoltan.kiss@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=dev@openvswitch.org \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@verge.net.au \
    --cc=jasowang@redhat.com \
    --cc=jesse@nicira.com \
    --cc=jiri@resnulli.us \
    --cc=joe@perches.com \
    --cc=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mszeredi@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=pshelar@nicira.com \
    --cc=tgraf@redhat.com \
    --cc=therbert@google.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.