From: Thomas Graf <tgraf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Zoltan Kiss <zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
Jesse Gross <jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>,
pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org,
dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org
Cc: netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Miklos Szeredi <mszeredi-AlSwsSmVLrQ@public.gmane.org>,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Michael S. Tsirkin"
<mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jason Wang <jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Jan Beulich <JBeulich-IBi9RG/b67k@public.gmane.org>,
Tom Herbert <therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Herbert Xu
<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
coreteam-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org,
Jozsef Kadlecsik
<kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org>,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
Pablo Neira Ayuso <pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org>,
Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>,
Paul Durrant
<Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Florian Westphal <fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Daniel Borkmann
<dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Wed, 19 Mar 2014 21:47:42 +0100 [thread overview]
Message-ID: <532A026E.5070609@redhat.com> (raw)
In-Reply-To: <1395261516-305-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
> ---
> + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
> + skb_tx_error(to);
> + return -ENOMEM;
> }
I think you should move this down to right before we iterate over the
frags.
Looks good otherwise.
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Graf <tgraf@redhat.com>
To: Zoltan Kiss <zoltan.kiss@citrix.com>,
Jesse Gross <jesse@nicira.com>,
pshelar@nicira.com, dev@openvswitch.org
Cc: "David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Eric Dumazet <edumazet@google.com>,
Daniel Borkmann <dborkman@redhat.com>,
Tom Herbert <therbert@google.com>,
Jason Wang <jasowang@redhat.com>, Florian Westphal <fw@strlen.de>,
Joe Perches <joe@perches.com>, Simon Horman <horms@verge.net.au>,
Jiri Pirko <jiri@resnulli.us>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paul Durrant <Paul.Durrant@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Miklos Szeredi <mszeredi@suse.cz>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, xen-devel@lists.xenproject.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Wed, 19 Mar 2014 21:47:42 +0100 [thread overview]
Message-ID: <532A026E.5070609@redhat.com> (raw)
In-Reply-To: <1395261516-305-1-git-send-email-zoltan.kiss@citrix.com>
On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
> ---
> + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
> + skb_tx_error(to);
> + return -ENOMEM;
> }
I think you should move this down to right before we iterate over the
frags.
Looks good otherwise.
next prev parent reply other threads:[~2014-03-19 20:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 20:38 [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Zoltan Kiss
2014-03-19 20:38 ` Zoltan Kiss
2014-03-19 20:38 ` Zoltan Kiss
2014-03-19 20:47 ` Thomas Graf
[not found] ` <1395261516-305-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-03-19 20:47 ` Thomas Graf [this message]
2014-03-19 20:47 ` Thomas Graf
2014-03-19 21:07 ` Zoltan Kiss
[not found] ` <532A026E.5070609-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-03-19 21:07 ` Zoltan Kiss
2014-03-19 21:07 ` Zoltan Kiss
2014-03-19 21:07 ` Zoltan Kiss
-- strict thread matches above, loose matches on Subject: below --
2014-03-19 20:38 Zoltan Kiss
2014-03-18 21:17 Zoltan Kiss
2014-03-18 21:17 Zoltan Kiss
2014-03-18 21:17 ` Zoltan Kiss
2014-03-18 21:17 ` Zoltan Kiss
[not found] ` <1395177455-2077-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-03-19 20:24 ` David Miller
2014-03-19 20:24 ` David Miller
2014-03-19 20:39 ` Zoltan Kiss
2014-03-19 20:39 ` Zoltan Kiss
2014-03-19 20:39 ` Zoltan Kiss
2014-03-19 20:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A026E.5070609@redhat.com \
--to=tgraf-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=JBeulich-IBi9RG/b67k@public.gmane.org \
--cc=Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=coreteam-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org \
--cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org \
--cc=kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mszeredi-AlSwsSmVLrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org \
--cc=pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org \
--cc=therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
--cc=zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.