All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map
Date: Sat, 22 Mar 2014 00:56:59 +0100	[thread overview]
Message-ID: <532CD1CB.4070707@nod.at> (raw)
In-Reply-To: <20140321195403.GA32529@redhat.com>

Am 21.03.2014 20:54, schrieb Mike Snitzer:
> The comparisons used in add_vol() shouldn't be identical.  Pretty sure
> the following is correct but it is completely untested.
> 
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> ---
>  drivers/mtd/ubi/fastmap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> NOTE: I stumbled upon this code while implementing some rb_tree code
>       (and looking for some existing rb_tree code as a reference).

Thanks a lot for pointing this out!

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Artem Bityutskiy <dedekind1@gmail.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map
Date: Sat, 22 Mar 2014 00:56:59 +0100	[thread overview]
Message-ID: <532CD1CB.4070707@nod.at> (raw)
In-Reply-To: <20140321195403.GA32529@redhat.com>

Am 21.03.2014 20:54, schrieb Mike Snitzer:
> The comparisons used in add_vol() shouldn't be identical.  Pretty sure
> the following is correct but it is completely untested.
> 
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> ---
>  drivers/mtd/ubi/fastmap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> NOTE: I stumbled upon this code while implementing some rb_tree code
>       (and looking for some existing rb_tree code as a reference).

Thanks a lot for pointing this out!

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

  reply	other threads:[~2014-03-21 23:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 19:54 [RFC PATCH] UBI: fix rb_tree node comparison in add_map Mike Snitzer
2014-03-21 19:54 ` Mike Snitzer
2014-03-21 23:56 ` Richard Weinberger [this message]
2014-03-21 23:56   ` Richard Weinberger
2014-05-10  1:19   ` Brian Norris
2014-05-10  1:19     ` Brian Norris
2014-05-13  9:08     ` Artem Bityutskiy
2014-05-13  9:08       ` Artem Bityutskiy
2014-05-13 10:48 ` Artem Bityutskiy
2014-05-13 10:48   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532CD1CB.4070707@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.