All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E
@ 2012-12-02 19:17 Guenter Roeck
  2014-03-25  8:24 ` [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E Jean Delvare
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Guenter Roeck @ 2012-12-02 19:17 UTC (permalink / raw)
  To: lm-sensors

Assume that IT8772E is fully compatible with IT8728F and IT8771E.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 Documentation/hwmon/it87 |   12 ++++++++----
 drivers/hwmon/Kconfig    |    3 ++-
 drivers/hwmon/it87.c     |   22 +++++++++++++++++++---
 3 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/Documentation/hwmon/it87 b/Documentation/hwmon/it87
index b9e13a0..c263740 100644
--- a/Documentation/hwmon/it87
+++ b/Documentation/hwmon/it87
@@ -34,6 +34,10 @@ Supported chips:
     Prefix: 'it8771'
     Addresses scanned: from Super I/O config space (8 I/O ports)
     Datasheet: Not publicly available
+  * IT8772E
+    Prefix: 'it8772'
+    Addresses scanned: from Super I/O config space (8 I/O ports)
+    Datasheet: Not publicly available
   * IT8782F
     Prefix: 'it8782'
     Addresses scanned: from Super I/O config space (8 I/O ports)
@@ -87,8 +91,8 @@ Description
 -----------
 
 This driver implements support for the IT8705F, IT8712F, IT8716F,
-IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E, IT8771E, IT8782F,
-IT8783E/F, and SiS950 chips.
+IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E, IT8771E, IT8772E,
+IT8782F, IT8783E/F, and SiS950 chips.
 
 These chips are 'Super I/O chips', supporting floppy disks, infrared ports,
 joysticks and other miscellaneous stuff. For hardware monitoring, they
@@ -122,8 +126,8 @@ The IT8726F is just bit enhanced IT8716F with additional hardware
 for AMD power sequencing. Therefore the chip will appear as IT8716F
 to userspace applications.
 
-The IT8728F and IT8771E are considered compatible with the IT8721F, until
-a datasheet becomes available (hopefully.)
+The IT8728F, IT8771E, and IT8772E are considered compatible with the IT8721F,
+until a datasheet becomes available (hopefully.)
 
 Temperatures are measured in degrees Celsius. An alarm is triggered once
 when the Overtemperature Shutdown limit is crossed.
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index b1a4826..0b77ac3 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -496,7 +496,8 @@ config SENSORS_IT87
 	help
 	  If you say yes here you get support for ITE IT8705F, IT8712F,
 	  IT8716F, IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E,
-	  IT8771E, IT8782F, and IT8783E/F sensor chips, and the SiS950 clone.
+	  IT8771E, IT8772E, IT8782F, and IT8783E/F sensor chips, and the
+	  SiS950 clone.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called it87.
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 5591a39..531b5df 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -20,6 +20,7 @@
  *            IT8728F  Super I/O chip w/LPC interface
  *            IT8758E  Super I/O chip w/LPC interface
  *            IT8771E  Super I/O chip w/LPC interface
+ *            IT8772E  Super I/O chip w/LPC interface
  *            IT8782F  Super I/O chip w/LPC interface
  *            IT8783E/F Super I/O chip w/LPC interface
  *            Sis950   A clone of the IT8705F
@@ -63,7 +64,7 @@
 #define DRVNAME "it87"
 
 enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8771,
-	     it8782, it8783 };
+	     it8772, it8782, it8783 };
 
 static unsigned short force_id;
 module_param(force_id, ushort, 0);
@@ -142,6 +143,7 @@ static inline void superio_exit(void)
 #define IT8726F_DEVID 0x8726
 #define IT8728F_DEVID 0x8728
 #define IT8771E_DEVID 0x8771
+#define IT8772E_DEVID 0x8772
 #define IT8782F_DEVID 0x8782
 #define IT8783E_DEVID 0x8783
 #define IT87_ACT_REG  0x30
@@ -292,6 +294,15 @@ static const struct it87_devices it87_devices[] = {
 					/* 16 bit fans (OHM) */
 		.peci_mask = 0x07,
 	},
+	[it8772] = {
+		.name = "it8772",
+		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
+		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI,
+					/* PECI (coreboot) */
+					/* 12mV ADC (HWSensors4, OHM) */
+					/* 16 bit fans (HWSensors4, OHM) */
+		.peci_mask = 0x07,
+	},
 	[it8782] = {
 		.name = "it8782",
 		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET
@@ -1723,6 +1734,9 @@ static int __init it87_find(unsigned short *address,
 	case IT8771E_DEVID:
 		sio_data->type = it8771;
 		break;
+	case IT8772E_DEVID:
+		sio_data->type = it8772;
+		break;
 	case IT8782F_DEVID:
 		sio_data->type = it8782;
 		break;
@@ -1840,7 +1854,8 @@ static int __init it87_find(unsigned short *address,
 
 		reg = superio_inb(IT87_SIO_GPIO3_REG);
 		if (sio_data->type = it8721 || sio_data->type = it8728 ||
-		    sio_data->type = it8771 || sio_data->type = it8782) {
+		    sio_data->type = it8771 || sio_data->type = it8772 ||
+		    sio_data->type = it8782) {
 			/*
 			 * IT8721F/IT8758E, and IT8782F don't have VID pins
 			 * at all, not sure about the IT8728F and compatibles.
@@ -1898,7 +1913,8 @@ static int __init it87_find(unsigned short *address,
 			sio_data->internal |= (1 << 0);
 		if ((reg & (1 << 1)) || sio_data->type = it8721 ||
 		    sio_data->type = it8728 ||
-		    sio_data->type = it8771)
+		    sio_data->type = it8771 ||
+		    sio_data->type = it8772)
 			sio_data->internal |= (1 << 1);
 
 		/*
-- 
1.7.9.7


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [lm-sensors] [PATCH 2/2]  hwmon: (it87) Add support for IT8623E
@ 2014-03-24 22:23 Rudolf Marek
  0 siblings, 0 replies; 8+ messages in thread
From: Rudolf Marek @ 2014-03-24 22:23 UTC (permalink / raw)
  To: lm-sensors

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Hi all,

The attached patch adds support for the IT8623E found on Asus motherboards. It 
has same hardware monitoring block as IT8603E.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>

Compile tested. Martin, please can you test?

Thanks
Rudolf


[-- Attachment #2: it8623.patch --]
[-- Type: text/x-diff, Size: 2521 bytes --]

Index: linux-3.14-rc7/Documentation/hwmon/it87
===================================================================
--- linux-3.14-rc7.orig/Documentation/hwmon/it87	2014-03-17 02:51:24.000000000 +0100
+++ linux-3.14-rc7/Documentation/hwmon/it87	2014-03-24 23:01:24.946438930 +0100
@@ -2,7 +2,7 @@
 ==================
 
 Supported chips:
-  * IT8603E
+  * IT8603E/IT8623E
     Prefix: 'it8603'
     Addresses scanned: from Super I/O config space (8 I/O ports)
     Datasheet: Not publicly available
@@ -94,9 +94,9 @@
 Description
 -----------
 
-This driver implements support for the IT8603E, IT8705F, IT8712F, IT8716F,
-IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E, IT8771E, IT8772E,
-IT8782F, IT8783E/F, and SiS950 chips.
+This driver implements support for the IT8603E, IT8623E, IT8705F, IT8712F,
+IT8716F, IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8758E, IT8771E,
+IT8772E, IT8782F, IT8783E/F, and SiS950 chips.
 
 These chips are 'Super I/O chips', supporting floppy disks, infrared ports,
 joysticks and other miscellaneous stuff. For hardware monitoring, they
@@ -133,7 +133,7 @@
 The IT8728F, IT8771E, and IT8772E are considered compatible with the IT8721F,
 until a datasheet becomes available (hopefully.)
 
-The IT8603E is a custom design, hardware monitoring part is similar to
+The IT8603E/IT8623E is a custom design, hardware monitoring part is similar to
 IT8728F. It only supports 16-bit fan mode, the full speed mode of the
 fan is not supported (value 0 of pwmX_enable).
 
Index: linux-3.14-rc7/drivers/hwmon/it87.c
===================================================================
--- linux-3.14-rc7.orig/drivers/hwmon/it87.c	2014-03-24 22:57:57.213050493 +0100
+++ linux-3.14-rc7/drivers/hwmon/it87.c	2014-03-24 22:54:27.000000000 +0100
@@ -11,6 +11,7 @@
  *  similar parts.  The other devices are supported by different drivers.
  *
  *  Supports: IT8603E  Super I/O chip w/LPC interface
+ *            IT8623E  Super I/O chip w/LPC interface
  *            IT8705F  Super I/O chip w/LPC interface
  *            IT8712F  Super I/O chip w/LPC interface
  *            IT8716F  Super I/O chip w/LPC interface
@@ -148,6 +149,7 @@
 #define IT8782F_DEVID 0x8782
 #define IT8783E_DEVID 0x8783
 #define IT8603E_DEVID 0x8603
+#define IT8623E_DEVID 0x8623
 #define IT87_ACT_REG  0x30
 #define IT87_BASE_REG 0x60
 
@@ -1767,6 +1769,7 @@
 		sio_data->type = it8783;
 		break;
 	case IT8603E_DEVID:
+	case IT8623E_DEVID:
 		sio_data->type = it8603;
 		break;
 	case 0xffff:	/* No device at all */

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E
  2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
@ 2014-03-25  8:24 ` Jean Delvare
  2014-03-25 10:12 ` Martin Herrholz
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2014-03-25  8:24 UTC (permalink / raw)
  To: lm-sensors

Hi Rudolf,

On Mon, 24 Mar 2014 23:23:39 +0100, Rudolf Marek wrote:
> The attached patch adds support for the IT8623E found on Asus motherboards. It 
> has same hardware monitoring block as IT8603E.
> 
> Signed-off-by: Rudolf Marek <r.marek@assembler.cz>

That should do the trick, thank you. Patch applied.

> Compile tested. Martin, please can you test?

If it helps, I have updated the standalone it87 driver at:
http://jdelvare.nerim.net/devel/lm-sensors/drivers/it87/

Installation instructions are at:
http://jdelvare.nerim.net/devel/lm-sensors/drivers/INSTALL

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E
  2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
  2014-03-25  8:24 ` [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E Jean Delvare
@ 2014-03-25 10:12 ` Martin Herrholz
  2014-03-25 11:36 ` Jean Delvare
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: Martin Herrholz @ 2014-03-25 10:12 UTC (permalink / raw)
  To: lm-sensors

Hi Jean and Rudolf,

i did install the module like mentioned in your linked Instructions and 
redone the sensors-detect.
I still get the same result:

Trying family `ITE'...                                      Yes
Found unknown chip with ID 0x8623
     (logical device 4 has address 0x290, could be sensors)

I had no it87 module installed prior to it, so i had nothing to remove. 
The module compiles/loads without errors.

Best Regards
Martin

On 25.03.2014 09:24, Jean Delvare wrote:
> Hi Rudolf,
>
> On Mon, 24 Mar 2014 23:23:39 +0100, Rudolf Marek wrote:
>> The attached patch adds support for the IT8623E found on Asus motherboards. It
>> has same hardware monitoring block as IT8603E.
>>
>> Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
> That should do the trick, thank you. Patch applied.
>
>> Compile tested. Martin, please can you test?
> If it helps, I have updated the standalone it87 driver at:
> http://jdelvare.nerim.net/devel/lm-sensors/drivers/it87/
>
> Installation instructions are at:
> http://jdelvare.nerim.net/devel/lm-sensors/drivers/INSTALL
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E
  2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
  2014-03-25  8:24 ` [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E Jean Delvare
  2014-03-25 10:12 ` Martin Herrholz
@ 2014-03-25 11:36 ` Jean Delvare
  2014-03-25 11:57 ` Martin Herrholz
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2014-03-25 11:36 UTC (permalink / raw)
  To: lm-sensors

Hi Martin,

On Tue, 25 Mar 2014 11:12:46 +0100, Martin Herrholz wrote:
> i did install the module like mentioned in your linked Instructions and 
> redone the sensors-detect.
> I still get the same result:
> 
> Trying family `ITE'...                                      Yes
> Found unknown chip with ID 0x8623
>      (logical device 4 has address 0x290, could be sensors)

This is expected, sensors-detect has its own detection code which is
independent from the installed drivers. You can try the latest version
at:
  http://dl.lm-sensors.org/lm-sensors/files/sensors-detect

which should detect your chip properly.

> I had no it87 module installed prior to it, so i had nothing to remove. 
> The module compiles/loads without errors.

Great. But does it work? What does "sensors" say?

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E
  2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
                   ` (2 preceding siblings ...)
  2014-03-25 11:36 ` Jean Delvare
@ 2014-03-25 11:57 ` Martin Herrholz
  2014-03-25 14:59 ` Rudolf Marek
  2014-03-25 15:20 ` Jean Delvare
  5 siblings, 0 replies; 8+ messages in thread
From: Martin Herrholz @ 2014-03-25 11:57 UTC (permalink / raw)
  To: lm-sensors

Hi Jean,

it works. I didn't thought about trying out "sensors" without the chip 
being found by sensors-detect. Its properly detected with the updated 
sensors-detect as well.

Here is the output of sensors:

Before:

martin@computername ~/it87 $ sensors
k10temp-pci-00c3
Adapter: PCI adapter
temp1:         +4.5°C  (high = +70.0°C)
                        (crit = +70.0°C, hyst = +69.0°C)

Now:

martin@computername ~/it87 $ sensors
k10temp-pci-00c3
Adapter: PCI adapter
temp1:         +5.0°C  (high = +70.0°C)
                        (crit = +70.0°C, hyst = +69.0°C)

it8603-isa-0290
Adapter: ISA adapter
in0:          +0.85 V  (min =  +1.21 V, max =  +0.78 V)  ALARM
in1:          +1.63 V  (min =  +0.86 V, max =  +1.52 V)  ALARM
in2:          +2.04 V  (min =  +1.97 V, max =  +0.38 V)  ALARM
in3:          +2.02 V  (min =  +0.47 V, max =  +0.02 V)  ALARM
in4:          +1.24 V  (min =  +0.43 V, max =  +0.14 V)  ALARM
3VSB:         +3.34 V  (min =  +1.87 V, max =  +1.54 V)  ALARM
Vbat:         +3.24 V
+3.3V:        +3.38 V
fan1:        1066 RPM  (min =  200 RPM)
fan2:           0 RPM  (min =  602 RPM)  ALARM
temp1:        +34.0°C  (low  = +116.0°C, high = +32.0°C)  ALARM sensor = 
thermistor
temp2:        +33.0°C  (low  = +99.0°C, high =  +0.0°C)  ALARM sensor = 
thermistor
temp3:       -128.0°C  (low  = -30.0°C, high = -80.0°C)  sensor = thermistor
intrusion0:  OK

And sensors-detect:

...

Found `ITE IT8623E Super IO Sensors' Success!
     (address 0x290, driver `it87')

...

Driver `it87':
   * ISA bus, address 0x290
     Chip `ITE IT8623E Super IO Sensors' (confidence: 9)

Thank you all for your help.

Best Regards
Martin


On 25.03.2014 12:36, Jean Delvare wrote:
> Hi Martin,
>
> On Tue, 25 Mar 2014 11:12:46 +0100, Martin Herrholz wrote:
>> i did install the module like mentioned in your linked Instructions and
>> redone the sensors-detect.
>> I still get the same result:
>>
>> Trying family `ITE'...                                      Yes
>> Found unknown chip with ID 0x8623
>>       (logical device 4 has address 0x290, could be sensors)
> This is expected, sensors-detect has its own detection code which is
> independent from the installed drivers. You can try the latest version
> at:
>    http://dl.lm-sensors.org/lm-sensors/files/sensors-detect
>
> which should detect your chip properly.
>
>> I had no it87 module installed prior to it, so i had nothing to remove.
>> The module compiles/loads without errors.
> Great. But does it work? What does "sensors" say?
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E
  2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
                   ` (3 preceding siblings ...)
  2014-03-25 11:57 ` Martin Herrholz
@ 2014-03-25 14:59 ` Rudolf Marek
  2014-03-25 15:20 ` Jean Delvare
  5 siblings, 0 replies; 8+ messages in thread
From: Rudolf Marek @ 2014-03-25 14:59 UTC (permalink / raw)
  To: lm-sensors

Hi all,

That was fast :) thank you all. Martin, most likely you can try following 
sensors.conf config.

chip "it8603-*"
     label temp1 "CPU Temp"
     label temp2 "M/B Temp"

     label in0 "Vcore"
     label in1 "in1"
     label in2 "+12V"
     label in3 "+5V"
     label fan1 "CPU Fan"
     label fan2 "CHA Fan"
     label fan3 "PWR Fan"

     compute in2  @ * (12/2), @ / (12/2)
     compute in3  @ * (25/10), @ / (25/10)

Then in2 and in3 could be same on your board, because they are wired to in2/in3 
on it8603 to support the under/overvoltage protection.

Thanks
Rudolf


On 25.3.2014 12:57, Martin Herrholz wrote:
> Hi Jean,
>
> it works. I didn't thought about trying out "sensors" without the chip being
> found by sensors-detect. Its properly detected with the updated sensors-detect
> as well.
>
> Here is the output of sensors:
>
> Before:
>
> martin@computername ~/it87 $ sensors
> k10temp-pci-00c3
> Adapter: PCI adapter
> temp1:         +4.5°C  (high = +70.0°C)
>                         (crit = +70.0°C, hyst = +69.0°C)
>
> Now:
>
> martin@computername ~/it87 $ sensors
> k10temp-pci-00c3
> Adapter: PCI adapter
> temp1:         +5.0°C  (high = +70.0°C)
>                         (crit = +70.0°C, hyst = +69.0°C)
>
> it8603-isa-0290
> Adapter: ISA adapter
> in0:          +0.85 V  (min =  +1.21 V, max =  +0.78 V)  ALARM
> in1:          +1.63 V  (min =  +0.86 V, max =  +1.52 V)  ALARM
> in2:          +2.04 V  (min =  +1.97 V, max =  +0.38 V)  ALARM
> in3:          +2.02 V  (min =  +0.47 V, max =  +0.02 V)  ALARM
> in4:          +1.24 V  (min =  +0.43 V, max =  +0.14 V)  ALARM
> 3VSB:         +3.34 V  (min =  +1.87 V, max =  +1.54 V)  ALARM
> Vbat:         +3.24 V
> +3.3V:        +3.38 V
> fan1:        1066 RPM  (min =  200 RPM)
> fan2:           0 RPM  (min =  602 RPM)  ALARM
> temp1:        +34.0°C  (low  = +116.0°C, high = +32.0°C)  ALARM sensor = thermistor
> temp2:        +33.0°C  (low  = +99.0°C, high =  +0.0°C)  ALARM sensor = thermistor
> temp3:       -128.0°C  (low  = -30.0°C, high = -80.0°C)  sensor = thermistor
> intrusion0:  OK
>
> And sensors-detect:
>
> ...
>
> Found `ITE IT8623E Super IO Sensors' Success!
>      (address 0x290, driver `it87')
>
> ...
>
> Driver `it87':
>    * ISA bus, address 0x290
>      Chip `ITE IT8623E Super IO Sensors' (confidence: 9)
>
> Thank you all for your help.
>
> Best Regards
> Martin
>
>
> On 25.03.2014 12:36, Jean Delvare wrote:
>> Hi Martin,
>>
>> On Tue, 25 Mar 2014 11:12:46 +0100, Martin Herrholz wrote:
>>> i did install the module like mentioned in your linked Instructions and
>>> redone the sensors-detect.
>>> I still get the same result:
>>>
>>> Trying family `ITE'...                                      Yes
>>> Found unknown chip with ID 0x8623
>>>       (logical device 4 has address 0x290, could be sensors)
>> This is expected, sensors-detect has its own detection code which is
>> independent from the installed drivers. You can try the latest version
>> at:
>>    http://dl.lm-sensors.org/lm-sensors/files/sensors-detect
>>
>> which should detect your chip properly.
>>
>>> I had no it87 module installed prior to it, so i had nothing to remove.
>>> The module compiles/loads without errors.
>> Great. But does it work? What does "sensors" say?
>>
>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E
  2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
                   ` (4 preceding siblings ...)
  2014-03-25 14:59 ` Rudolf Marek
@ 2014-03-25 15:20 ` Jean Delvare
  5 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2014-03-25 15:20 UTC (permalink / raw)
  To: lm-sensors

Hi Rudolf, Martin,

On Tue, 25 Mar 2014 15:59:23 +0100, Rudolf Marek wrote:
> Hi all,
> 
> That was fast :) thank you all.

Well, thank _you_ for the patch :)

> Martin, most likely you can try following 
> sensors.conf config.
> 
> chip "it8603-*"
>      label temp1 "CPU Temp"
>      label temp2 "M/B Temp"

I would add:

     ignore temp3

as this input doesn't seem to be connected.

> 
>      label in0 "Vcore"
>      label in1 "in1"

Not very useful ^^

>      label in2 "+12V"
>      label in3 "+5V"
>      label fan1 "CPU Fan"
>      label fan2 "CHA Fan"
>      label fan3 "PWR Fan"

There doesn't seem to be a fan3 on Martin's system, so he should omit
that line.

> 
>      compute in2  @ * (12/2), @ / (12/2)
>      compute in3  @ * (25/10), @ / (25/10)
> 
> Then in2 and in3 could be same on your board, because they are wired to in2/in3 
> on it8603 to support the under/overvoltage protection.

If that doesn't work, Martin could always comment out the compute
statements and follow my guide at:
http://www.lm-sensors.org/wiki/VoltageLabelsAndScaling

I would also suggest adding the following set statements to get rid of
most of the ALARMs:

   set in0_min   0.800  # Should be adjusted depending on CPU model
   set in0_max   1.200  # Should be adjusted depending on CPU model
   set in2_min  12 * 0.95
   set in2_max  12 * 1.05
   set in3_min   5 * 0.95
   set in3_max   5 * 1.05
   set in7_min 3.0 * 0.95
   set in7_max 3.3 * 1.05

   set temp1_min  5
   set temp1_max 60
   set temp2_min  5
   set temp2_max 60

(Don't forget to run "sensors -s" afterward.)

-- 
Jean Delvare
http://jdelvare.nerim.net/wishlist.html

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-03-25 15:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-02 19:17 [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8772E Guenter Roeck
2014-03-25  8:24 ` [lm-sensors] [PATCH 2/2] hwmon: (it87) Add support for IT8623E Jean Delvare
2014-03-25 10:12 ` Martin Herrholz
2014-03-25 11:36 ` Jean Delvare
2014-03-25 11:57 ` Martin Herrholz
2014-03-25 14:59 ` Rudolf Marek
2014-03-25 15:20 ` Jean Delvare
  -- strict thread matches above, loose matches on Subject: below --
2014-03-24 22:23 Rudolf Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.