Re: [PATCH 4/4 v2] ath10k: invalid msdu-id logging

From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/4 v2] ath10k:  invalid msdu-id logging
Date: Tue, 25 Mar 2014 08:56:43 -0700	[thread overview]
Message-ID: <5331A73B.9080803@candelatech.com> (raw)
In-Reply-To: <87txam1o70.fsf@kamboji.qca.qualcomm.com>

On 03/25/2014 05:02 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
> 
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Make this message more obvious that it is a serious
>> problem (will cause tx flush issues, at least).
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>>
>> v2:  Add this to series, but ordering is not overly important.
>>
> 
> [...]
> 
>> --- a/drivers/net/wireless/ath/ath10k/txrx.c
>> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
>> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>>  		   tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>>  
>>  	if (tx_done->msdu_id >= htt->max_num_pending_tx) {
>> -		ath10k_warn("warning: msdu_id %d too big, ignoring\n",
>> +		ath10k_warn("error: msdu_id %d too big, ignoring\n",
>>  			    tx_done->msdu_id);
>>  		return;
>>  	}
> 
> To me any warning is a serious matter, I'm not sure how changing this to
> message to use "error:" makes any difference?

To me, warning is bad, but probably not critical.  Error would be a failure that
is not (easily) recovered from.  In the case above, the result of this problem
would be effectively a reference counting leak that hangs the driver for 5 seconds
(under rtnl lock, I believe) each time the driver tries to flush.  This will never
recover until firmware is restarted.

So, I think it is more of an error than warning, but it is not a big deal
either way, so feel free to just drop the patch.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k