From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/4 v2] ath10k: invalid msdu-id logging
Date: Tue, 25 Mar 2014 14:02:11 +0200 [thread overview]
Message-ID: <87txam1o70.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395688844-24640-5-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Mon, 24 Mar 2014 12:20:44 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Make this message more obvious that it is a serious
> problem (will cause tx flush issues, at least).
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2: Add this to series, but ordering is not overly important.
>
[...]
> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
> tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>
> if (tx_done->msdu_id >= htt->max_num_pending_tx) {
> - ath10k_warn("warning: msdu_id %d too big, ignoring\n",
> + ath10k_warn("error: msdu_id %d too big, ignoring\n",
> tx_done->msdu_id);
> return;
> }
To me any warning is a serious matter, I'm not sure how changing this to
message to use "error:" makes any difference?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/4 v2] ath10k: invalid msdu-id logging
Date: Tue, 25 Mar 2014 14:02:11 +0200 [thread overview]
Message-ID: <87txam1o70.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395688844-24640-5-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Mon, 24 Mar 2014 12:20:44 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Make this message more obvious that it is a serious
> problem (will cause tx flush issues, at least).
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2: Add this to series, but ordering is not overly important.
>
[...]
> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
> tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>
> if (tx_done->msdu_id >= htt->max_num_pending_tx) {
> - ath10k_warn("warning: msdu_id %d too big, ignoring\n",
> + ath10k_warn("error: msdu_id %d too big, ignoring\n",
> tx_done->msdu_id);
> return;
> }
To me any warning is a serious matter, I'm not sure how changing this to
message to use "error:" makes any difference?
--
Kalle Valo
next prev parent reply other threads:[~2014-03-25 12:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 19:20 [PATCH 1/4 v2] ath10k: add debugging for tx-credits usage greearb
2014-03-24 19:20 ` greearb
2014-03-24 19:20 ` [PATCH 2/4 v2] ath10k: better firmware loading error messages greearb
2014-03-24 19:20 ` greearb
2014-03-28 7:43 ` Kalle Valo
2014-03-28 7:43 ` Kalle Valo
2014-03-24 19:20 ` [PATCH 3/4 v2] ath10k: add otp and firmware boot " greearb
2014-03-24 19:20 ` greearb
2014-03-24 19:20 ` [PATCH 4/4 v2] ath10k: invalid msdu-id logging greearb
2014-03-24 19:20 ` greearb
2014-03-25 12:02 ` Kalle Valo [this message]
2014-03-25 12:02 ` Kalle Valo
2014-03-25 15:56 ` Ben Greear
2014-03-25 15:56 ` Ben Greear
2014-03-25 11:59 ` [PATCH 1/4 v2] ath10k: add debugging for tx-credits usage Kalle Valo
2014-03-25 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txam1o70.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.