All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Vlad Yasevich <vyasevic@redhat.com>, netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump
Date: Fri, 28 Mar 2014 12:33:11 +0900	[thread overview]
Message-ID: <5334ED77.4080601@lab.ntt.co.jp> (raw)
In-Reply-To: <1395971478-10689-1-git-send-email-vyasevic@redhat.com>

(2014/03/28 10:51), Vlad Yasevich wrote:
> When the vlan filtering is enabled on the bridge, but
> the filter is not configured on the bridge device itself,
> running tcpdump on the bridge device will result in a
> an Oops with NULL pointer dereference.  The reason
> is that br_pass_frame_up() will bypass the vlan
> check because promisc flag is set.  It will then try
> to get the table pointer and process the packet based
> on the table.  Since the table pointer is NULL, we oops.
> Catch this special condition in br_handle_vlan().
> 
> Reported-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> CC: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>

Thanks,

Acked-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>

WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Vlad Yasevich <vyasevic@redhat.com>, netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org
Subject: Re: [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump
Date: Fri, 28 Mar 2014 12:33:11 +0900	[thread overview]
Message-ID: <5334ED77.4080601@lab.ntt.co.jp> (raw)
In-Reply-To: <1395971478-10689-1-git-send-email-vyasevic@redhat.com>

(2014/03/28 10:51), Vlad Yasevich wrote:
> When the vlan filtering is enabled on the bridge, but
> the filter is not configured on the bridge device itself,
> running tcpdump on the bridge device will result in a
> an Oops with NULL pointer dereference.  The reason
> is that br_pass_frame_up() will bypass the vlan
> check because promisc flag is set.  It will then try
> to get the table pointer and process the packet based
> on the table.  Since the table pointer is NULL, we oops.
> Catch this special condition in br_handle_vlan().
> 
> Reported-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> CC: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>

Thanks,

Acked-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>

  reply	other threads:[~2014-03-28  3:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  1:51 [Bridge] [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump Vlad Yasevich
2014-03-28  1:51 ` Vlad Yasevich
2014-03-28  3:33 ` Toshiaki Makita [this message]
2014-03-28  3:33   ` Toshiaki Makita
2014-03-28 21:14 ` [Bridge] " David Miller
2014-03-28 21:14   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5334ED77.4080601@lab.ntt.co.jp \
    --to=makita.toshiaki@lab.ntt.co.jp \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.