From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
Date: Sun, 14 May 2017 16:59:17 +0200 [thread overview]
Message-ID: <53387334.ADQf94xZqP@phil> (raw)
In-Reply-To: <20170507143446.11502-1-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
Hi Randy,
Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
> The PWM devices need to access the grf to switch the PWM IP.
The grf property is not part of the pwm binding and I remember
this coming up in veyron times, when Thiery didn't want such settings
in the pwm driver. So the kernel pwm driver does not switch anything
right now.
> And tsadc uses it to shutdown the system.
No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
as it is using the v2_initialize function. Only rk3366 and rk3399 seem
to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
patch from you pending to change that?
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
Date: Sun, 14 May 2017 16:59:17 +0200 [thread overview]
Message-ID: <53387334.ADQf94xZqP@phil> (raw)
In-Reply-To: <20170507143446.11502-1-ayaka@soulik.info>
Hi Randy,
Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
> The PWM devices need to access the grf to switch the PWM IP.
The grf property is not part of the pwm binding and I remember
this coming up in veyron times, when Thiery didn't want such settings
in the pwm driver. So the kernel pwm driver does not switch anything
right now.
> And tsadc uses it to shutdown the system.
No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
as it is using the v2_initialize function. Only rk3366 and rk3399 seem
to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
patch from you pending to change that?
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Randy Li <ayaka@soulik.info>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
Date: Sun, 14 May 2017 16:59:17 +0200 [thread overview]
Message-ID: <53387334.ADQf94xZqP@phil> (raw)
In-Reply-To: <20170507143446.11502-1-ayaka@soulik.info>
Hi Randy,
Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
> The PWM devices need to access the grf to switch the PWM IP.
The grf property is not part of the pwm binding and I remember
this coming up in veyron times, when Thiery didn't want such settings
in the pwm driver. So the kernel pwm driver does not switch anything
right now.
> And tsadc uses it to shutdown the system.
No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
as it is using the v2_initialize function. Only rk3366 and rk3399 seem
to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
patch from you pending to change that?
Heiko
next prev parent reply other threads:[~2017-05-14 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 14:34 [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288 Randy Li
2017-05-07 14:34 ` Randy Li
2017-05-07 14:34 ` Randy Li
[not found] ` <20170507143446.11502-1-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2017-05-14 14:59 ` Heiko Stuebner [this message]
2017-05-14 14:59 ` Heiko Stuebner
2017-05-14 14:59 ` Heiko Stuebner
2017-05-14 15:10 ` ayaka
2017-05-14 15:10 ` ayaka
2017-05-14 15:10 ` ayaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53387334.ADQf94xZqP@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.