* [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-07 14:34 ` Randy Li
0 siblings, 0 replies; 9+ messages in thread
From: Randy Li @ 2017-05-07 14:34 UTC (permalink / raw)
To: devicetree
Cc: mark.rutland, heiko, Randy Li, linux, linux-kernel,
linux-rockchip, robh+dt, linux-arm-kernel
The PWM devices need to access the grf to switch the PWM IP.
And tsadc uses it to shutdown the system.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
arch/arm/boot/dts/rk3288.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 26b8886..c1d3b1f 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -546,6 +546,7 @@
pinctrl-2 = <&otp_gpio>;
#thermal-sensor-cells = <1>;
rockchip,hw-tshut-temp = <95000>;
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -654,6 +655,7 @@
pinctrl-0 = <&pwm0_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -665,6 +667,7 @@
pinctrl-0 = <&pwm1_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -676,6 +679,7 @@
pinctrl-0 = <&pwm2_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -687,6 +691,7 @@
pinctrl-0 = <&pwm3_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-07 14:34 ` Randy Li
0 siblings, 0 replies; 9+ messages in thread
From: Randy Li @ 2017-05-07 14:34 UTC (permalink / raw)
To: devicetree
Cc: heiko, robh+dt, mark.rutland, linux, linux-arm-kernel,
linux-rockchip, linux-kernel, Randy Li
The PWM devices need to access the grf to switch the PWM IP.
And tsadc uses it to shutdown the system.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
arch/arm/boot/dts/rk3288.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 26b8886..c1d3b1f 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -546,6 +546,7 @@
pinctrl-2 = <&otp_gpio>;
#thermal-sensor-cells = <1>;
rockchip,hw-tshut-temp = <95000>;
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -654,6 +655,7 @@
pinctrl-0 = <&pwm0_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -665,6 +667,7 @@
pinctrl-0 = <&pwm1_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -676,6 +679,7 @@
pinctrl-0 = <&pwm2_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -687,6 +691,7 @@
pinctrl-0 = <&pwm3_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-07 14:34 ` Randy Li
0 siblings, 0 replies; 9+ messages in thread
From: Randy Li @ 2017-05-07 14:34 UTC (permalink / raw)
To: linux-arm-kernel
The PWM devices need to access the grf to switch the PWM IP.
And tsadc uses it to shutdown the system.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
arch/arm/boot/dts/rk3288.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 26b8886..c1d3b1f 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -546,6 +546,7 @@
pinctrl-2 = <&otp_gpio>;
#thermal-sensor-cells = <1>;
rockchip,hw-tshut-temp = <95000>;
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -654,6 +655,7 @@
pinctrl-0 = <&pwm0_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -665,6 +667,7 @@
pinctrl-0 = <&pwm1_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -676,6 +679,7 @@
pinctrl-0 = <&pwm2_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
@@ -687,6 +691,7 @@
pinctrl-0 = <&pwm3_pin>;
clocks = <&cru PCLK_PWM>;
clock-names = "pwm";
+ rockchip,grf = <&grf>;
status = "disabled";
};
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <20170507143446.11502-1-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>]
* Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
2017-05-07 14:34 ` Randy Li
(?)
@ 2017-05-14 14:59 ` Heiko Stuebner
-1 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2017-05-14 14:59 UTC (permalink / raw)
To: Randy Li
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Randy,
Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
> The PWM devices need to access the grf to switch the PWM IP.
The grf property is not part of the pwm binding and I remember
this coming up in veyron times, when Thiery didn't want such settings
in the pwm driver. So the kernel pwm driver does not switch anything
right now.
> And tsadc uses it to shutdown the system.
No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
as it is using the v2_initialize function. Only rk3366 and rk3399 seem
to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
patch from you pending to change that?
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-14 14:59 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2017-05-14 14:59 UTC (permalink / raw)
To: Randy Li
Cc: devicetree, robh+dt, mark.rutland, linux, linux-arm-kernel,
linux-rockchip, linux-kernel
Hi Randy,
Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
> The PWM devices need to access the grf to switch the PWM IP.
The grf property is not part of the pwm binding and I remember
this coming up in veyron times, when Thiery didn't want such settings
in the pwm driver. So the kernel pwm driver does not switch anything
right now.
> And tsadc uses it to shutdown the system.
No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
as it is using the v2_initialize function. Only rk3366 and rk3399 seem
to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
patch from you pending to change that?
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-14 14:59 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2017-05-14 14:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Randy,
Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
> The PWM devices need to access the grf to switch the PWM IP.
The grf property is not part of the pwm binding and I remember
this coming up in veyron times, when Thiery didn't want such settings
in the pwm driver. So the kernel pwm driver does not switch anything
right now.
> And tsadc uses it to shutdown the system.
No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
as it is using the v2_initialize function. Only rk3366 and rk3399 seem
to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
patch from you pending to change that?
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
2017-05-14 14:59 ` Heiko Stuebner
(?)
@ 2017-05-14 15:10 ` ayaka
-1 siblings, 0 replies; 9+ messages in thread
From: ayaka @ 2017-05-14 15:10 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 05/14/2017 10:59 PM, Heiko Stuebner wrote:
> Hi Randy,
>
> Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
>> The PWM devices need to access the grf to switch the PWM IP.
> The grf property is not part of the pwm binding and I remember
> this coming up in veyron times, when Thiery didn't want such settings
> in the pwm driver. So the kernel pwm driver does not switch anything
> right now.
OK, I see, I will contact the u-boot, submit a patch there.
>
>
>> And tsadc uses it to shutdown the system.
> No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
> as it is using the v2_initialize function. Only rk3366 and rk3399 seem
> to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
> patch from you pending to change that?
Not yet, there is a register CRU_GLB_RST_ST at rk3288 cru. I think I
need to submit a patch for it.
>
>
> Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-14 15:10 ` ayaka
0 siblings, 0 replies; 9+ messages in thread
From: ayaka @ 2017-05-14 15:10 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, robh+dt, mark.rutland, linux, linux-arm-kernel,
linux-rockchip, linux-kernel
On 05/14/2017 10:59 PM, Heiko Stuebner wrote:
> Hi Randy,
>
> Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
>> The PWM devices need to access the grf to switch the PWM IP.
> The grf property is not part of the pwm binding and I remember
> this coming up in veyron times, when Thiery didn't want such settings
> in the pwm driver. So the kernel pwm driver does not switch anything
> right now.
OK, I see, I will contact the u-boot, submit a patch there.
>
>
>> And tsadc uses it to shutdown the system.
> No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
> as it is using the v2_initialize function. Only rk3366 and rk3399 seem
> to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
> patch from you pending to change that?
Not yet, there is a register CRU_GLB_RST_ST at rk3288 cru. I think I
need to submit a patch for it.
>
>
> Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288
@ 2017-05-14 15:10 ` ayaka
0 siblings, 0 replies; 9+ messages in thread
From: ayaka @ 2017-05-14 15:10 UTC (permalink / raw)
To: linux-arm-kernel
On 05/14/2017 10:59 PM, Heiko Stuebner wrote:
> Hi Randy,
>
> Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li:
>> The PWM devices need to access the grf to switch the PWM IP.
> The grf property is not part of the pwm binding and I remember
> this coming up in veyron times, when Thiery didn't want such settings
> in the pwm driver. So the kernel pwm driver does not switch anything
> right now.
OK, I see, I will contact the u-boot, submit a patch there.
>
>
>> And tsadc uses it to shutdown the system.
> No it doesn't. The tsadc on rk3288 does not do any grf settings right now,
> as it is using the v2_initialize function. Only rk3366 and rk3399 seem
> to do any grf settings in the current v4.12-rc1 . Or is there some tsadc
> patch from you pending to change that?
Not yet, there is a register CRU_GLB_RST_ST at rk3288 cru. I think I
need to submit a patch for it.
>
>
> Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-05-14 15:10 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-07 14:34 [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288 Randy Li
2017-05-07 14:34 ` Randy Li
2017-05-07 14:34 ` Randy Li
[not found] ` <20170507143446.11502-1-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2017-05-14 14:59 ` Heiko Stuebner
2017-05-14 14:59 ` Heiko Stuebner
2017-05-14 14:59 ` Heiko Stuebner
2017-05-14 15:10 ` ayaka
2017-05-14 15:10 ` ayaka
2017-05-14 15:10 ` ayaka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.