From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
magnus.damm@opensource.se, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap
Date: Tue, 01 Apr 2014 11:59:06 +0100 [thread overview]
Message-ID: <533A9BFA.7090503@codethink.co.uk> (raw)
In-Reply-To: <CAMuHMdVB6ZB0rnH5ekRd=NCy3zbFSTf0BSH3J48yDhF2YbNoCA@mail.gmail.com>
On 01/04/14 11:55, Geert Uytterhoeven wrote:
> On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> + reg = devm_ioremap_resource(&pdev->dev, res);
>> + if (IS_ERR(reg)) {
>> dev_err(&pdev->dev, "ioremap error.\n");
>
> devm_ioremap_resource() already calls dev_err() for the various error
> cases, so you can drop this line.
>
>> return -ENOMEM;
Oops. Will fix.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
magnus.damm@opensource.se, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap
Date: Tue, 01 Apr 2014 10:59:06 +0000 [thread overview]
Message-ID: <533A9BFA.7090503@codethink.co.uk> (raw)
In-Reply-To: <CAMuHMdVB6ZB0rnH5ekRd=NCy3zbFSTf0BSH3J48yDhF2YbNoCA@mail.gmail.com>
On 01/04/14 11:55, Geert Uytterhoeven wrote:
> On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> + reg = devm_ioremap_resource(&pdev->dev, res);
>> + if (IS_ERR(reg)) {
>> dev_err(&pdev->dev, "ioremap error.\n");
>
> devm_ioremap_resource() already calls dev_err() for the various error
> cases, so you can drop this line.
>
>> return -ENOMEM;
Oops. Will fix.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-04-01 10:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 10:25 cleanups for sh-mmcif driver Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 1/6] mmc: sh-mmcif: print bus clock rate on probe Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:45 ` Geert Uytterhoeven
2014-04-01 10:45 ` Geert Uytterhoeven
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:37 ` Ben Dooks
2014-04-01 11:37 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:55 ` Geert Uytterhoeven
2014-04-01 10:55 ` Geert Uytterhoeven
2014-04-01 10:59 ` Ben Dooks [this message]
2014-04-01 10:59 ` Ben Dooks
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:26 ` Sergei Shtylyov
2014-04-01 11:26 ` Sergei Shtylyov
2014-04-01 10:25 ` [PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:59 ` Geert Uytterhoeven
2014-04-01 10:59 ` Geert Uytterhoeven
2014-04-01 11:25 ` Ben Dooks
2014-04-01 11:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 4/6] mmc: sh-mmcif: use devm_ for irq management Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 5/6] mmc: sh-mmcif: no need to call pm_runtime_suspend on error Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 6/6] mmc: sh-mmcif: final error path cleanup Ben Dooks
2014-04-01 10:25 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2014-06-04 11:42 resend - sh mmcif driver cleanup patch series Ben Dooks
2014-06-04 11:42 ` [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap Ben Dooks
2014-06-04 12:58 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533A9BFA.7090503@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=chris@printf.net \
--cc=g.liakhovetski@gmx.de \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@opensource.se \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.