From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
magnus.damm@opensource.se, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 1/6] mmc: sh-mmcif: print bus clock rate on probe
Date: Tue, 01 Apr 2014 12:37:08 +0100 [thread overview]
Message-ID: <533AA4E4.5070805@codethink.co.uk> (raw)
In-Reply-To: <5193000.YsnDiAM2O1@avalon>
On 01/04/14 12:08, Laurent Pinchart wrote:
> Hi Ben,
>
> Thank you for the patch.
>
> On Tuesday 01 April 2014 11:25:49 Ben Dooks wrote:
>> Add a print to show the host-bus clock rate for mmcif on probe to allow
>> easy check on what clock rate the bus clock is at.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/mmc/host/sh_mmcif.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
>> index e8713d7..c48df98 100644
>> --- a/drivers/mmc/host/sh_mmcif.c
>> +++ b/drivers/mmc/host/sh_mmcif.c
>> @@ -1477,7 +1477,8 @@ static int sh_mmcif_probe(struct platform_device
>> *pdev)
>>
>> dev_pm_qos_expose_latency_limit(&pdev->dev, 100);
>>
>> - dev_info(&pdev->dev, "driver version %s\n", DRIVER_VERSION);
>> + dev_info(&pdev->dev, "driver version %s, clock rate %ldMHz\n",
>> + DRIVER_VERSION, clk_get_rate(host->hclk) / 1000000);
>> dev_dbg(&pdev->dev, "chip ver H'%04x\n",
>> sh_mmcif_readl(host->addr, MMCIF_CE_VERSION) & 0x0000ffff);
>> return ret;
>
> Given that DRIVER_VERSION is defined as "2010-04-28", I'd take this as an
> opportunity to remove it completely. You could combine the dev_info and
> dev_dbg message into something similar to
Ok, changed to use this.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
magnus.damm@opensource.se, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 1/6] mmc: sh-mmcif: print bus clock rate on probe
Date: Tue, 01 Apr 2014 11:37:08 +0000 [thread overview]
Message-ID: <533AA4E4.5070805@codethink.co.uk> (raw)
In-Reply-To: <5193000.YsnDiAM2O1@avalon>
On 01/04/14 12:08, Laurent Pinchart wrote:
> Hi Ben,
>
> Thank you for the patch.
>
> On Tuesday 01 April 2014 11:25:49 Ben Dooks wrote:
>> Add a print to show the host-bus clock rate for mmcif on probe to allow
>> easy check on what clock rate the bus clock is at.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/mmc/host/sh_mmcif.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
>> index e8713d7..c48df98 100644
>> --- a/drivers/mmc/host/sh_mmcif.c
>> +++ b/drivers/mmc/host/sh_mmcif.c
>> @@ -1477,7 +1477,8 @@ static int sh_mmcif_probe(struct platform_device
>> *pdev)
>>
>> dev_pm_qos_expose_latency_limit(&pdev->dev, 100);
>>
>> - dev_info(&pdev->dev, "driver version %s\n", DRIVER_VERSION);
>> + dev_info(&pdev->dev, "driver version %s, clock rate %ldMHz\n",
>> + DRIVER_VERSION, clk_get_rate(host->hclk) / 1000000);
>> dev_dbg(&pdev->dev, "chip ver H'%04x\n",
>> sh_mmcif_readl(host->addr, MMCIF_CE_VERSION) & 0x0000ffff);
>> return ret;
>
> Given that DRIVER_VERSION is defined as "2010-04-28", I'd take this as an
> opportunity to remove it completely. You could combine the dev_info and
> dev_dbg message into something similar to
Ok, changed to use this.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-04-01 11:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 10:25 cleanups for sh-mmcif driver Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 1/6] mmc: sh-mmcif: print bus clock rate on probe Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:45 ` Geert Uytterhoeven
2014-04-01 10:45 ` Geert Uytterhoeven
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:37 ` Ben Dooks [this message]
2014-04-01 11:37 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:55 ` Geert Uytterhoeven
2014-04-01 10:55 ` Geert Uytterhoeven
2014-04-01 10:59 ` Ben Dooks
2014-04-01 10:59 ` Ben Dooks
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:08 ` Laurent Pinchart
2014-04-01 11:26 ` Sergei Shtylyov
2014-04-01 11:26 ` Sergei Shtylyov
2014-04-01 10:25 ` [PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:59 ` Geert Uytterhoeven
2014-04-01 10:59 ` Geert Uytterhoeven
2014-04-01 11:25 ` Ben Dooks
2014-04-01 11:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 4/6] mmc: sh-mmcif: use devm_ for irq management Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 5/6] mmc: sh-mmcif: no need to call pm_runtime_suspend on error Ben Dooks
2014-04-01 10:25 ` Ben Dooks
2014-04-01 10:25 ` [PATCH 6/6] mmc: sh-mmcif: final error path cleanup Ben Dooks
2014-04-01 10:25 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533AA4E4.5070805@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=chris@printf.net \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@opensource.se \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.