From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Dave Hansen <dave.hansen@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org,
benh@kernel.crashing.org, paulus@samba.org,
kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au,
akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de,
ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org
Subject: Re: [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/
Date: Wed, 02 Apr 2014 10:15:42 +0530 [thread overview]
Message-ID: <533B95F6.2010303@linux.vnet.ibm.com> (raw)
In-Reply-To: <5331C1C9.5020309@intel.com>
On Tuesday 25 March 2014 11:20 PM, Dave Hansen wrote:
> On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote:
>>>> +/*
>>>> + * Fault around order is a control knob to decide the fault around pages.
>>>> + * Default value is set to 0UL (disabled), but the arch can override it as
>>>> + * desired.
>>>> + */
>>>> +#ifndef FAULT_AROUND_ORDER
>>>> +#define FAULT_AROUND_ORDER 0UL
>>>> +#endif
>> FAULT_AROUND_ORDER == 0 case should be handled separately in
>> do_read_fault(): no reason to go to do_fault_around() if we are going to
>> fault in only one page.
>
> Isn't this the kind of thing we want to do in Kconfig?
>
>
I am still investigating this option since this looks better. But it is
taking time, my bad. I will get back on this.
With Regards
Maddy
WARNING: multiple messages have this Message-ID (diff)
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Dave Hansen <dave.hansen@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-arch@vger.kernel.org, riel@redhat.com,
rusty@rustcorp.com.au, peterz@infradead.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ak@linux.intel.com, paulus@samba.org, mgorman@suse.de,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
mingo@kernel.org, kirill.shutemov@linux.intel.com
Subject: Re: [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/
Date: Wed, 02 Apr 2014 10:15:42 +0530 [thread overview]
Message-ID: <533B95F6.2010303@linux.vnet.ibm.com> (raw)
In-Reply-To: <5331C1C9.5020309@intel.com>
On Tuesday 25 March 2014 11:20 PM, Dave Hansen wrote:
> On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote:
>>>> +/*
>>>> + * Fault around order is a control knob to decide the fault around pages.
>>>> + * Default value is set to 0UL (disabled), but the arch can override it as
>>>> + * desired.
>>>> + */
>>>> +#ifndef FAULT_AROUND_ORDER
>>>> +#define FAULT_AROUND_ORDER 0UL
>>>> +#endif
>> FAULT_AROUND_ORDER == 0 case should be handled separately in
>> do_read_fault(): no reason to go to do_fault_around() if we are going to
>> fault in only one page.
>
> Isn't this the kind of thing we want to do in Kconfig?
>
>
I am still investigating this option since this looks better. But it is
taking time, my bad. I will get back on this.
With Regards
Maddy
WARNING: multiple messages have this Message-ID (diff)
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Dave Hansen <dave.hansen@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org,
benh@kernel.crashing.org, paulus@samba.org,
kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au,
akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de,
ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org
Subject: Re: [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/
Date: Wed, 02 Apr 2014 10:15:42 +0530 [thread overview]
Message-ID: <533B95F6.2010303@linux.vnet.ibm.com> (raw)
In-Reply-To: <5331C1C9.5020309@intel.com>
On Tuesday 25 March 2014 11:20 PM, Dave Hansen wrote:
> On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote:
>>>> +/*
>>>> + * Fault around order is a control knob to decide the fault around pages.
>>>> + * Default value is set to 0UL (disabled), but the arch can override it as
>>>> + * desired.
>>>> + */
>>>> +#ifndef FAULT_AROUND_ORDER
>>>> +#define FAULT_AROUND_ORDER 0UL
>>>> +#endif
>> FAULT_AROUND_ORDER == 0 case should be handled separately in
>> do_read_fault(): no reason to go to do_fault_around() if we are going to
>> fault in only one page.
>
> Isn't this the kind of thing we want to do in Kconfig?
>
>
I am still investigating this option since this looks better. But it is
taking time, my bad. I will get back on this.
With Regards
Maddy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-02 4:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 6:50 [PATCH 0/1] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-03-25 6:50 ` Madhavan Srinivasan
2014-03-25 6:50 ` Madhavan Srinivasan
2014-03-25 6:50 ` [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/ Madhavan Srinivasan
2014-03-25 6:50 ` Madhavan Srinivasan
2014-03-25 6:50 ` Madhavan Srinivasan
2014-03-25 17:36 ` Kirill A. Shutemov
2014-03-25 17:36 ` Kirill A. Shutemov
2014-03-25 17:36 ` Kirill A. Shutemov
2014-03-25 17:50 ` Dave Hansen
2014-03-25 17:50 ` Dave Hansen
2014-03-25 17:50 ` Dave Hansen
2014-04-02 4:45 ` Madhavan Srinivasan [this message]
2014-04-02 4:45 ` Madhavan Srinivasan
2014-04-02 4:45 ` Madhavan Srinivasan
2014-03-27 6:20 ` Madhavan Srinivasan
2014-03-27 6:20 ` Madhavan Srinivasan
2014-03-27 6:20 ` Madhavan Srinivasan
2014-03-25 8:11 ` [PATCH 0/1] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Ingo Molnar
2014-03-25 8:11 ` Ingo Molnar
2014-03-25 8:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533B95F6.2010303@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.