[tegrarcm PATCH 1/1] tegrarcm: Add odm production secure mode support

[tegrarcm PATCH 1/1] tegrarcm: Add odm production secure mode support

[Penny Chiu]

tegrarcm should work if the operating mode is ODM production
secure mode. Add the operating mode definition and description.

Signed-off-by: Penny Chiu <pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 src/main.c | 4 +++-
 src/rcm.h  | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index fe29df0..50adc14 100644
--- a/src/main.c
+++ b/src/main.c
@@ -290,8 +290,9 @@ int main(int argc, char **argv)
 
 	if (info.op_mode != RCM_OP_MODE_DEVEL &&
 	    info.op_mode != RCM_OP_MODE_ODM_OPEN &&
+	    info.op_mode != RCM_OP_MODE_ODM_SECURE &&
 	    info.op_mode != RCM_OP_MODE_PRE_PRODUCTION)
-		error(1, ENODEV, "device is not in developer, open, "
+		error(1, ENODEV, "device is not in developer, open, secure, "
 		      "or pre-production mode, cannot flash");
 
 	// download the BCT
@@ -654,6 +655,7 @@ static void dump_platform_info(nv3p_platform_info_t *info)
 	case RCM_OP_MODE_PRE_PRODUCTION:    op_mode = "pre-production mode"; break;
 	case RCM_OP_MODE_DEVEL:             op_mode = "developer mode"; break;
 	case RCM_OP_MODE_ODM_OPEN:          op_mode = "odm open mode"; break;
+	case RCM_OP_MODE_ODM_SECURE:        op_mode = "odm secure mode"; break;
 	default:                            op_mode = "unknown"; break;
 	}
 	printf(" (%s)\n", op_mode);
diff --git a/src/rcm.h b/src/rcm.h
index 505547c..ab4bea2 100644
--- a/src/rcm.h
+++ b/src/rcm.h
@@ -107,6 +107,7 @@ typedef struct {
 // security operating modes
 #define RCM_OP_MODE_PRE_PRODUCTION  0x1
 #define RCM_OP_MODE_DEVEL           0x3
+#define RCM_OP_MODE_ODM_SECURE      0x4
 #define RCM_OP_MODE_ODM_OPEN        0x5
 
 int rcm_init(uint32_t version);
-- 
1.9.1

Re: [tegrarcm PATCH 1/1] tegrarcm: Add odm production secure mode support

[Stephen Warren]

On 04/01/2014 07:57 PM, Penny Chiu wrote:
> tegrarcm should work if the operating mode is ODM production
> secure mode. Add the operating mode definition and description.

> diff --git a/src/main.c b/src/main.c

>  	if (info.op_mode != RCM_OP_MODE_DEVEL &&
>  	    info.op_mode != RCM_OP_MODE_ODM_OPEN &&
> +	    info.op_mode != RCM_OP_MODE_ODM_SECURE &&
>  	    info.op_mode != RCM_OP_MODE_PRE_PRODUCTION)

Are there even more modes beyond those? I wonder if that check is even
necessary any more, or whether tegrarcm should just try to communicate
no matter what.

Still, any changes here can be addressed in a separate patch.

Acked-by:
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Allen, will you apply this or do you want me to?

Re: [tegrarcm PATCH 1/1] tegrarcm: Add odm production secure mode support

[Allen Martin]

On Wed, Apr 02, 2014 at 10:06:54AM -0700, Stephen Warren wrote:
> On 04/01/2014 07:57 PM, Penny Chiu wrote:
> > tegrarcm should work if the operating mode is ODM production
> > secure mode. Add the operating mode definition and description.
> 
> > diff --git a/src/main.c b/src/main.c
> 
> >  	if (info.op_mode != RCM_OP_MODE_DEVEL &&
> >  	    info.op_mode != RCM_OP_MODE_ODM_OPEN &&
> > +	    info.op_mode != RCM_OP_MODE_ODM_SECURE &&
> >  	    info.op_mode != RCM_OP_MODE_PRE_PRODUCTION)
> 
> Are there even more modes beyond those? I wonder if that check is even
> necessary any more, or whether tegrarcm should just try to communicate
> no matter what.

There are other modes, but they are all secure modes, and tegrarcm has
no support for encrypting RCM payloads today, so the proper thing to
do is fail if its not one of these modes.

> Still, any changes here can be addressed in a separate patch.
> 
> Acked-by:
> Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Allen, will you apply this or do you want me to?

Acked-by: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

I will apply.

-Allen

nvpublic