All of lore.kernel.org
 help / color / mirror / Atom feed
From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Fix duplicated Kconfig entries again
Date: Thu, 03 Apr 2014 19:01:46 +0800	[thread overview]
Message-ID: <533D3F9A.5070001@linaro.org> (raw)
In-Reply-To: <CAKohpok5KCmR4UYG1ZkGL2TcXqqO7dPJnwGg49ahU-ceL1+wxA@mail.gmail.com>

On 2014-4-3 17:38, Viresh Kumar wrote:
> On 3 April 2014 14:57, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> Great, thanks Viresh to let me know this.
>> Actually I also sent a patch named "arm64: Fix duplicated Kconfig entries
>> again" about one week ago :)
>>
>> https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg612363.html
>>
>> And I think there is still a problem after commit 62d1a3ba - multi-entries
>> for source "kernel/power/Kconfig", so how about the following fix?
> 
> I didn't notice that :)
> 
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index e6e4d37..6085dca 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -317,14 +317,8 @@ config ARCH_SUSPEND_POSSIBLE
>>  config ARM64_CPU_SUSPEND
>>         def_bool PM_SLEEP
>>
>> -endmenu
>> -
>> -menu "CPU Power Management"
>> -
>>  source "drivers/cpuidle/Kconfig"
>>
>> -source "kernel/power/Kconfig"
>> -
>>  source "drivers/cpufreq/Kconfig"
>>
>>  endmenu
>>
>> If it makes sense, I will send out a patch for it.
> 
> We actually need to menu options here,
> menu "Power management options"
> menu "CPU Power Management"
> 
> And so probably you just need to do this:
>> -source "kernel/power/Kconfig"
>> -
> 
> from CPU Power Management options..

Ok, will send out a patch later.

Thanks
Hanjun

WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
	Mark Brown <broonie@linaro.org>,
	Will Deacon <Will.Deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sudeep Holla <Sudeep.Holla@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Josh Boyer <jwboyer@fedoraproject.org>
Subject: Re: [PATCH] arm64: Fix duplicated Kconfig entries again
Date: Thu, 03 Apr 2014 19:01:46 +0800	[thread overview]
Message-ID: <533D3F9A.5070001@linaro.org> (raw)
In-Reply-To: <CAKohpok5KCmR4UYG1ZkGL2TcXqqO7dPJnwGg49ahU-ceL1+wxA@mail.gmail.com>

On 2014-4-3 17:38, Viresh Kumar wrote:
> On 3 April 2014 14:57, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> Great, thanks Viresh to let me know this.
>> Actually I also sent a patch named "arm64: Fix duplicated Kconfig entries
>> again" about one week ago :)
>>
>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg612363.html
>>
>> And I think there is still a problem after commit 62d1a3ba - multi-entries
>> for source "kernel/power/Kconfig", so how about the following fix?
> 
> I didn't notice that :)
> 
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index e6e4d37..6085dca 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -317,14 +317,8 @@ config ARCH_SUSPEND_POSSIBLE
>>  config ARM64_CPU_SUSPEND
>>         def_bool PM_SLEEP
>>
>> -endmenu
>> -
>> -menu "CPU Power Management"
>> -
>>  source "drivers/cpuidle/Kconfig"
>>
>> -source "kernel/power/Kconfig"
>> -
>>  source "drivers/cpufreq/Kconfig"
>>
>>  endmenu
>>
>> If it makes sense, I will send out a patch for it.
> 
> We actually need to menu options here,
> menu "Power management options"
> menu "CPU Power Management"
> 
> And so probably you just need to do this:
>> -source "kernel/power/Kconfig"
>> -
> 
> from CPU Power Management options..

Ok, will send out a patch later.

Thanks
Hanjun


  reply	other threads:[~2014-04-03 11:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  9:00 [PATCH] arm64: Fix duplicated Kconfig entries again Hanjun Guo
2014-03-25  9:00 ` Hanjun Guo
2014-03-25 10:00 ` [Linaro-acpi] " Sudeep Holla
2014-03-25 10:00   ` Sudeep Holla
2014-03-25 11:09   ` Hanjun Guo
2014-03-25 11:09     ` Hanjun Guo
2014-03-27 11:12     ` Sudeep Holla
2014-03-27 11:12       ` Sudeep Holla
2014-03-27 12:34       ` Hanjun Guo
2014-03-27 12:34         ` Hanjun Guo
2014-03-27 15:18         ` Rafael J. Wysocki
2014-03-27 15:18           ` Rafael J. Wysocki
2014-04-03  8:35           ` Hanjun Guo
2014-04-03  8:35             ` Hanjun Guo
2014-04-03  8:41             ` Viresh Kumar
2014-04-03  8:41               ` Viresh Kumar
2014-04-03  8:51               ` Catalin Marinas
2014-04-03  8:51                 ` Catalin Marinas
2014-04-03  9:27                 ` Hanjun Guo
2014-04-03  9:27                   ` Hanjun Guo
2014-04-03  9:30                   ` Hanjun Guo
2014-04-03  9:30                     ` Hanjun Guo
2014-04-03  9:38                   ` Viresh Kumar
2014-04-03  9:38                     ` Viresh Kumar
2014-04-03 11:01                     ` Hanjun Guo [this message]
2014-04-03 11:01                       ` Hanjun Guo
  -- strict thread matches above, loose matches on Subject: below --
2014-04-02  1:25 arm64/cqufreq Kconfig error with v3.14-3893-gc12e69c6aaf7 Josh Boyer
2014-04-02  5:06 ` Viresh Kumar
2014-04-02 14:40   ` [PATCH] arm64: Fix duplicated Kconfig entries again Josh Boyer
2014-04-02 14:40     ` Josh Boyer
2014-04-03  4:23     ` Viresh Kumar
2014-04-03  4:23       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533D3F9A.5070001@linaro.org \
    --to=hanjun.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.