From: Daniel Borkmann <dborkman@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, Thomas Graf <tgraf@suug.ch>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket
Date: Tue, 08 Apr 2014 16:23:50 +0000 [thread overview]
Message-ID: <53442296.6000908@redhat.com> (raw)
In-Reply-To: <53441531.8030009@gmail.com>
On 04/08/2014 05:26 PM, Vlad Yasevich wrote:
...
> This is yet another list traversal with skip_head. I am going to
> resurrect that code for net-next.
Sounds good! I actually had a look longer time ago, to squeeze
all that logic into a list macro, but so far I didn't find
something clean without appending an if-clause to it that tests
for head element - and that I don't like as it can happen that
unintentionally users could run into a dangling else. In the
end it all looked more complicated than the current code was,
so I wasn't really satisfied and therefore didn't post a
patch. ;)
Cheers,
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, Thomas Graf <tgraf@suug.ch>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket
Date: Tue, 08 Apr 2014 18:23:50 +0200 [thread overview]
Message-ID: <53442296.6000908@redhat.com> (raw)
In-Reply-To: <53441531.8030009@gmail.com>
On 04/08/2014 05:26 PM, Vlad Yasevich wrote:
...
> This is yet another list traversal with skip_head. I am going to
> resurrect that code for net-next.
Sounds good! I actually had a look longer time ago, to squeeze
all that logic into a list macro, but so far I didn't find
something clean without appending an if-clause to it that tests
for head element - and that I don't like as it can happen that
unintentionally users could run into a dangling else. In the
end it all looked more complicated than the current code was,
so I wasn't really satisfied and therefore didn't post a
patch. ;)
Cheers,
Daniel
next prev parent reply other threads:[~2014-04-08 16:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:33 [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket Daniel Borkmann
2014-04-08 13:33 ` Daniel Borkmann
2014-04-08 14:41 ` Vlad Yasevich
2014-04-08 14:41 ` Vlad Yasevich
2014-04-08 14:52 ` Daniel Borkmann
2014-04-08 14:52 ` Daniel Borkmann
2014-04-08 15:26 ` Vlad Yasevich
2014-04-08 15:26 ` Vlad Yasevich
2014-04-08 16:23 ` Daniel Borkmann [this message]
2014-04-08 16:23 ` Daniel Borkmann
2014-04-08 16:50 ` David Miller
2014-04-08 16:50 ` David Miller
2014-04-08 17:13 ` Vlad Yasevich
2014-04-08 17:13 ` Vlad Yasevich
2014-04-08 17:19 ` David Miller
2014-04-08 17:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53442296.6000908@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tgraf@suug.ch \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.