From: Vlad Yasevich <vyasevich@gmail.com>
To: David Miller <davem@davemloft.net>, dborkman@redhat.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
tgraf@suug.ch, nhorman@tuxdriver.com
Subject: Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket
Date: Tue, 08 Apr 2014 17:13:46 +0000 [thread overview]
Message-ID: <53442E4A.2090004@gmail.com> (raw)
In-Reply-To: <20140408.125032.810691136561418545.davem@davemloft.net>
On 04/08/2014 12:50 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Tue, 8 Apr 2014 15:33:57 +0200
>
>> [ When net-next opens up again, we need to think how
>> we can ideally make a new list interface and simplify
>> both open-coded list traversals. ]
>
> I don't think you need a new list interface.
>
> Instead, just have a back pointer to the sctp_sk() from the asoc, then
> you can do normal list traversals over the asocs.
We already have that, but doing so will give preference to first
association and possibly starving the last one.
This starvation avoidance is the whole point of having a per-association
accounting.
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevich@gmail.com>
To: David Miller <davem@davemloft.net>, dborkman@redhat.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
tgraf@suug.ch, nhorman@tuxdriver.com
Subject: Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket
Date: Tue, 08 Apr 2014 13:13:46 -0400 [thread overview]
Message-ID: <53442E4A.2090004@gmail.com> (raw)
In-Reply-To: <20140408.125032.810691136561418545.davem@davemloft.net>
On 04/08/2014 12:50 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Tue, 8 Apr 2014 15:33:57 +0200
>
>> [ When net-next opens up again, we need to think how
>> we can ideally make a new list interface and simplify
>> both open-coded list traversals. ]
>
> I don't think you need a new list interface.
>
> Instead, just have a back pointer to the sctp_sk() from the asoc, then
> you can do normal list traversals over the asocs.
We already have that, but doing so will give preference to first
association and possibly starving the last one.
This starvation avoidance is the whole point of having a per-association
accounting.
-vlad
next prev parent reply other threads:[~2014-04-08 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:33 [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket Daniel Borkmann
2014-04-08 13:33 ` Daniel Borkmann
2014-04-08 14:41 ` Vlad Yasevich
2014-04-08 14:41 ` Vlad Yasevich
2014-04-08 14:52 ` Daniel Borkmann
2014-04-08 14:52 ` Daniel Borkmann
2014-04-08 15:26 ` Vlad Yasevich
2014-04-08 15:26 ` Vlad Yasevich
2014-04-08 16:23 ` Daniel Borkmann
2014-04-08 16:23 ` Daniel Borkmann
2014-04-08 16:50 ` David Miller
2014-04-08 16:50 ` David Miller
2014-04-08 17:13 ` Vlad Yasevich [this message]
2014-04-08 17:13 ` Vlad Yasevich
2014-04-08 17:19 ` David Miller
2014-04-08 17:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53442E4A.2090004@gmail.com \
--to=vyasevich@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.