From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Antonio Quartulli <antonio@meshcoding.com>
Cc: devel@lists.open80211s.org, Felix Fietkau <nbd@openwrt.org>,
b.a.t.m.a.n@lists.open-mesh.org, linux-wireless@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] [RFCv2 4/6] mac80211: minstrel - implement get_expected_throughput() API
Date: Thu, 10 Apr 2014 17:54:15 +0200 [thread overview]
Message-ID: <5346BEA7.9080006@open-mesh.com> (raw)
In-Reply-To: <1396951502.5936.18.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On 08/04/14 12:05, Johannes Berg wrote:
> On Sun, 2014-03-30 at 22:35 +0200, Antonio Quartulli wrote:
>
>> +static u32
>> +minstrel_get_expected_throughput(void *priv, void *priv_sta,
>> + struct ieee80211_supported_band *sband)
>> +{
>> + struct minstrel_sta_info *mi = priv_sta;
>> + int idx = mi->max_tp_rate[0];
>> + u32 bitrate, ret;
>> +
>> + bitrate = sband->bitrates[mi->r[idx].rix].bitrate;
>> + ret = bitrate * MINSTREL_TRUNC(mi->r[idx].probability * 1000) / 1000;
>> +
>> + return ret;
>
> You don't need a ret variable.
True.
thanks!
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Antonio Quartulli <antonio@meshcoding.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org, linux-wireless@vger.kernel.org,
devel@lists.open80211s.org, Felix Fietkau <nbd@openwrt.org>
Subject: Re: [RFCv2 4/6] mac80211: minstrel - implement get_expected_throughput() API
Date: Thu, 10 Apr 2014 17:54:15 +0200 [thread overview]
Message-ID: <5346BEA7.9080006@open-mesh.com> (raw)
In-Reply-To: <1396951502.5936.18.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On 08/04/14 12:05, Johannes Berg wrote:
> On Sun, 2014-03-30 at 22:35 +0200, Antonio Quartulli wrote:
>
>> +static u32
>> +minstrel_get_expected_throughput(void *priv, void *priv_sta,
>> + struct ieee80211_supported_band *sband)
>> +{
>> + struct minstrel_sta_info *mi = priv_sta;
>> + int idx = mi->max_tp_rate[0];
>> + u32 bitrate, ret;
>> +
>> + bitrate = sband->bitrates[mi->r[idx].rix].bitrate;
>> + ret = bitrate * MINSTREL_TRUNC(mi->r[idx].probability * 1000) / 1000;
>> +
>> + return ret;
>
> You don't need a ret variable.
True.
thanks!
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-04-10 15:54 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 20:34 [B.A.T.M.A.N.] [RFCv2 0/6] Export the expected throughput Antonio Quartulli
2014-03-30 20:34 ` Antonio Quartulli
2014-03-30 20:34 ` [B.A.T.M.A.N.] [RFCv2 1/6] cfg80211: export expected throughput through get_station() Antonio Quartulli
2014-03-30 20:34 ` Antonio Quartulli
2014-03-31 8:22 ` [B.A.T.M.A.N.] " Andrew Lunn
2014-03-31 8:22 ` Andrew Lunn
2014-03-31 8:46 ` Antonio Quartulli
2014-03-31 8:46 ` Antonio Quartulli
2014-04-08 10:03 ` Johannes Berg
2014-04-08 10:03 ` Johannes Berg
2014-04-10 16:22 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-10 16:22 ` Antonio Quartulli
2014-03-30 20:35 ` [B.A.T.M.A.N.] [RFCv2 2/6] mac80211: add new RC API to retrieve expected throughput Antonio Quartulli
2014-03-30 20:35 ` Antonio Quartulli
2014-04-08 10:03 ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-08 10:03 ` Johannes Berg
2014-04-10 15:46 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-10 15:46 ` Antonio Quartulli
2014-04-10 17:13 ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-10 17:13 ` Johannes Berg
2014-04-11 7:03 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-11 7:03 ` Antonio Quartulli
2014-04-08 10:04 ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-08 10:04 ` Johannes Berg
2014-04-10 15:53 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-10 15:53 ` Antonio Quartulli
2014-04-10 17:14 ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-10 17:14 ` Johannes Berg
2014-04-11 11:30 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-11 11:30 ` Antonio Quartulli
2014-03-30 20:35 ` [B.A.T.M.A.N.] [RFCv2 3/6] mac80211: export expected throughput in set_sta_info() Antonio Quartulli
2014-03-30 20:35 ` Antonio Quartulli
2014-03-30 20:35 ` [B.A.T.M.A.N.] [RFCv2 4/6] mac80211: minstrel - implement get_expected_throughput() API Antonio Quartulli
2014-03-30 20:35 ` Antonio Quartulli
2014-03-31 8:49 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-31 8:49 ` Antonio Quartulli
2014-04-08 10:05 ` Johannes Berg
2014-04-08 10:05 ` Johannes Berg
2014-04-10 15:54 ` Antonio Quartulli [this message]
2014-04-10 15:54 ` Antonio Quartulli
2014-03-30 20:35 ` [B.A.T.M.A.N.] [RFCv2 5/6] mac80211: minstrel_ht " Antonio Quartulli
2014-03-30 20:35 ` Antonio Quartulli
2014-03-30 20:35 ` [B.A.T.M.A.N.] [RFCv2 6/6] cfg80211: implement cfg80211_get_station cfg80211 API Antonio Quartulli
2014-03-30 20:35 ` Antonio Quartulli
2014-04-08 10:06 ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-08 10:06 ` Johannes Berg
2014-04-10 16:02 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-10 16:02 ` Antonio Quartulli
2014-04-10 17:12 ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-10 17:12 ` Johannes Berg
2014-04-11 7:04 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-04-11 7:04 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5346BEA7.9080006@open-mesh.com \
--to=antonio@open-mesh.com \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.