From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: jaegeuk.kim@samsung.com
Cc: fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
f2fs <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge
Date: Mon, 14 Apr 2014 09:48:15 +0800 [thread overview]
Message-ID: <534B3E5F.3090609@cn.fujitsu.com> (raw)
In-Reply-To: <1397439855.24638.24.camel@kjgkr>
On 04/14/2014 09:44 AM, Jaegeuk Kim wrote:
> Hi Gu,
>
> I just started to review the patches and merge them individually though.
> Since I've been internally doing in my local tree, so that should be no
> problem. I'll roll back to the latest point.
OK, and please pay some attention to the flush cmds merging operation when doing
tests, it seems that some of the outstanding flush cmds(in the issue_list) will
be ignored when new cmd added.
I'll review and test it more.
> Anyway, thank you for your work. :)
Regards,
Gu
>
> 2014-04-14 (월), 09:18 +0800, Gu Zheng:
>> Hi All,
>> There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list",
>> and the whole patchset needs to be reworked. So please ignore this one.
>> Sorry for the noise.
>>
>> Regards,
>> Gu
>> On 04/11/2014 05:49 PM, Gu Zheng wrote:
>>
>>> Gu Zheng (7):
>>> f2fs: put the bio when issue_flush completed
>>> f2fs: remove the unuseful "issue_tail" list
>>> f2fs: use __GFP_ZERO to avoid appending set-NULL
>>> f2fs: enable flush_merge only in f2fs is not read-only
>>> f2fs: add the flush_merge handle in the remount flow
>>> f2fs: introduce struct flush_cmd_control to wrap the flush_merge
>>> fields
>>> f2fs: introduce help function {create,destroy}_flush_cmd_control
>>>
>>> fs/f2fs/f2fs.h | 17 ++++++---
>>> fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
>>> fs/f2fs/super.c | 32 ++++++++++++++--
>>> 3 files changed, 107 insertions(+), 44 deletions(-)
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: <jaegeuk.kim@samsung.com>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
f2fs <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge
Date: Mon, 14 Apr 2014 09:48:15 +0800 [thread overview]
Message-ID: <534B3E5F.3090609@cn.fujitsu.com> (raw)
In-Reply-To: <1397439855.24638.24.camel@kjgkr>
On 04/14/2014 09:44 AM, Jaegeuk Kim wrote:
> Hi Gu,
>
> I just started to review the patches and merge them individually though.
> Since I've been internally doing in my local tree, so that should be no
> problem. I'll roll back to the latest point.
OK, and please pay some attention to the flush cmds merging operation when doing
tests, it seems that some of the outstanding flush cmds(in the issue_list) will
be ignored when new cmd added.
I'll review and test it more.
> Anyway, thank you for your work. :)
Regards,
Gu
>
> 2014-04-14 (월), 09:18 +0800, Gu Zheng:
>> Hi All,
>> There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list",
>> and the whole patchset needs to be reworked. So please ignore this one.
>> Sorry for the noise.
>>
>> Regards,
>> Gu
>> On 04/11/2014 05:49 PM, Gu Zheng wrote:
>>
>>> Gu Zheng (7):
>>> f2fs: put the bio when issue_flush completed
>>> f2fs: remove the unuseful "issue_tail" list
>>> f2fs: use __GFP_ZERO to avoid appending set-NULL
>>> f2fs: enable flush_merge only in f2fs is not read-only
>>> f2fs: add the flush_merge handle in the remount flow
>>> f2fs: introduce struct flush_cmd_control to wrap the flush_merge
>>> fields
>>> f2fs: introduce help function {create,destroy}_flush_cmd_control
>>>
>>> fs/f2fs/f2fs.h | 17 ++++++---
>>> fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
>>> fs/f2fs/super.c | 32 ++++++++++++++--
>>> 3 files changed, 107 insertions(+), 44 deletions(-)
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: <jaegeuk.kim@samsung.com>
Cc: f2fs <linux-f2fs-devel@lists.sourceforge.net>,
fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge
Date: Mon, 14 Apr 2014 09:48:15 +0800 [thread overview]
Message-ID: <534B3E5F.3090609@cn.fujitsu.com> (raw)
In-Reply-To: <1397439855.24638.24.camel@kjgkr>
On 04/14/2014 09:44 AM, Jaegeuk Kim wrote:
> Hi Gu,
>
> I just started to review the patches and merge them individually though.
> Since I've been internally doing in my local tree, so that should be no
> problem. I'll roll back to the latest point.
OK, and please pay some attention to the flush cmds merging operation when doing
tests, it seems that some of the outstanding flush cmds(in the issue_list) will
be ignored when new cmd added.
I'll review and test it more.
> Anyway, thank you for your work. :)
Regards,
Gu
>
> 2014-04-14 (월), 09:18 +0800, Gu Zheng:
>> Hi All,
>> There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list",
>> and the whole patchset needs to be reworked. So please ignore this one.
>> Sorry for the noise.
>>
>> Regards,
>> Gu
>> On 04/11/2014 05:49 PM, Gu Zheng wrote:
>>
>>> Gu Zheng (7):
>>> f2fs: put the bio when issue_flush completed
>>> f2fs: remove the unuseful "issue_tail" list
>>> f2fs: use __GFP_ZERO to avoid appending set-NULL
>>> f2fs: enable flush_merge only in f2fs is not read-only
>>> f2fs: add the flush_merge handle in the remount flow
>>> f2fs: introduce struct flush_cmd_control to wrap the flush_merge
>>> fields
>>> f2fs: introduce help function {create,destroy}_flush_cmd_control
>>>
>>> fs/f2fs/f2fs.h | 17 ++++++---
>>> fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
>>> fs/f2fs/super.c | 32 ++++++++++++++--
>>> 3 files changed, 107 insertions(+), 44 deletions(-)
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-04-14 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 9:49 [PATCH 0/7] f2fs: some fix and cleanup about flush_merge Gu Zheng
2014-04-11 9:49 ` Gu Zheng
2014-04-14 1:18 ` Gu Zheng
2014-04-14 1:18 ` Gu Zheng
2014-04-14 1:44 ` Jaegeuk Kim
2014-04-14 1:44 ` Jaegeuk Kim
2014-04-14 1:48 ` Gu Zheng [this message]
2014-04-14 1:48 ` Gu Zheng
2014-04-14 1:48 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534B3E5F.3090609@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.