From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Tue, 15 Apr 2014 07:01:44 +0000 [thread overview]
Message-ID: <534CD958.4000303@ti.com> (raw)
In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com>
On 04/15/2014 12:59 AM, Alexandre Belloni wrote:
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
Why do you need to do this in two steps?
In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it back.
Would not be simpler if you just add the two new parameters in patch 4 (the
812500, PWM_POLARITY_NORMAL)?
> };
>
> static struct led_pwm pwm_leds[] = {
>
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Jingoo Han <jg1.han@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-sh@vger.kernel.org, linux-leds@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Tue, 15 Apr 2014 10:01:44 +0300 [thread overview]
Message-ID: <534CD958.4000303@ti.com> (raw)
In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com>
On 04/15/2014 12:59 AM, Alexandre Belloni wrote:
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
Why do you need to do this in two steps?
In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it back.
Would not be simpler if you just add the two new parameters in patch 4 (the
812500, PWM_POLARITY_NORMAL)?
> };
>
> static struct led_pwm pwm_leds[] = {
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Tue, 15 Apr 2014 10:01:44 +0300 [thread overview]
Message-ID: <534CD958.4000303@ti.com> (raw)
In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com>
On 04/15/2014 12:59 AM, Alexandre Belloni wrote:
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
Why do you need to do this in two steps?
In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it back.
Would not be simpler if you just add the two new parameters in patch 4 (the
812500, PWM_POLARITY_NORMAL)?
> };
>
> static struct led_pwm pwm_leds[] = {
>
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Jingoo Han <jg1.han@samsung.com>,
Lee Jones <lee.jones@linaro.org>, <linux-pwm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux-sh@vger.kernel.org>,
<linux-leds@vger.kernel.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Tue, 15 Apr 2014 10:01:44 +0300 [thread overview]
Message-ID: <534CD958.4000303@ti.com> (raw)
In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com>
On 04/15/2014 12:59 AM, Alexandre Belloni wrote:
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
Why do you need to do this in two steps?
In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it back.
Would not be simpler if you just add the two new parameters in patch 4 (the
812500, PWM_POLARITY_NORMAL)?
> };
>
> static struct led_pwm pwm_leds[] = {
>
--
Péter
next prev parent reply other threads:[~2014-04-15 7:01 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 21:59 [PATCHv2 00/11] improve PWM lookup support without device tree Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 01/11] pwm: add period and polarity to struct pwm_lookup Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 02/11] ARM: shmobile: Armadillo 800 EVA: initialize all struct pwm_lookup members Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 22:58 ` Simon Horman
2014-04-14 22:58 ` Simon Horman
2014-04-14 22:58 ` Simon Horman
2014-04-14 21:59 ` [PATCHv2 03/11] pwm: renesas-tpu: remove useless struct tpu_pwm_platform_data Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 04/11] ARM: OMAP3: Beagle: initialize all the struct pwm_lookup members Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 05/11] ARM: pxa: hx4700: " Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 06/11] pwm: modify PWM_LOOKUP to initialize all " Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-15 7:01 ` Peter Ujfalusi [this message]
2014-04-15 7:01 ` Peter Ujfalusi
2014-04-15 7:01 ` Peter Ujfalusi
2014-04-15 7:01 ` Peter Ujfalusi
2014-04-15 7:14 ` Simon Horman
2014-04-15 7:14 ` Simon Horman
2014-04-15 7:14 ` Simon Horman
2014-04-15 7:42 ` Peter Ujfalusi
2014-04-15 7:42 ` Peter Ujfalusi
2014-04-15 7:42 ` Peter Ujfalusi
2014-04-15 7:42 ` Peter Ujfalusi
2014-04-14 21:59 ` [PATCHv2 08/11] ARM: shmobile: Armadillo 800 EVA: " Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 09/11] ARM: pxa: hx4700: " Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 10/11] leds: leds-pwm: retrieve configured pwm period Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` [PATCHv2 11/11] backlight: pwm_bl: " Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-04-14 21:59 ` Alexandre Belloni
2014-05-12 15:04 ` [PATCHv2 00/11] improve PWM lookup support without device tree Alexandre Belloni
2014-05-12 15:04 ` Alexandre Belloni
2014-05-12 15:04 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534CD958.4000303@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.