* Re: [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma.
[not found] <1397655787-27780-1-git-send-email-iryzhov@arccn.ru>
@ 2014-04-16 17:32 ` Stefan Weil
2014-04-16 17:58 ` Peter Maydell
2014-04-27 9:10 ` [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2014-04-16 17:32 UTC (permalink / raw)
To: Igor Ryzhov, qemu-devel; +Cc: qemu-trivial, stefanha
Am 16.04.2014 15:43, schrieb Igor Ryzhov:
> Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru>
> ---
> net/net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index e3ef1e4..60a07f1 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender,
>
> if (ret == 0) {
> nc->receive_disabled = 1;
> - };
> + }
>
> return ret;
> }
>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
CC'ing qemu-trivial
PS. The "." at the end of your subject line is unnecessary, too. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma.
2014-04-16 17:32 ` [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma Stefan Weil
@ 2014-04-16 17:58 ` Peter Maydell
2014-04-16 21:19 ` Igor Ryzhov
2014-04-27 9:10 ` [Qemu-trivial] " Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2014-04-16 17:58 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Igor Ryzhov, Stefan Hajnoczi, QEMU Developers
On 16 April 2014 18:32, Stefan Weil <sw@weilnetz.de> wrote:
> Am 16.04.2014 15:43, schrieb Igor Ryzhov:
>> Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru>
>> ---
>> net/net.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/net.c b/net/net.c
>> index e3ef1e4..60a07f1 100644
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender,
>>
>> if (ret == 0) {
>> nc->receive_disabled = 1;
>> - };
>> + }
>>
>> return ret;
>> }
>>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> CC'ing qemu-trivial
>
> PS. The "." at the end of your subject line is unnecessary, too. :-)
"net/net.c: Remove unnecessary semicolon" would probably
be better (since it lets people know which area the patch is affecting
and also gets the name of the punctuation mark right ;-)).
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma.
2014-04-16 17:58 ` Peter Maydell
@ 2014-04-16 21:19 ` Igor Ryzhov
0 siblings, 0 replies; 4+ messages in thread
From: Igor Ryzhov @ 2014-04-16 21:19 UTC (permalink / raw)
To: Peter Maydell, Stefan Weil; +Cc: qemu-trivial, QEMU Developers, Stefan Hajnoczi
Oh, my mistake.
It's really semicolon, not comma :)
Should I resend the patch with correct name?
16.04.2014 21:58, Peter Maydell пишет:
> On 16 April 2014 18:32, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 16.04.2014 15:43, schrieb Igor Ryzhov:
>>> Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru>
>>> ---
>>> net/net.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/net.c b/net/net.c
>>> index e3ef1e4..60a07f1 100644
>>> --- a/net/net.c
>>> +++ b/net/net.c
>>> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender,
>>>
>>> if (ret == 0) {
>>> nc->receive_disabled = 1;
>>> - };
>>> + }
>>>
>>> return ret;
>>> }
>>>
>> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>>
>> CC'ing qemu-trivial
>>
>> PS. The "." at the end of your subject line is unnecessary, too. :-)
> "net/net.c: Remove unnecessary semicolon" would probably
> be better (since it lets people know which area the patch is affecting
> and also gets the name of the punctuation mark right ;-)).
>
> thanks
> -- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH] Unnecessary comma.
2014-04-16 17:32 ` [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma Stefan Weil
2014-04-16 17:58 ` Peter Maydell
@ 2014-04-27 9:10 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-04-27 9:10 UTC (permalink / raw)
To: Stefan Weil, Igor Ryzhov, qemu-devel; +Cc: qemu-trivial, stefanha
Thanks, applied to the trivial queue, with subject tweak.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-27 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1397655787-27780-1-git-send-email-iryzhov@arccn.ru>
2014-04-16 17:32 ` [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma Stefan Weil
2014-04-16 17:58 ` Peter Maydell
2014-04-16 21:19 ` Igor Ryzhov
2014-04-27 9:10 ` [Qemu-trivial] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.