Re: [PATCH] mbpi: Parse gsm provider name

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

Hi Slava,

On 04/16/2014 09:00 AM, Slava Monich wrote:
> This gives the provisioning plugin more information to work with and
> improves the chance of automatically picking the right AP in case if
> we have more than one for the same mcc/mnc combination.
> ---
>  include/gprs-provision.h |  1 +
>  plugins/mbpi.c           | 47 +++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 44 insertions(+), 4 deletions(-)
> 

I fail to see the point for this patch.  It makes no sense on its own.

> diff --git a/include/gprs-provision.h b/include/gprs-provision.h
> index e9eec61..0129cd0 100644
> --- a/include/gprs-provision.h
> +++ b/include/gprs-provision.h
> @@ -31,6 +31,7 @@ extern "C" {
>  struct ofono_gprs_provision_data {
>  	enum ofono_gprs_context_type type;
>  	enum ofono_gprs_proto proto;
> +	char *provider_name;

I fail to see why this would be required here?  It is not utilized
anywhere else...

Regards,
-Denis