All of lore.kernel.org
 help / color / mirror / Atom feed
From: Slava Monich <slava.monich@jolla.com>
To: ofono@ofono.org
Subject: Re: [PATCH] mbpi: Parse gsm provider name
Date: Fri, 18 Apr 2014 02:22:06 +0300	[thread overview]
Message-ID: <5350621E.4010508@jolla.com> (raw)
In-Reply-To: <535051B4.6040301@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Hi Denis,
>> If instead I changed the interface between mbpi and provisioning plugin
>> and kept the interface with the core intact, would that look acceptable
>> to you?
> Perhaps, but I'm still failing to see why the service provider name as
> entered in MBPI is useful to anyone.

Operators share mcc/mnc meaning that automatically finding the best AP 
(the one most likely to work) from the database may involve some sort of 
fuzzy logic (partial or case-insensitive name comparison or something 
like this) implemented in a product-specific provisioning plugin. Making 
things work out-the-box translates into fewer customer complaints, 
better user experience and is generally the right thing to do.

I was trying to share a piece of code that doesn't involve any 
product-specific logic and yet might be useful to others.

Please let me know if I should give it another try, otherwise I won't 
waste anyone's time and this code will just remain in our branch of ofono.

Thanks,
-Slava


  reply	other threads:[~2014-04-17 23:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 14:00 [PATCH] mbpi: Parse gsm provider name Slava Monich
2014-04-17  4:07 ` Denis Kenzior
2014-04-17  8:24   ` Slava Monich
2014-04-17 15:40     ` Denis Kenzior
2014-04-17 18:29       ` Slava Monich
2014-04-17 22:12         ` Denis Kenzior
2014-04-17 23:22           ` Slava Monich [this message]
2014-04-18  0:58             ` Denis Kenzior
2014-04-18 12:02               ` Slava Monich
2014-04-18 14:56                 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5350621E.4010508@jolla.com \
    --to=slava.monich@jolla.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.