Re: [PATCH] mbpi: Parse gsm provider name

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Hi Slava,

> I agree that there is no need to for it to be returned by the
> provisioning plugin to the core but it's the same structure used by
> mbpi.c to return the result of parsing serviceproviders.xml to the
> provisioning plugin. Side effect of sharing the structure between two
> interfaces.

'Side-effects' that affect the core are never acceptable.  Just a
friendly hint that any changes to the core automatically trigger
scrutiny beyond our already thorough review process.

> If instead I changed the interface between mbpi and provisioning plugin
> and kept the interface with the core intact, would that look acceptable
> to you?

Perhaps, but I'm still failing to see why the service provider name as
entered in MBPI is useful to anyone.

Regards,
-Denis