Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] vl: Avoid to close stdout after finish 'writeconfig' option

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 04/21/2014 11:09 PM, Eric Blake wrote:
> On 04/20/2014 06:05 AM, Chen Gang wrote:
>> After finish 'writeconfig' to stdout (with '-'), we want to copy/past
>> the related information mannually, not for redirection ('readconfig'
>> does not support '-').
>>
>> So we can not close the stdout, or next options which may use stdout
>> will not be displayed.
> 
> Grammar, and awkward to read.  May I suggest:
> 
> vl: avoid closing stdout with 'writeconfig'
> 
> 'writeconfig' supports output to stdout (with '-'); when that happens,
> we must not close stdout, or further command line options that also use
> stdout will be impacted.  (Although 'writeconfig' was copied from
> 'readconfig', the latter does not have the problem because it does not
> support reading from '-')
> 
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  vl.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> With the improved commit message,
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> 

OK, it sounds fine to me, I shall send patch v2 for it.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed