Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] vl: Avoid to close stdout after finish 'writeconfig' option

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

On 04/22/2014 10:06 AM, Andreas Färber wrote:

>> Grammar, and awkward to read.  May I suggest:
> 
>> vl: avoid closing stdout with 'writeconfig'
> 

> Eric, did you intentionally request to change "Avoid" to lowercase?

Yes, out of habit, and in comparison to many recent commits.  In fact,
looking at the current qemu.git head 'git shortlog -100 2d03b49c' shows:

3 commits matching '\.$', 97 without
75 commits matching ': [A-Z]', 24 matching ': [a-z]' (some overlap here,
and merge commits don't match either)

extending further to 1000 commits:

21 commits with trailing dot, 979 without
644 matching ': [A-Z]', 260 matching ': [a-z]'

at 10000, things are a bit more even:
5187 matching ': [A-Z]', 3904 matching ': [a-z]'

but still a distinct leaning towards capital at the start of the message

> I was once pointed to https://wiki.gnome.org/Git/CommitMessages as a
> template, and starting an English-language heading with an uppercase
> letter seems natural, with anything else being too lazy to press Shift.

Hmm, maybe we should update the qemu wiki?
http://wiki.qemu.org/Contribute/SubmitAPatch doesn't mention the qemu
preferred style (you pointed to the GNOME style, but at least GNU
coreutils explicitly prefers lowercase).

At any rate, I'm not going to reject a patch based on capitalization,
and can retrain my fingers to use a capital if that is the documented
preference.

> Personally I find -writeconfig the most straightforward way to
> indicate it's an option, just like () makes clear something is a
> function. The original subject had an explicit "option", that got lost
> for v2.

Good call, so maybe:

 vl: Avoid closing stdout with '-writeconfig'

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]