Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] vl: Avoid to close stdout after finish 'writeconfig' option

["Andreas Färber" <afaerber@suse.de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 21.04.2014 17:09, schrieb Eric Blake:
> On 04/20/2014 06:05 AM, Chen Gang wrote:
>> After finish 'writeconfig' to stdout (with '-'), we want to
>> copy/past the related information mannually, not for redirection
>> ('readconfig' does not support '-').
>> 
>> So we can not close the stdout, or next options which may use
>> stdout will not be displayed.
> 
> Grammar, and awkward to read.  May I suggest:
> 
> vl: avoid closing stdout with 'writeconfig'
> 
> 'writeconfig' supports output to stdout (with '-'); when that
> happens, we must not close stdout, or further command line options
> that also use stdout will be impacted.  (Although 'writeconfig' was
> copied from 'readconfig', the latter does not have the problem
> because it does not support reading from '-')

Eric, did you intentionally request to change "Avoid" to lowercase?
I was once pointed to https://wiki.gnome.org/Git/CommitMessages as a
template, and starting an English-language heading with an uppercase
letter seems natural, with anything else being too lazy to press Shift.

Personally I find -writeconfig the most straightforward way to
indicate it's an option, just like () makes clear something is a
function. The original subject had an explicit "option", that got lost
for v2.

Regards,
Andreas

- -- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTVpNxAAoJEPou0S0+fgE/NBEP/RbA40p75QIWuDBM31PXXZNo
lrIxfLkb9QVvN7ALUsGOEn6Y1bNQWuItfq5YBN0oDDBxWKSHaU2ou8M3TUWIX6S8
ENLPFJzsVGbzsb4pkP0yMMWZdbs+8AChDJ+oZxgtz6eBf90ERYLarL/t8UjnZos4
wKU3alo2j9xf2OfMpqEHvtxcFc9URDZWKjElPLkZDPn5rFEwcaVGu78rDtjNQIU4
z7Ebc7li29Yppz9MrQ6QoXtU5ZGygPlzZ90G5UZc4v0H0u4ObyYInrWbxqryVp2H
k+X173VVpJtPzlhzDkBJPdnwqhoExq7x/n2ujZicRyL95+8ZeoH2kteMRP0eHZYV
TDLOkIq2FXklccn91FVVCk6GfLKLdcgZMotaxYD1EIxp7I9NlzpB0d1EVCgClWMx
AgZ6StOhYt4+72BaLDOT602FHdsVSEnCqsQeBxoDhKWLwKLklKi59vzDGn+wH0Ap
fY33zIW4+YAiXDv3vQg+1k8iG7BauO3cHDVQfbRMzU5zgWORMsm1lsnEv0b3x9YH
PhuG9Ve9J2zrbBQEBe0zx98CyB0tp8L/8w5TUVD3EEmQA9YZP5y7I8WU8mOnvgRa
Rpu3JF6U3KBO99VF0Yyd3K1mTcG4yJzGfxdLdiTIkSDbEV/jc5aoJFltldZWWpsl
DigKmE0VxCFolXJsIsiX
=810z
-----END PGP SIGNATURE-----