[PATCH] drm/radeon/aux: fix hpd assignment for aux bus

[PATCH] drm/radeon/aux: fix hpd assignment for aux bus

[Alex Deucher]

The hpd (hot plug detect) pin assignment got lost
in the conversion to to the common i2c over aux
code.  Without this information, aux transactions
do not work properly.  Fixes DP failures.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/radeon/atombios_dp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
index 1593652..bc0119f 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -209,6 +209,7 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
 {
 	int ret;
 
+	radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd;
 	radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
 	radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer;
 	ret = drm_dp_aux_register_i2c_bus(&radeon_connector->ddc_bus->aux);
-- 
1.7.11.7

Re: [PATCH] drm/radeon/aux: fix hpd assignment for aux bus

[Christian König]

Am 22.04.2014 08:02, schrieb Alex Deucher:
> The hpd (hot plug detect) pin assignment got lost
> in the conversion to to the common i2c over aux
> code.  Without this information, aux transactions
> do not work properly.  Fixes DP failures.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Added to my 3.15 queue.

Does this also fix the issue Ed Tomlinson <edt@aei.ca> reported about?

Christian.

> ---
>   drivers/gpu/drm/radeon/atombios_dp.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
> index 1593652..bc0119f 100644
> --- a/drivers/gpu/drm/radeon/atombios_dp.c
> +++ b/drivers/gpu/drm/radeon/atombios_dp.c
> @@ -209,6 +209,7 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
>   {
>   	int ret;
>   
> +	radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd;
>   	radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
>   	radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer;
>   	ret = drm_dp_aux_register_i2c_bus(&radeon_connector->ddc_bus->aux);

RE: [PATCH] drm/radeon/aux: fix hpd assignment for aux bus

[Deucher, Alexander]

> -----Original Message-----
> From: Christian König [mailto:deathsimple@vodafone.de]
> Sent: Tuesday, April 22, 2014 5:17 AM
> To: Alex Deucher; dri-devel@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH] drm/radeon/aux: fix hpd assignment for aux bus
> 
> Am 22.04.2014 08:02, schrieb Alex Deucher:
> > The hpd (hot plug detect) pin assignment got lost
> > in the conversion to to the common i2c over aux
> > code.  Without this information, aux transactions
> > do not work properly.  Fixes DP failures.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> 
> Added to my 3.15 queue.
> 
> Does this also fix the issue Ed Tomlinson <edt@aei.ca> reported about?

It should fix the issue Ed and Ken reported and bug:
https://bugs.freedesktop.org/show_bug.cgi?id=77751

Alex

> 
> Christian.
> 
> > ---
> >   drivers/gpu/drm/radeon/atombios_dp.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/atombios_dp.c
> b/drivers/gpu/drm/radeon/atombios_dp.c
> > index 1593652..bc0119f 100644
> > --- a/drivers/gpu/drm/radeon/atombios_dp.c
> > +++ b/drivers/gpu/drm/radeon/atombios_dp.c
> > @@ -209,6 +209,7 @@ void radeon_dp_aux_init(struct radeon_connector
> *radeon_connector)
> >   {
> >   	int ret;
> >
> > +	radeon_connector->ddc_bus->rec.hpd = radeon_connector-
> >hpd.hpd;
> >   	radeon_connector->ddc_bus->aux.dev = radeon_connector-
> >base.kdev;
> >   	radeon_connector->ddc_bus->aux.transfer =
> radeon_dp_aux_transfer;
> >   	ret = drm_dp_aux_register_i2c_bus(&radeon_connector->ddc_bus-
> >aux);