* [PATCH] x86: add missing break in hwdom_pit_access()
@ 2014-04-23 6:48 Jan Beulich
2014-04-23 10:56 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2014-04-23 6:48 UTC (permalink / raw)
To: xen-devel; +Cc: Keir Fraser
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
Coverity ID 1203045
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1634,6 +1634,7 @@ int hwdom_pit_access(struct ioreq *ioreq
outb(ioreq->data, PIT_MODE);
return 1;
}
+ break;
case 0x61:
if ( ioreq->dir == IOREQ_READ )
[-- Attachment #2: x86-hwdom-PIT-ch01.patch --]
[-- Type: text/plain, Size: 397 bytes --]
x86: add missing break in hwdom_pit_access()
Coverity ID 1203045
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1634,6 +1634,7 @@ int hwdom_pit_access(struct ioreq *ioreq
outb(ioreq->data, PIT_MODE);
return 1;
}
+ break;
case 0x61:
if ( ioreq->dir == IOREQ_READ )
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: add missing break in hwdom_pit_access()
2014-04-23 6:48 [PATCH] x86: add missing break in hwdom_pit_access() Jan Beulich
@ 2014-04-23 10:56 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2014-04-23 10:56 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Keir Fraser
[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]
On 23/04/14 07:48, Jan Beulich wrote:
> Coverity ID 1203045
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -1634,6 +1634,7 @@ int hwdom_pit_access(struct ioreq *ioreq
> outb(ioreq->data, PIT_MODE);
> return 1;
> }
> + break;
>
> case 0x61:
> if ( ioreq->dir == IOREQ_READ )
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1503 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-23 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23 6:48 [PATCH] x86: add missing break in hwdom_pit_access() Jan Beulich
2014-04-23 10:56 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.