* [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'.
@ 2014-04-25 13:28 ` Karl Heiss
0 siblings, 0 replies; 7+ messages in thread
From: Karl Heiss @ 2014-04-25 13:28 UTC (permalink / raw)
To: netdev; +Cc: linux-sctp, davem, vyasevich, nhorman
Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
Additional (PMR - PFMR) consecutive timeouts on a PF destination
confirm the path failure, upon which the destination transitions to the
Inactive state. As described in [RFC4960], the sender (i) SHOULD notify
ULP about this state transition, and (ii) transmit heartbeats to the
Inactive destination at a lower frequency as described in Section 8.3 of
[RFC4960].
This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
Signed-off-by: Karl Heiss <kheiss@gmail.com>
---
net/sctp/sm_sideeffect.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 5d6883f..07f26fe 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
if ((transport->state != SCTP_PF) &&
(transport->state != SCTP_UNCONFIRMED) &&
(asoc->pf_retrans < transport->pathmaxrxt) &&
- (transport->error_count > asoc->pf_retrans)) {
+ (transport->error_count > asoc->pf_retrans) &&
+ (transport->error_count <= transport->pathmaxrxt)) {
sctp_assoc_control_transport(asoc, transport,
SCTP_TRANSPORT_PF,
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'.
@ 2014-04-25 13:28 ` Karl Heiss
0 siblings, 0 replies; 7+ messages in thread
From: Karl Heiss @ 2014-04-25 13:28 UTC (permalink / raw)
To: netdev; +Cc: linux-sctp, davem, vyasevich, nhorman
Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
Additional (PMR - PFMR) consecutive timeouts on a PF destination
confirm the path failure, upon which the destination transitions to the
Inactive state. As described in [RFC4960], the sender (i) SHOULD notify
ULP about this state transition, and (ii) transmit heartbeats to the
Inactive destination at a lower frequency as described in Section 8.3 of
[RFC4960].
This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
Signed-off-by: Karl Heiss <kheiss@gmail.com>
---
net/sctp/sm_sideeffect.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 5d6883f..07f26fe 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
if ((transport->state != SCTP_PF) &&
(transport->state != SCTP_UNCONFIRMED) &&
(asoc->pf_retrans < transport->pathmaxrxt) &&
- (transport->error_count > asoc->pf_retrans)) {
+ (transport->error_count > asoc->pf_retrans) &&
+ (transport->error_count <= transport->pathmaxrxt)) {
sctp_assoc_control_transport(asoc, transport,
SCTP_TRANSPORT_PF,
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retra
2014-04-25 13:28 ` Karl Heiss
@ 2014-04-25 13:30 ` Neil Horman
-1 siblings, 0 replies; 7+ messages in thread
From: Neil Horman @ 2014-04-25 13:30 UTC (permalink / raw)
To: Karl Heiss; +Cc: netdev, linux-sctp, davem, vyasevich
On Fri, Apr 25, 2014 at 09:28:40AM -0400, Karl Heiss wrote:
> Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
> Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
>
> Additional (PMR - PFMR) consecutive timeouts on a PF destination
> confirm the path failure, upon which the destination transitions to the
> Inactive state. As described in [RFC4960], the sender (i) SHOULD notify
> ULP about this state transition, and (ii) transmit heartbeats to the
> Inactive destination at a lower frequency as described in Section 8.3 of
> [RFC4960].
>
> This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
> bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
>
> Signed-off-by: Karl Heiss <kheiss@gmail.com>
> ---
> net/sctp/sm_sideeffect.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 5d6883f..07f26fe 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
> if ((transport->state != SCTP_PF) &&
> (transport->state != SCTP_UNCONFIRMED) &&
> (asoc->pf_retrans < transport->pathmaxrxt) &&
> - (transport->error_count > asoc->pf_retrans)) {
> + (transport->error_count > asoc->pf_retrans) &&
> + (transport->error_count <= transport->pathmaxrxt)) {
>
> sctp_assoc_control_transport(asoc, transport,
> SCTP_TRANSPORT_PF,
> --
> 1.7.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'.
@ 2014-04-25 13:30 ` Neil Horman
0 siblings, 0 replies; 7+ messages in thread
From: Neil Horman @ 2014-04-25 13:30 UTC (permalink / raw)
To: Karl Heiss; +Cc: netdev, linux-sctp, davem, vyasevich
On Fri, Apr 25, 2014 at 09:28:40AM -0400, Karl Heiss wrote:
> Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
> Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
>
> Additional (PMR - PFMR) consecutive timeouts on a PF destination
> confirm the path failure, upon which the destination transitions to the
> Inactive state. As described in [RFC4960], the sender (i) SHOULD notify
> ULP about this state transition, and (ii) transmit heartbeats to the
> Inactive destination at a lower frequency as described in Section 8.3 of
> [RFC4960].
>
> This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
> bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
>
> Signed-off-by: Karl Heiss <kheiss@gmail.com>
> ---
> net/sctp/sm_sideeffect.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 5d6883f..07f26fe 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
> if ((transport->state != SCTP_PF) &&
> (transport->state != SCTP_UNCONFIRMED) &&
> (asoc->pf_retrans < transport->pathmaxrxt) &&
> - (transport->error_count > asoc->pf_retrans)) {
> + (transport->error_count > asoc->pf_retrans) &&
> + (transport->error_count <= transport->pathmaxrxt)) {
>
> sctp_assoc_control_transport(asoc, transport,
> SCTP_TRANSPORT_PF,
> --
> 1.7.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retra
2014-04-25 13:28 ` Karl Heiss
@ 2014-04-25 13:39 ` Vlad Yasevich
-1 siblings, 0 replies; 7+ messages in thread
From: Vlad Yasevich @ 2014-04-25 13:39 UTC (permalink / raw)
To: Karl Heiss, netdev; +Cc: linux-sctp, davem, nhorman
On 04/25/2014 09:28 AM, Karl Heiss wrote:
> Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
> Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
>
> Additional (PMR - PFMR) consecutive timeouts on a PF destination
> confirm the path failure, upon which the destination transitions to the
> Inactive state. As described in [RFC4960], the sender (i) SHOULD notify
> ULP about this state transition, and (ii) transmit heartbeats to the
> Inactive destination at a lower frequency as described in Section 8.3 of
> [RFC4960].
>
> This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
> bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
>
Hi Karl
Please mark your patch versions.
I send a comment for the prior version you sent, but I'll say it here as
well. It would be better that you make it explicit that transition
from INACTIVE to PF is not allowed by using transport state.
-vlad
> Signed-off-by: Karl Heiss <kheiss@gmail.com>
> ---
> net/sctp/sm_sideeffect.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 5d6883f..07f26fe 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
> if ((transport->state != SCTP_PF) &&
> (transport->state != SCTP_UNCONFIRMED) &&
> (asoc->pf_retrans < transport->pathmaxrxt) &&
> - (transport->error_count > asoc->pf_retrans)) {
> + (transport->error_count > asoc->pf_retrans) &&
> + (transport->error_count <= transport->pathmaxrxt)) {
>
> sctp_assoc_control_transport(asoc, transport,
> SCTP_TRANSPORT_PF,
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'.
@ 2014-04-25 13:39 ` Vlad Yasevich
0 siblings, 0 replies; 7+ messages in thread
From: Vlad Yasevich @ 2014-04-25 13:39 UTC (permalink / raw)
To: Karl Heiss, netdev; +Cc: linux-sctp, davem, nhorman
On 04/25/2014 09:28 AM, Karl Heiss wrote:
> Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
> Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
>
> Additional (PMR - PFMR) consecutive timeouts on a PF destination
> confirm the path failure, upon which the destination transitions to the
> Inactive state. As described in [RFC4960], the sender (i) SHOULD notify
> ULP about this state transition, and (ii) transmit heartbeats to the
> Inactive destination at a lower frequency as described in Section 8.3 of
> [RFC4960].
>
> This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
> bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
>
Hi Karl
Please mark your patch versions.
I send a comment for the prior version you sent, but I'll say it here as
well. It would be better that you make it explicit that transition
from INACTIVE to PF is not allowed by using transport state.
-vlad
> Signed-off-by: Karl Heiss <kheiss@gmail.com>
> ---
> net/sctp/sm_sideeffect.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 5d6883f..07f26fe 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
> if ((transport->state != SCTP_PF) &&
> (transport->state != SCTP_UNCONFIRMED) &&
> (asoc->pf_retrans < transport->pathmaxrxt) &&
> - (transport->error_count > asoc->pf_retrans)) {
> + (transport->error_count > asoc->pf_retrans) &&
> + (transport->error_count <= transport->pathmaxrxt)) {
>
> sctp_assoc_control_transport(asoc, transport,
> SCTP_TRANSPORT_PF,
>
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1398367008-27452-1-git-send-email-kheiss@gmail.com>]
* Re: [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retra
[not found] <1398367008-27452-1-git-send-email-kheiss@gmail.com>
@ 2014-04-25 13:35 ` Vlad Yasevich
0 siblings, 0 replies; 7+ messages in thread
From: Vlad Yasevich @ 2014-04-25 13:35 UTC (permalink / raw)
To: Karl Heiss, netdev; +Cc: linux-sctp, nhorman
On 04/24/2014 03:16 PM, Karl Heiss wrote:
> Don't transition to the PF state on every strike after 'Path.Max.Retrans'. This
> also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state bounces
> between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
>
Good catch. We should never move to PF from INACTIVE. I'd rather you
make it explicit by checking state rather then error counts.
Thanks
-vlad
> Signed-off-by: Karl Heiss <kheiss@gmail.com>
> ---
> net/sctp/sm_sideeffect.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 5d6883f..07f26fe 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
> if ((transport->state != SCTP_PF) &&
> (transport->state != SCTP_UNCONFIRMED) &&
> (asoc->pf_retrans < transport->pathmaxrxt) &&
> - (transport->error_count > asoc->pf_retrans)) {
> + (transport->error_count > asoc->pf_retrans) &&
> + (transport->error_count <= transport->pathmaxrxt)) {
>
> sctp_assoc_control_transport(asoc, transport,
> SCTP_TRANSPORT_PF,
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-25 13:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-25 13:28 [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans' Karl Heiss
2014-04-25 13:28 ` Karl Heiss
2014-04-25 13:30 ` [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retra Neil Horman
2014-04-25 13:30 ` [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans' Neil Horman
2014-04-25 13:39 ` [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retra Vlad Yasevich
2014-04-25 13:39 ` [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans' Vlad Yasevich
[not found] <1398367008-27452-1-git-send-email-kheiss@gmail.com>
2014-04-25 13:35 ` [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retra Vlad Yasevich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.