All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: devel@lists.open80211s.org, Felix Fietkau <nbd@openwrt.org>,
	b.a.t.m.a.n@lists.open-mesh.org, linux-wireless@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 5/7] mac80211: minstrel - implement get_expected_throughput() API
Date: Fri, 25 Apr 2014 17:47:43 +0200	[thread overview]
Message-ID: <535A839F.2020805@open-mesh.com> (raw)
In-Reply-To: <1398440774.4152.28.camel@jlt4.sipsolutions.net>

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]



On 25/04/14 17:46, Johannes Berg wrote:
> On Mon, 2014-04-14 at 16:03 +0200, Antonio Quartulli wrote:
>> From: Antonio Quartulli <antonio@open-mesh.com>
>>
>> Cc: Felix Fietkau <nbd@openwrt.org>
>> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
>> ---
>>  net/mac80211/rc80211_minstrel.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
>> index 26fd94f..cd40bc0 100644
>> --- a/net/mac80211/rc80211_minstrel.c
>> +++ b/net/mac80211/rc80211_minstrel.c
>> @@ -657,6 +657,18 @@ minstrel_free(void *priv)
>>  	kfree(priv);
>>  }
>>  
>> +static u32
>> +minstrel_get_expected_throughput(void *priv, void *priv_sta,
>> +				 struct ieee80211_supported_band *sband)
>> +{
>> +	struct minstrel_sta_info *mi = priv_sta;
>> +	int idx = mi->max_tp_rate[0];
>> +	u32 bitrate, ret;
>> +
>> +	bitrate = sband->bitrates[mi->r[idx].rix].bitrate;
>> +	return bitrate * MINSTREL_TRUNC(mi->r[idx].probability * 1000) / 100;
> 
> /100? didn't you say minstrel already used your units?

MinstrelHT does, Minstrel does not...

Cheers,

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: b.a.t.m.a.n@lists.open-mesh.org, linux-wireless@vger.kernel.org,
	devel@lists.open80211s.org, Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH 5/7] mac80211: minstrel - implement get_expected_throughput() API
Date: Fri, 25 Apr 2014 17:47:43 +0200	[thread overview]
Message-ID: <535A839F.2020805@open-mesh.com> (raw)
In-Reply-To: <1398440774.4152.28.camel@jlt4.sipsolutions.net>

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]



On 25/04/14 17:46, Johannes Berg wrote:
> On Mon, 2014-04-14 at 16:03 +0200, Antonio Quartulli wrote:
>> From: Antonio Quartulli <antonio@open-mesh.com>
>>
>> Cc: Felix Fietkau <nbd@openwrt.org>
>> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
>> ---
>>  net/mac80211/rc80211_minstrel.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
>> index 26fd94f..cd40bc0 100644
>> --- a/net/mac80211/rc80211_minstrel.c
>> +++ b/net/mac80211/rc80211_minstrel.c
>> @@ -657,6 +657,18 @@ minstrel_free(void *priv)
>>  	kfree(priv);
>>  }
>>  
>> +static u32
>> +minstrel_get_expected_throughput(void *priv, void *priv_sta,
>> +				 struct ieee80211_supported_band *sband)
>> +{
>> +	struct minstrel_sta_info *mi = priv_sta;
>> +	int idx = mi->max_tp_rate[0];
>> +	u32 bitrate, ret;
>> +
>> +	bitrate = sband->bitrates[mi->r[idx].rix].bitrate;
>> +	return bitrate * MINSTREL_TRUNC(mi->r[idx].probability * 1000) / 100;
> 
> /100? didn't you say minstrel already used your units?

MinstrelHT does, Minstrel does not...

Cheers,

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  reply	other threads:[~2014-04-25 15:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 14:03 [B.A.T.M.A.N.] [PATCH 1/7] cfg80211: export expected throughput through get_station() Antonio Quartulli
2014-04-14 14:03 ` Antonio Quartulli
2014-04-14 14:03 ` [B.A.T.M.A.N.] [PATCH 2/7] mac80211: add get_expected_throughput API Antonio Quartulli
2014-04-14 14:03   ` Antonio Quartulli
2014-04-14 18:00   ` [B.A.T.M.A.N.] " Bastian Bittorf
2014-04-14 18:00     ` Bastian Bittorf
2014-04-18  0:56   ` Yeoh Chun-Yeow
2014-04-18  0:56     ` Yeoh Chun-Yeow
2014-04-18  6:19     ` Antonio Quartulli
2014-04-25 15:44   ` Johannes Berg
2014-04-25 15:44     ` Johannes Berg
2014-05-14 21:09     ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-05-14 21:09       ` Antonio Quartulli
2014-04-14 14:03 ` [B.A.T.M.A.N.] [PATCH 3/7] mac80211: add new RC API to retrieve expected throughput Antonio Quartulli
2014-04-14 14:03   ` Antonio Quartulli
2014-04-25 15:45   ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-25 15:45     ` Johannes Berg
2014-05-14 21:14     ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-05-14 21:14       ` Antonio Quartulli
2014-04-14 14:03 ` [B.A.T.M.A.N.] [PATCH 4/7] mac80211: export expected throughput in set_sta_info() Antonio Quartulli
2014-04-14 14:03   ` Antonio Quartulli
2014-04-14 14:03 ` [B.A.T.M.A.N.] [PATCH 5/7] mac80211: minstrel - implement get_expected_throughput() API Antonio Quartulli
2014-04-14 14:03   ` Antonio Quartulli
2014-04-25 15:46   ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-25 15:46     ` Johannes Berg
2014-04-25 15:47     ` Antonio Quartulli [this message]
2014-04-25 15:47       ` Antonio Quartulli
2014-04-14 14:03 ` [B.A.T.M.A.N.] [PATCH 6/7] mac80211: minstrel_ht " Antonio Quartulli
2014-04-14 14:03   ` Antonio Quartulli
2014-04-14 14:03 ` [B.A.T.M.A.N.] [PATCH 7/7] cfg80211: implement cfg80211_get_station cfg80211 API Antonio Quartulli
2014-04-14 14:03   ` Antonio Quartulli
2014-04-25 15:46   ` [B.A.T.M.A.N.] " Johannes Berg
2014-04-25 15:46     ` Johannes Berg
2014-05-14 21:15     ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-05-14 21:15       ` Antonio Quartulli
2014-04-25 15:44 ` [B.A.T.M.A.N.] [PATCH 1/7] cfg80211: export expected throughput through get_station() Johannes Berg
2014-04-25 15:44   ` Johannes Berg
2014-05-14 21:27   ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-05-14 21:27     ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535A839F.2020805@open-mesh.com \
    --to=antonio@open-mesh.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=devel@lists.open80211s.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.