All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: alsa-devel@alsa-project.org, Alexander Shiyan <shc_work@mail.ru>,
	linux-arm-kernel@lists.infradead.org,
	Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed
Date: Tue, 29 Apr 2014 12:57:24 +0200	[thread overview]
Message-ID: <535F8594.40609@metafoo.de> (raw)
In-Reply-To: <4270904.84oGcCXL4B@wuerfel>

On 04/29/2014 12:37 PM, Arnd Bergmann wrote:
> On Tuesday 29 April 2014 07:07:33 Alexander Shiyan wrote:
>> Mon, 28 Apr 2014 23:12:14 +0200 от Arnd Bergmann <arnd@arndb.de>:
>>> On Tuesday 29 April 2014 00:35:41 Alexander Shiyan wrote:
>>>>
>>>> So, I don't understand why this error happen, as well as I can not
>>>> reproduce this...
>>>
>>> It's probably CONFIG_SND_SOC_IMX_PCM_DMA=m and CONFIG_SND_SOC_FSL_SSI=y then.
>>> What is the intended behavior in this case? Should CONFIG_SND_SOC_FSL_SSI
>>> be forced to be a module as well?
>>
>> Hmm, yes...
>> I thought that I had already solved a similar problem for the earlier
>> version of the patch ...
>
> How about this?

Having FSL_SSI/FSL_SPDIF, but not SND_SOC_IMX_PCM_DMA does not make sense on 
iMX.
So how about:

	select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC

and remove all the other 'select SND_SOC_IMX_PCM_DMA' statements. That's in 
my opinion much nicer.

- Lars


>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index fb26345..af0bb92 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -9,6 +9,7 @@ config SND_SOC_FSL_SAI
>
>   config SND_SOC_FSL_SSI
>   	tristate "Synchronous Serial Interface module support"
> +	depends on m || SND_SOC_IMX_PCM_DMA != m
>   	help
>   	  Say Y if you want to add Synchronous Serial Interface (SSI)
>   	  support for the Freescale CPUs.
> @@ -18,6 +19,7 @@ config SND_SOC_FSL_SSI
>   config SND_SOC_FSL_SPDIF
>   	tristate "Sony/Philips Digital Interface module support"
>   	select REGMAP_MMIO
> +	depends on m || SND_SOC_IMX_PCM_DMA != m
>   	help
>   	  Say Y if you want to add Sony/Philips Digital Interface (SPDIF)
>   	  support for the Freescale CPUs.
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed
Date: Tue, 29 Apr 2014 12:57:24 +0200	[thread overview]
Message-ID: <535F8594.40609@metafoo.de> (raw)
In-Reply-To: <4270904.84oGcCXL4B@wuerfel>

On 04/29/2014 12:37 PM, Arnd Bergmann wrote:
> On Tuesday 29 April 2014 07:07:33 Alexander Shiyan wrote:
>> Mon, 28 Apr 2014 23:12:14 +0200 ?? Arnd Bergmann <arnd@arndb.de>:
>>> On Tuesday 29 April 2014 00:35:41 Alexander Shiyan wrote:
>>>>
>>>> So, I don't understand why this error happen, as well as I can not
>>>> reproduce this...
>>>
>>> It's probably CONFIG_SND_SOC_IMX_PCM_DMA=m and CONFIG_SND_SOC_FSL_SSI=y then.
>>> What is the intended behavior in this case? Should CONFIG_SND_SOC_FSL_SSI
>>> be forced to be a module as well?
>>
>> Hmm, yes...
>> I thought that I had already solved a similar problem for the earlier
>> version of the patch ...
>
> How about this?

Having FSL_SSI/FSL_SPDIF, but not SND_SOC_IMX_PCM_DMA does not make sense on 
iMX.
So how about:

	select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC

and remove all the other 'select SND_SOC_IMX_PCM_DMA' statements. That's in 
my opinion much nicer.

- Lars


>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index fb26345..af0bb92 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -9,6 +9,7 @@ config SND_SOC_FSL_SAI
>
>   config SND_SOC_FSL_SSI
>   	tristate "Synchronous Serial Interface module support"
> +	depends on m || SND_SOC_IMX_PCM_DMA != m
>   	help
>   	  Say Y if you want to add Synchronous Serial Interface (SSI)
>   	  support for the Freescale CPUs.
> @@ -18,6 +19,7 @@ config SND_SOC_FSL_SSI
>   config SND_SOC_FSL_SPDIF
>   	tristate "Sony/Philips Digital Interface module support"
>   	select REGMAP_MMIO
> +	depends on m || SND_SOC_IMX_PCM_DMA != m
>   	help
>   	  Say Y if you want to add Sony/Philips Digital Interface (SPDIF)
>   	  support for the Freescale CPUs.
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

  reply	other threads:[~2014-04-29 10:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 14:46 [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Arnd Bergmann
2014-04-28 14:46 ` Arnd Bergmann
2014-04-28 18:46 ` Alexander Shiyan
2014-04-28 19:52   ` Arnd Bergmann
2014-04-28 19:52     ` Arnd Bergmann
2014-04-28 20:35     ` Alexander Shiyan
2014-04-28 21:12       ` Arnd Bergmann
2014-04-28 21:12         ` Arnd Bergmann
2014-04-29  3:07         ` Alexander Shiyan
2014-04-29 10:37           ` Arnd Bergmann
2014-04-29 10:37             ` Arnd Bergmann
2014-04-29 10:57             ` Lars-Peter Clausen [this message]
2014-04-29 10:57               ` [alsa-devel] " Lars-Peter Clausen
2014-04-29 13:30               ` Arnd Bergmann
2014-04-29 13:30                 ` [alsa-devel] " Arnd Bergmann
2014-04-29 14:30                 ` Lars-Peter Clausen
2014-04-29 14:30                   ` Lars-Peter Clausen
2014-04-29 16:56                   ` Mark Brown
2014-04-29 16:56                     ` [alsa-devel] " Mark Brown
2014-04-29 19:16                     ` Arnd Bergmann
2014-04-29 19:16                       ` [alsa-devel] " Arnd Bergmann
2014-04-29 19:36                       ` Arnd Bergmann
2014-04-29 19:36                         ` [alsa-devel] " Arnd Bergmann
2014-05-01 20:54                         ` Mark Brown
2014-05-01 20:54                           ` [alsa-devel] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535F8594.40609@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.