* wait_for_completion in mmc_wait_for_req_done never returns
@ 2014-03-01 16:03 Jon Ringle
2014-03-27 5:39 ` Lee Chen
2014-05-01 13:57 ` Konstantin Dorfman
0 siblings, 2 replies; 6+ messages in thread
From: Jon Ringle @ 2014-03-01 16:03 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: schwidefsky@de.ibm.com
I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
I was able to bisect the problem to this commit:
0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
commit 0244ad004a54e39308d495fee0a2e637f8b5c317
Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date: Fri Aug 30 09:39:53 2013 +0200
^ permalink raw reply [flat|nested] 6+ messages in thread
* wait_for_completion in mmc_wait_for_req_done never returns
@ 2014-03-01 16:10 Jon Ringle
2014-03-03 6:32 ` Jon Ringle
0 siblings, 1 reply; 6+ messages in thread
From: Jon Ringle @ 2014-03-01 16:10 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: schwidefsky@de.ibm.com
I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
I was able to bisect the problem to this commit:
0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
commit 0244ad004a54e39308d495fee0a2e637f8b5c317
Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date: Fri Aug 30 09:39:53 2013 +0200
Remove GENERIC_HARDIRQ config option
After the last architecture switched to generic hard irqs the config
options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
for !CONFIG_GENERIC_HARDIRQS can be removed.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
I'm not sure what I should do to fix the problem. Does anyone have any suggestions?
Thanks,
Jon Ringle
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wait_for_completion in mmc_wait_for_req_done never returns
2014-03-01 16:10 Jon Ringle
@ 2014-03-03 6:32 ` Jon Ringle
0 siblings, 0 replies; 6+ messages in thread
From: Jon Ringle @ 2014-03-03 6:32 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: schwidefsky@de.ibm.com
My apologizes for the noise. I had a buggy bisect run script. The
mentioned commit here is not the source of the problem I am
encountering.
Jon
On Sat, Mar 1, 2014 at 11:10 AM, Jon Ringle <jonringle@gmail.com> wrote:
> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
>
> I was able to bisect the problem to this commit:
> 0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
> commit 0244ad004a54e39308d495fee0a2e637f8b5c317
> Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Date: Fri Aug 30 09:39:53 2013 +0200
>
> Remove GENERIC_HARDIRQ config option
>
> After the last architecture switched to generic hard irqs the config
> options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
> for !CONFIG_GENERIC_HARDIRQS can be removed.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> I'm not sure what I should do to fix the problem. Does anyone have any suggestions?
>
> Thanks,
> Jon Ringle
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wait_for_completion in mmc_wait_for_req_done never returns
2014-03-01 16:03 wait_for_completion in mmc_wait_for_req_done never returns Jon Ringle
@ 2014-03-27 5:39 ` Lee Chen
2014-05-01 13:57 ` Konstantin Dorfman
1 sibling, 0 replies; 6+ messages in thread
From: Lee Chen @ 2014-03-27 5:39 UTC (permalink / raw)
To: linux-mmc
Jon Ringle <jonringle <at> gmail.com> writes:
>
> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I
can no longer detect the SD card. I
> found that the wait_for_completion(&mrq->completion) in
> drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
>
> I was able to bisect the problem to this commit:
> 0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
> commit 0244ad004a54e39308d495fee0a2e637f8b5c317
> Author: Martin Schwidefsky <schwidefsky <at> de.ibm.com>
> Date: Fri Aug 30 09:39:53 2013 +0200
>
>
I noticed that issue as well. Did you get any response on this? I am
thinking replace the "wait_for_completion" with
"wait_for_completion_timeout". What value of the time out you think is
appropriate? I used 1000.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wait_for_completion in mmc_wait_for_req_done never returns
2014-03-01 16:03 wait_for_completion in mmc_wait_for_req_done never returns Jon Ringle
2014-03-27 5:39 ` Lee Chen
@ 2014-05-01 13:57 ` Konstantin Dorfman
2014-05-01 16:28 ` Jon Ringle
1 sibling, 1 reply; 6+ messages in thread
From: Konstantin Dorfman @ 2014-05-01 13:57 UTC (permalink / raw)
To: Jon Ringle, linux-mmc@vger.kernel.org; +Cc: schwidefsky@de.ibm.com
On 03/01/14 18:03, Jon Ringle wrote:
> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
Can you post relevant kernel log file, so I'll try to understand the flow?
What command is not getting completed? I suppose it is not data command.
Thanks,
Kostya
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wait_for_completion in mmc_wait_for_req_done never returns
2014-05-01 13:57 ` Konstantin Dorfman
@ 2014-05-01 16:28 ` Jon Ringle
0 siblings, 0 replies; 6+ messages in thread
From: Jon Ringle @ 2014-05-01 16:28 UTC (permalink / raw)
To: Konstantin Dorfman; +Cc: linux-mmc@vger.kernel.org, schwidefsky@de.ibm.com
On Thu, May 1, 2014 at 9:57 AM, Konstantin Dorfman
<kdorfman@codeaurora.org> wrote:
> On 03/01/14 18:03, Jon Ringle wrote:
>>
>> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I
>> can no longer detect the SD card. I found that the
>> wait_for_completion(&mrq->completion) in
>> drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
>
>
> Can you post relevant kernel log file, so I'll try to understand the flow?
> What command is not getting completed? I suppose it is not data command.
This issue was caused by a bug in drivers/dma/edma.c and has already
been fixed in
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5fc68a6cad658e45dca3e0a6607df3a8e5df4ef9
Jon
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-01 16:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-01 16:03 wait_for_completion in mmc_wait_for_req_done never returns Jon Ringle
2014-03-27 5:39 ` Lee Chen
2014-05-01 13:57 ` Konstantin Dorfman
2014-05-01 16:28 ` Jon Ringle
-- strict thread matches above, loose matches on Subject: below --
2014-03-01 16:10 Jon Ringle
2014-03-03 6:32 ` Jon Ringle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.