wait_for_completion in mmc_wait_for_req_done never returns

wait_for_completion in mmc_wait_for_req_done never returns

[Jon Ringle]

I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.

I was able to bisect the problem to this commit:
0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
commit 0244ad004a54e39308d495fee0a2e637f8b5c317
Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date:   Fri Aug 30 09:39:53 2013 +0200

Re: wait_for_completion in mmc_wait_for_req_done never returns

[Lee Chen]

Jon Ringle <jonringle <at> gmail.com> writes:

> 
> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I
can no longer detect the SD card. I
> found that the wait_for_completion(&mrq->completion) in
> drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
> 
> I was able to bisect the problem to this commit:
> 0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
> commit 0244ad004a54e39308d495fee0a2e637f8b5c317
> Author: Martin Schwidefsky <schwidefsky <at> de.ibm.com>
> Date:   Fri Aug 30 09:39:53 2013 +0200
> 
> 


I noticed that issue as well. Did you get any response on this? I am
thinking replace the "wait_for_completion" with
"wait_for_completion_timeout". What value of the time out you think is
appropriate? I used 1000.

Re: wait_for_completion in mmc_wait_for_req_done never returns

[Konstantin Dorfman]

On 03/01/14 18:03, Jon Ringle wrote:
> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.

Can you post relevant kernel log file, so I'll try to understand the flow?
What command is not getting completed? I suppose it is not data command.

Thanks,
Kostya

-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Re: wait_for_completion in mmc_wait_for_req_done never returns

[Jon Ringle]

On Thu, May 1, 2014 at 9:57 AM, Konstantin Dorfman
<kdorfman@codeaurora.org> wrote:
> On 03/01/14 18:03, Jon Ringle wrote:
>>
>> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I
>> can no longer detect the SD card. I found that the
>> wait_for_completion(&mrq->completion) in
>> drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
>
>
> Can you post relevant kernel log file, so I'll try to understand the flow?
> What command is not getting completed? I suppose it is not data command.

This issue was caused by a bug in drivers/dma/edma.c and has already
been fixed in
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5fc68a6cad658e45dca3e0a6607df3a8e5df4ef9

Jon

wait_for_completion in mmc_wait_for_req_done never returns

[Jon Ringle]

I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.

I was able to bisect the problem to this commit:
  0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
  commit 0244ad004a54e39308d495fee0a2e637f8b5c317
  Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
  Date:   Fri Aug 30 09:39:53 2013 +0200
  
  Remove GENERIC_HARDIRQ config option
  
  After the last architecture switched to generic hard irqs the config
  options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
  for !CONFIG_GENERIC_HARDIRQS can be removed.
  
  Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

I'm not sure what I should do to fix the problem. Does anyone have any suggestions?

Thanks,
Jon Ringle

Re: wait_for_completion in mmc_wait_for_req_done never returns

[Jon Ringle]

My apologizes for the noise. I had a buggy bisect run script. The
mentioned commit here is not the source of the problem I am
encountering.

Jon

On Sat, Mar 1, 2014 at 11:10 AM, Jon Ringle <jonringle@gmail.com> wrote:
> I'm porting an arm board from linux-3.10 to linux-3.12 and found that I can no longer detect the SD card. I found that the wait_for_completion(&mrq->completion) in drivers/mmc/core/core.c:mmc_wait_for_req_done() is never returning.
>
> I was able to bisect the problem to this commit:
>   0244ad004a54e39308d495fee0a2e637f8b5c317 is the first bad commit
>   commit 0244ad004a54e39308d495fee0a2e637f8b5c317
>   Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
>   Date:   Fri Aug 30 09:39:53 2013 +0200
>
>   Remove GENERIC_HARDIRQ config option
>
>   After the last architecture switched to generic hard irqs the config
>   options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
>   for !CONFIG_GENERIC_HARDIRQS can be removed.
>
>   Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> I'm not sure what I should do to fix the problem. Does anyone have any suggestions?
>
> Thanks,
> Jon Ringle