From: Marian Marinov <mm-108MBtLGafw@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
davidlohr-VXdhtT5mjnY@public.gmane.org,
n-horiguchi-PaJj6Psr51x8UrSeD/g0lQ@public.gmane.org,
Greg KH
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
manfred-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: [PATCH] IPC initialize shmmax and shmall from the current value not the default
Date: Sun, 04 May 2014 01:48:29 +0300 [thread overview]
Message-ID: <5365723D.7030303@1h.com> (raw)
When we are creating new IPC namespace that should be cloned from the current namespace it is a good idea to copy the
values of the current shmmax and shmall to the new namespace.
Copying the values of the init_ipc_ns would allow us to create new ipc namespaces with different values without granting
them privileges to change those values.
Here is the proposed patch:
---
ipc/shm.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index 7a51443..b7a4728 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -74,8 +74,13 @@ static int sysvipc_shm_proc_show(struct seq_file *s, void *it);
void shm_init_ns(struct ipc_namespace *ns)
{
- ns->shm_ctlmax = SHMMAX;
- ns->shm_ctlall = SHMALL;
+ if (ns == &init_ipc_ns) {
+ ns->shm_ctlmax = SHMMAX;
+ ns->shm_ctlall = SHMALL;
+ } else {
+ ns->shm_ctlmax = init_ipc_ns.shm_ctlmax;
+ ns->shm_ctlall = init_ipc_ns.shm_ctlall;
+ }
ns->shm_ctlmni = SHMMNI;
ns->shm_rmid_forced = 0;
ns->shm_tot = 0;
--
1.8.4
--
Marian Marinov
Founder & CEO of 1H Ltd.
Jabber/GTalk: hackman-/eSpBmjxGS4dnm+yROfE0A@public.gmane.org
ICQ: 7556201
Mobile: +359 886 660 270
WARNING: multiple messages have this Message-ID (diff)
From: Marian Marinov <mm@1h.com>
To: akpm@linux-foundation.org, davidlohr@hp.com,
n-horiguchi@ah.jp.nec.com, Greg KH <gregkh@linuxfoundation.org>,
manfred@colorfullife.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: [PATCH] IPC initialize shmmax and shmall from the current value not the default
Date: Sun, 04 May 2014 01:48:29 +0300 [thread overview]
Message-ID: <5365723D.7030303@1h.com> (raw)
When we are creating new IPC namespace that should be cloned from the current namespace it is a good idea to copy the
values of the current shmmax and shmall to the new namespace.
Copying the values of the init_ipc_ns would allow us to create new ipc namespaces with different values without granting
them privileges to change those values.
Here is the proposed patch:
---
ipc/shm.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index 7a51443..b7a4728 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -74,8 +74,13 @@ static int sysvipc_shm_proc_show(struct seq_file *s, void *it);
void shm_init_ns(struct ipc_namespace *ns)
{
- ns->shm_ctlmax = SHMMAX;
- ns->shm_ctlall = SHMALL;
+ if (ns == &init_ipc_ns) {
+ ns->shm_ctlmax = SHMMAX;
+ ns->shm_ctlall = SHMALL;
+ } else {
+ ns->shm_ctlmax = init_ipc_ns.shm_ctlmax;
+ ns->shm_ctlall = init_ipc_ns.shm_ctlall;
+ }
ns->shm_ctlmni = SHMMNI;
ns->shm_rmid_forced = 0;
ns->shm_tot = 0;
--
1.8.4
--
Marian Marinov
Founder & CEO of 1H Ltd.
Jabber/GTalk: hackman@jabber.org
ICQ: 7556201
Mobile: +359 886 660 270
next reply other threads:[~2014-05-03 22:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 22:48 Marian Marinov [this message]
2014-05-03 22:48 ` [PATCH] IPC initialize shmmax and shmall from the current value not the default Marian Marinov
[not found] ` <5365723D.7030303-108MBtLGafw@public.gmane.org>
2014-05-03 23:53 ` Davidlohr Bueso
2014-05-03 23:53 ` Davidlohr Bueso
[not found] ` <1399161216.2573.9.camel-5JQ4ckphU/8SZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2014-05-04 0:28 ` Marian Marinov
2014-05-04 0:28 ` Marian Marinov
[not found] ` <536589B5.8060900-108MBtLGafw@public.gmane.org>
2014-05-04 1:20 ` Davidlohr Bueso
2014-05-04 1:20 ` Davidlohr Bueso
[not found] ` <1399166450.2573.15.camel-5JQ4ckphU/8SZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2014-05-04 9:29 ` Marian Marinov
2014-05-04 9:29 ` Marian Marinov
2014-05-04 11:17 ` Manfred Spraul
2014-05-04 11:17 ` Manfred Spraul
[not found] ` <536621D4.60002-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org>
2014-05-04 17:19 ` Davidlohr Bueso
2014-05-04 17:19 ` Davidlohr Bueso
2014-05-05 19:59 ` Marian Marinov
[not found] ` <5367EDB6.3010408-108MBtLGafw@public.gmane.org>
2014-05-22 13:01 ` Marian Marinov
2014-05-22 13:01 ` Marian Marinov
[not found] ` <537DF520.2050904-108MBtLGafw@public.gmane.org>
2014-05-25 20:01 ` Manfred Spraul
2014-05-25 20:01 ` Manfred Spraul
[not found] ` <53824C0D.1070204-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org>
2014-05-26 0:07 ` Marian Marinov
2014-05-26 0:07 ` Marian Marinov
2014-05-27 14:41 ` Serge Hallyn
2014-05-27 14:41 ` Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5365723D.7030303@1h.com \
--to=mm-108mbtlgafw@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=davidlohr-VXdhtT5mjnY@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=manfred-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org \
--cc=n-horiguchi-PaJj6Psr51x8UrSeD/g0lQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.