* Re: [Qemu-devel] [PATCH] spapr_pci: Fix maximum IRQ number check in ibm, change-msi [not found] ` <535F73AB.8010403@suse.de> @ 2014-05-04 10:28 ` Alexey Kardashevskiy 2014-05-04 12:02 ` Alexander Graf 0 siblings, 1 reply; 2+ messages in thread From: Alexey Kardashevskiy @ 2014-05-04 10:28 UTC (permalink / raw) To: Alexander Graf, qemu-devel; +Cc: qemu-ppc, qemu-stable On 04/29/2014 07:40 PM, Alexander Graf wrote: > > On 29.04.14 05:17, Alexey Kardashevskiy wrote: >> Recently a check for maximum supported MSIX vectors number has been >> added. However the check always assumed that MSIX is the only case >> and failed on devices which have MSI but do not have MSIX such as >> QEMU's PCI Bridge. This results in assert in xics_alloc_block() as >> req_num is zero. >> >> This adds a check for MSI vectors number too. >> >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> >> --- >> >> I posted recently a memory corruption fix, patch >> "spapr_pci: Fix number of returned vectors in ibm, change-msi". >> >> However it breaks QEMU's PCI bridge so here is a patch. >> >> I would prepare a patch to replace the one in agrag/ppc-next ad01ba7 >> but it has Cc: qemu-stable@nongnu.org in it so I am afraid it could make >> it to some other tree already (did not it?). >> >> Sorry for missing that. This is embarassing :( > > You're lucky - No, I am not. Found another bug, please revert this, I'll repost the patch. Sorry :( > the patch didn't get out of my queue yet. I've squashed this > patch into the previous, broken commit and qemu-stable will only get CC'ed > on the resulting, working patch. -- Alexey ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr_pci: Fix maximum IRQ number check in ibm, change-msi 2014-05-04 10:28 ` [Qemu-devel] [PATCH] spapr_pci: Fix maximum IRQ number check in ibm, change-msi Alexey Kardashevskiy @ 2014-05-04 12:02 ` Alexander Graf 0 siblings, 0 replies; 2+ messages in thread From: Alexander Graf @ 2014-05-04 12:02 UTC (permalink / raw) To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org > Am 04.05.2014 um 12:28 schrieb Alexey Kardashevskiy <aik@ozlabs.ru>: > >> On 04/29/2014 07:40 PM, Alexander Graf wrote: >> >>> On 29.04.14 05:17, Alexey Kardashevskiy wrote: >>> Recently a check for maximum supported MSIX vectors number has been >>> added. However the check always assumed that MSIX is the only case >>> and failed on devices which have MSI but do not have MSIX such as >>> QEMU's PCI Bridge. This results in assert in xics_alloc_block() as >>> req_num is zero. >>> >>> This adds a check for MSI vectors number too. >>> >>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> >>> --- >>> >>> I posted recently a memory corruption fix, patch >>> "spapr_pci: Fix number of returned vectors in ibm, change-msi". >>> >>> However it breaks QEMU's PCI bridge so here is a patch. >>> >>> I would prepare a patch to replace the one in agrag/ppc-next ad01ba7 >>> but it has Cc: qemu-stable@nongnu.org in it so I am afraid it could make >>> it to some other tree already (did not it?). >>> >>> Sorry for missing that. This is embarassing :( >> >> You're lucky - > > No, I am not. Found another bug, please revert this, I'll repost the patch. > Sorry :( Please post the patch on top of this one. Alex > > >> the patch didn't get out of my queue yet. I've squashed this >> patch into the previous, broken commit and qemu-stable will only get CC'ed >> on the resulting, working patch. > > > -- > Alexey ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-04 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1398741464-21394-1-git-send-email-aik@ozlabs.ru>
[not found] ` <535F73AB.8010403@suse.de>
2014-05-04 10:28 ` [Qemu-devel] [PATCH] spapr_pci: Fix maximum IRQ number check in ibm, change-msi Alexey Kardashevskiy
2014-05-04 12:02 ` Alexander Graf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.