All of lore.kernel.org
 help / color / mirror / Atom feed
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support
Date: Wed, 7 May 2014 19:05:30 +0530	[thread overview]
Message-ID: <536A36A2.5030109@ti.com> (raw)
In-Reply-To: <1399434623-20383-4-git-send-email-maxime.ripard@free-electrons.com>

Hi,

On Wednesday 07 May 2014 09:20 AM, Maxime Ripard wrote:
> The USB phy controller in the A31 differs mostly from the older controllers
> because it has a clock dedicated for each phy, while the older ones were having
> a single clock for all the phys.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/phy/phy-sun4i-usb.c | 35 ++++++++++++++++++++++++++---------
>  1 file changed, 26 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
> index e6e6c4ba7145..1d83abe07a29 100644
> --- a/drivers/phy/phy-sun4i-usb.c
> +++ b/drivers/phy/phy-sun4i-usb.c
> @@ -61,16 +61,17 @@
>  #define MAX_PHYS			3
>  
>  struct sun4i_usb_phy_data {
> -	struct clk *clk;
>  	void __iomem *base;
>  	struct mutex mutex;
>  	int num_phys;
>  	u32 disc_thresh;
> +	bool dedicated_clocks;

Don't think we need this structure member as it's been used only in probe.

Thanks
Kishon

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Emilio Lopez <emilio@elopez.com.ar>,
	Mike Turquette <mturquette@linaro.org>,
	<stern@rowland.harvard.edu>, <hdegoede@redhat.com>
Cc: Boris Brezillon <boris@free-electrons.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-usb@vger.kernel.org>, <kevin.z.m.zh@gmail.com>,
	<sunny@allwinnertech.com>, <shuge@allwinnertech.com>,
	<zhuzhenhua@allwinnertech.com>, <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support
Date: Wed, 7 May 2014 19:05:30 +0530	[thread overview]
Message-ID: <536A36A2.5030109@ti.com> (raw)
In-Reply-To: <1399434623-20383-4-git-send-email-maxime.ripard@free-electrons.com>

Hi,

On Wednesday 07 May 2014 09:20 AM, Maxime Ripard wrote:
> The USB phy controller in the A31 differs mostly from the older controllers
> because it has a clock dedicated for each phy, while the older ones were having
> a single clock for all the phys.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/phy/phy-sun4i-usb.c | 35 ++++++++++++++++++++++++++---------
>  1 file changed, 26 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
> index e6e6c4ba7145..1d83abe07a29 100644
> --- a/drivers/phy/phy-sun4i-usb.c
> +++ b/drivers/phy/phy-sun4i-usb.c
> @@ -61,16 +61,17 @@
>  #define MAX_PHYS			3
>  
>  struct sun4i_usb_phy_data {
> -	struct clk *clk;
>  	void __iomem *base;
>  	struct mutex mutex;
>  	int num_phys;
>  	u32 disc_thresh;
> +	bool dedicated_clocks;

Don't think we need this structure member as it's been used only in probe.

Thanks
Kishon

  reply	other threads:[~2014-05-07 13:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  3:50 [PATCH 0/7] Add Allwinner A31 USB support Maxime Ripard
2014-05-07  3:50 ` Maxime Ripard
2014-05-07  3:50 ` [PATCH 1/7] clk: sunxi: Implement A31 USB clock Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07  3:50 ` [PATCH 2/7] ARM: sun6i: Add the USB clocks to the DTSI Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07  3:50 ` [PATCH 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07 13:35   ` Kishon Vijay Abraham I [this message]
2014-05-07 13:35     ` Kishon Vijay Abraham I
2014-05-07 21:57     ` Maxime Ripard
2014-05-07 21:57       ` Maxime Ripard
2014-05-07  3:50 ` [PATCH 4/7] usb: ehci-platform: add optional reset controller retrieval Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07 14:25   ` Alan Stern
2014-05-07 14:25     ` Alan Stern
2014-05-07 22:00     ` Maxime Ripard
2014-05-07 22:00       ` Maxime Ripard
2014-05-08  7:29       ` Hans de Goede
2014-05-08  7:29         ` Hans de Goede
2014-05-08 14:07         ` Alan Stern
2014-05-08 14:07           ` Alan Stern
2014-05-10  1:17           ` Maxime Ripard
2014-05-10  1:17             ` Maxime Ripard
2014-05-07  3:50 ` [PATCH 5/7] usb: ohci-platform: Enable optional use of reset controller Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07 16:26   ` Sergei Shtylyov
2014-05-07 16:26     ` Sergei Shtylyov
2014-05-07 22:03     ` Maxime Ripard
2014-05-07 22:03       ` Maxime Ripard
2014-05-08 13:11       ` Sergei Shtylyov
2014-05-08 13:11         ` Sergei Shtylyov
2014-05-07  3:50 ` [PATCH 6/7] ARM: sun6i: dt: Add support for the USB controllers Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07  3:50 ` [PATCH 7/7] ARM: sunxi: dt: add APP4-EVB1 board support Maxime Ripard
2014-05-07  3:50   ` Maxime Ripard
2014-05-07  5:10   ` [linux-sunxi] " Koen Kooi
2014-05-07  5:10     ` Koen Kooi
2014-05-07  6:46     ` Hans de Goede
2014-05-07  6:46       ` Hans de Goede
2014-05-07  8:25 ` [PATCH 0/7] Add Allwinner A31 USB support Hans de Goede
2014-05-07  8:25   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A36A2.5030109@ti.com \
    --to=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.