From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr
Date: Thu, 08 May 2014 10:06:59 +0000 [thread overview]
Message-ID: <536B5743.2060708@suse.de> (raw)
In-Reply-To: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 05/06/2014 04:30 PM, Aneesh Kumar K.V wrote:
> Although it's optional IBM POWER cpus always had DAR value set on
> alignment interrupt. So don't try to compute these values.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
The patch body is fine now. The commit message however is not. The patch
does two things:
* Merge DSISR calculation with Linux's implementation
* Use the real DAR on book3s_64 alignment interrupts
In fact, you probably should make this 2 patches.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr
Date: Thu, 08 May 2014 12:06:59 +0200 [thread overview]
Message-ID: <536B5743.2060708@suse.de> (raw)
In-Reply-To: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 05/06/2014 04:30 PM, Aneesh Kumar K.V wrote:
> Although it's optional IBM POWER cpus always had DAR value set on
> alignment interrupt. So don't try to compute these values.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
The patch body is fine now. The commit message however is not. The patch
does two things:
* Merge DSISR calculation with Linux's implementation
* Use the real DAR on book3s_64 alignment interrupts
In fact, you probably should make this 2 patches.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr
Date: Thu, 08 May 2014 12:06:59 +0200 [thread overview]
Message-ID: <536B5743.2060708@suse.de> (raw)
In-Reply-To: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 05/06/2014 04:30 PM, Aneesh Kumar K.V wrote:
> Although it's optional IBM POWER cpus always had DAR value set on
> alignment interrupt. So don't try to compute these values.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
The patch body is fine now. The commit message however is not. The patch
does two things:
* Merge DSISR calculation with Linux's implementation
* Use the real DAR on book3s_64 alignment interrupts
In fact, you probably should make this 2 patches.
Alex
next prev parent reply other threads:[~2014-05-08 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 14:30 [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr Aneesh Kumar K.V
2014-05-06 14:42 ` Aneesh Kumar K.V
2014-05-06 14:30 ` Aneesh Kumar K.V
2014-05-08 10:06 ` Alexander Graf [this message]
2014-05-08 10:06 ` Alexander Graf
2014-05-08 10:06 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B5743.2060708@suse.de \
--to=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.