All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Capella <sebastian.capella@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Kevin Hilman <khilman@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Sebastian Capella <capellas@broadcom.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Nicolas Pitre <nico@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Amit Kucheria <amit.kucheria@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Antti Miettinen <ananaza@iki.fi>,
	Sudeep Holla <Sudeep.Holla@arm.com>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	Tomasz Figa <t.figa@samsung.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Charles Garcia-Tobin <Charles.Garcia-Tobin@a>
Subject: Re: [PATCH RFC v3 1/6] Documentation: arm: define DT idle states bindings
Date: Thu, 08 May 2014 16:28:28 -0700	[thread overview]
Message-ID: <536c131d.43d7440a.1d61.ffff95ca@mx.google.com> (raw)
In-Reply-To: <20140508085743.GA12860@e102568-lin.cambridge.arm.com>

Quoting Lorenzo Pieralisi (2014-05-08 01:57:43)
> On Thu, May 08, 2014 at 12:43:04AM +0100, Sebastian Capella wrote:
> > Quoting Lorenzo Pieralisi (2014-05-06 11:04:38)
> > > diff --git a/Documentation/devicetree/bindings/arm/idle-states.txt b/Documentation/devicetree/bindings/arm/idle-states.txt
> > > new file mode 100644
> > > index 0000000..196ef52
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/arm/idle-states.txt
> > > @@ -0,0 +1,508 @@
...
> > > +
> > > +The nodes describing the idle states (state) can only be defined within the
> > > +idle-states node.
> > > +
> > > +Any other configuration is consider invalid and therefore must be ignored.
> > 
> > consider -> considered
> > must be -> shall?
> > 
> > Is the reference to "any other configuration" referring to state nodes
> > not in the idle states node?  If so, maybe this sentence should go
> > together with that one.
> 
> Yes, it makes sense.
> 

With this small change you can add my Reviewed-by

Thanks!

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: sebastian.capella@linaro.org (Sebastian Capella)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v3 1/6] Documentation: arm: define DT idle states bindings
Date: Thu, 08 May 2014 16:28:28 -0700	[thread overview]
Message-ID: <536c131d.43d7440a.1d61.ffff95ca@mx.google.com> (raw)
In-Reply-To: <20140508085743.GA12860@e102568-lin.cambridge.arm.com>

Quoting Lorenzo Pieralisi (2014-05-08 01:57:43)
> On Thu, May 08, 2014 at 12:43:04AM +0100, Sebastian Capella wrote:
> > Quoting Lorenzo Pieralisi (2014-05-06 11:04:38)
> > > diff --git a/Documentation/devicetree/bindings/arm/idle-states.txt b/Documentation/devicetree/bindings/arm/idle-states.txt
> > > new file mode 100644
> > > index 0000000..196ef52
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/arm/idle-states.txt
> > > @@ -0,0 +1,508 @@
...
> > > +
> > > +The nodes describing the idle states (state) can only be defined within the
> > > +idle-states node.
> > > +
> > > +Any other configuration is consider invalid and therefore must be ignored.
> > 
> > consider -> considered
> > must be -> shall?
> > 
> > Is the reference to "any other configuration" referring to state nodes
> > not in the idle states node?  If so, maybe this sentence should go
> > together with that one.
> 
> Yes, it makes sense.
> 

With this small change you can add my Reviewed-by

Thanks!

Sebastian

  reply	other threads:[~2014-05-08 23:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 18:04 [PATCH RFC v3 0/6] ARM generic idle states Lorenzo Pieralisi
2014-05-06 18:04 ` Lorenzo Pieralisi
2014-05-06 18:04 ` [PATCH RFC v3 2/6] Documentation: devicetree: psci: define CPU suspend parameter Lorenzo Pieralisi
2014-05-06 18:04   ` Lorenzo Pieralisi
2014-05-07 23:45   ` Sebastian Capella
2014-05-07 23:45     ` Sebastian Capella
2014-05-06 18:04 ` [PATCH RFC v3 3/6] drivers: cpuidle: implement OF based idle states infrastructure Lorenzo Pieralisi
2014-05-06 18:04   ` Lorenzo Pieralisi
2014-05-08 23:12   ` Sebastian Capella
2014-05-08 23:12     ` Sebastian Capella
2014-05-09  9:47     ` Lorenzo Pieralisi
2014-05-09  9:47       ` Lorenzo Pieralisi
2014-05-09 12:04     ` Lorenzo Pieralisi
2014-05-09 12:04       ` Lorenzo Pieralisi
     [not found] ` <1399399483-17112-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
2014-05-06 18:04   ` [PATCH RFC v3 1/6] Documentation: arm: define DT idle states bindings Lorenzo Pieralisi
2014-05-06 18:04     ` Lorenzo Pieralisi
2014-05-07 23:43     ` Sebastian Capella
2014-05-07 23:43       ` Sebastian Capella
2014-05-08  8:57       ` Lorenzo Pieralisi
2014-05-08  8:57         ` Lorenzo Pieralisi
2014-05-08 23:28         ` Sebastian Capella [this message]
2014-05-08 23:28           ` Sebastian Capella
2014-05-06 18:04   ` [PATCH RFC v3 4/6] arm64: add PSCI CPU_SUSPEND based cpu_suspend support Lorenzo Pieralisi
2014-05-06 18:04     ` Lorenzo Pieralisi
2014-05-09 23:11     ` Sebastian Capella
2014-05-09 23:11       ` Sebastian Capella
2014-05-06 18:04   ` [PATCH RFC v3 5/6] drivers: cpuidle: CPU idle ARM64 driver Lorenzo Pieralisi
2014-05-06 18:04     ` Lorenzo Pieralisi
2014-05-09  0:48     ` Sebastian Capella
2014-05-09  0:48       ` Sebastian Capella
2014-05-09  9:40       ` Lorenzo Pieralisi
2014-05-09  9:40         ` Lorenzo Pieralisi
2014-05-06 18:04 ` [PATCH RFC v3 6/6] arm64: boot: dts: update rtsm aemv8 dts with PSCI and idle states Lorenzo Pieralisi
2014-05-06 18:04   ` Lorenzo Pieralisi
2014-05-09  0:51   ` Sebastian Capella
2014-05-09  0:51     ` Sebastian Capella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536c131d.43d7440a.1d61.ffff95ca@mx.google.com \
    --to=sebastian.capella@linaro.org \
    --cc=Catalin.Marinas@arm.com \
    --cc=Charles.Garcia-Tobin@a \
    --cc=Mark.Rutland@arm.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=amit.kucheria@linaro.org \
    --cc=ananaza@iki.fi \
    --cc=capellas@broadcom.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=nico@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=sboyd@codeaurora.org \
    --cc=t.figa@samsung.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.