All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"dean_jenkins@mentor.com" <dean_jenkins@mentor.com>,
	"shawn.guo@freescale.com" <shawn.guo@freescale.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/5] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
Date: Mon, 12 May 2014 14:53:12 +0800	[thread overview]
Message-ID: <53706FD8.6090201@freescale.com> (raw)
In-Reply-To: <53706CC3.4030907@de.bosch.com>

于 2014年05月12日 14:40, Dirk Behme 写道:
> On 12.05.2014 08:30, Huang Shijie wrote:
>> 于 2014年05月12日 13:45, Dirk Behme 写道:
>>> On 12.05.2014 05:40, Huang Shijie wrote:
>>>> 于 2014年05月09日 23:19, dean_jenkins@mentor.com 写道:
>>>>> Use imx_start_tx() just to enable the TX interrupt. It's the job 
>>>>> of the
>>>>> TX interrupt ISR to fill the transmit buffer, then. If the transmit
>>>>> buffer
>>   From the Documentation/serial/driver, we can see:
>>     -----------------------------------------
>>      start_tx(port)
>>       Start transmitting characters.
>>      -----------------------------------------
>>
>> It tells us we can transmit data in the imx_start_tx.
>
> Well, it depends how you read 'Start transmitting', no?
>
> It doesn't have to mean 'actually transmit data'. It talks about 
> 'start'. And this could also mean 'start the transmission (by enabling 
> the interrupt)'.
>
Ok :)
I do not object this patch.

My opinion is : If the third patch is redundant, could this patch still 
needed?


>> But this patch moves it to the interrupt handler,
>
> It doesn't 'move' any code to the interrupt handler. The code in the 
> interrupt handler is already there.
>
i knew it.

>> this patch makes the
>> interrupt handler do more jobs.
>
> ... to get the locking in the correct order.
>
again, the third patch can be ignored.
The locking is correct for the imx.c.


thanks
Huang Shijie

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
Date: Mon, 12 May 2014 14:53:12 +0800	[thread overview]
Message-ID: <53706FD8.6090201@freescale.com> (raw)
In-Reply-To: <53706CC3.4030907@de.bosch.com>

? 2014?05?12? 14:40, Dirk Behme ??:
> On 12.05.2014 08:30, Huang Shijie wrote:
>> ? 2014?05?12? 13:45, Dirk Behme ??:
>>> On 12.05.2014 05:40, Huang Shijie wrote:
>>>> ? 2014?05?09? 23:19, dean_jenkins at mentor.com ??:
>>>>> Use imx_start_tx() just to enable the TX interrupt. It's the job 
>>>>> of the
>>>>> TX interrupt ISR to fill the transmit buffer, then. If the transmit
>>>>> buffer
>>   From the Documentation/serial/driver, we can see:
>>     -----------------------------------------
>>      start_tx(port)
>>       Start transmitting characters.
>>      -----------------------------------------
>>
>> It tells us we can transmit data in the imx_start_tx.
>
> Well, it depends how you read 'Start transmitting', no?
>
> It doesn't have to mean 'actually transmit data'. It talks about 
> 'start'. And this could also mean 'start the transmission (by enabling 
> the interrupt)'.
>
Ok :)
I do not object this patch.

My opinion is : If the third patch is redundant, could this patch still 
needed?


>> But this patch moves it to the interrupt handler,
>
> It doesn't 'move' any code to the interrupt handler. The code in the 
> interrupt handler is already there.
>
i knew it.

>> this patch makes the
>> interrupt handler do more jobs.
>
> ... to get the locking in the correct order.
>
again, the third patch can be ignored.
The locking is correct for the imx.c.


thanks
Huang Shijie

  reply	other threads:[~2014-05-12  6:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 15:19 [PATCH 0/5] serial: imx: fixes dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-09 15:19 ` [PATCH 1/5] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx() dean_jenkins
2014-05-09 15:19   ` dean_jenkins at mentor.com
2014-05-12  3:40   ` Huang Shijie
2014-05-12  3:40     ` Huang Shijie
2014-05-12  5:45     ` Dirk Behme
2014-05-12  5:45       ` Dirk Behme
2014-05-12  6:30       ` Huang Shijie
2014-05-12  6:30         ` Huang Shijie
2014-05-12  6:40         ` Dirk Behme
2014-05-12  6:40           ` Dirk Behme
2014-05-12  6:53           ` Huang Shijie [this message]
2014-05-12  6:53             ` Huang Shijie
2014-05-12  8:03             ` Dean Jenkins
2014-05-12  8:03               ` Dean Jenkins
2014-05-12  8:17               ` Huang Shijie
2014-05-12  8:17                 ` Huang Shijie
2014-05-09 15:19 ` [PATCH 2/5] serial: imx: remove uart_write_wakeup() from imx_transmit_buffer() dean_jenkins
2014-05-09 15:19   ` dean_jenkins at mentor.com
2014-05-09 15:19 ` [PATCH 3/5] serial: imx: avoid spinlock recursion deadlock dean_jenkins
2014-05-09 15:19   ` dean_jenkins at mentor.com
2014-05-12  3:12   ` Huang Shijie
2014-05-12  3:12     ` Huang Shijie
2014-05-14 16:24     ` Dean Jenkins
2014-05-14 16:24       ` Dean Jenkins
2014-05-09 15:19 ` [PATCH 4/5] serial: imx: move imx_transmit_buffer() into imx_txint() dean_jenkins
2014-05-09 15:19   ` dean_jenkins at mentor.com
2014-05-09 15:19 ` [PATCH 5/5] serial: imx: clean up imx_poll_get_char() dean_jenkins
2014-05-09 15:19   ` dean_jenkins at mentor.com
2014-05-28 19:34 ` [PATCH 0/5] serial: imx: fixes Greg KH
2014-05-28 19:34   ` Greg KH
2014-05-29  4:58   ` Dirk Behme
2014-05-29  4:58     ` Dirk Behme
2014-05-29  4:14     ` Huang Shijie
2014-05-29  4:14       ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53706FD8.6090201@freescale.com \
    --to=b32955@freescale.com \
    --cc=dean_jenkins@mentor.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.