From: Dirk Behme <dirk.behme@gmail.com>
To: dean_jenkins@mentor.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
dirk.behme@de.bosch.com, s.hauer@pengutronix.de,
b32955@freescale.com, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, shawn.guo@freescale.com
Subject: Re: [PATCH 0/5] serial: imx: fixes
Date: Thu, 29 May 2014 06:58:55 +0200 [thread overview]
Message-ID: <5386BE8F.20605@gmail.com> (raw)
In-Reply-To: <20140528193442.GA7066@kroah.com>
Am 28.05.2014 21:34, schrieb Greg KH:
> On Fri, May 09, 2014 at 04:19:43PM +0100, dean_jenkins@mentor.com wrote:
>> From: Dean Jenkins <Dean_Jenkins@mentor.com>
>>
>> The following set of patches were tested on an i.MX6 multi-core platform.
>>
>> Patches 1 to 4 were tested using a Bluetooth BCSP UART connection at 115.2kbps
>> and 4Mbps. The fixes were needed because the i.MX6 UART driver caused spinlock
>> deadlocks with the HCI TTY layer.
>>
>> Patch 5 improves the i.MX6 UART driver for use with kdb.
>>
>> Patch 1: serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
>> Patch 2: serial: imx: remove uart_write_wakeup() from imx_transmit_buffer()
>> Patch 3: serial: imx: avoid spinlock recursion deadlock
>> Patch 4: serial: imx: move imx_transmit_buffer() into imx_txint()
>> Patch 5: serial: imx: clean up imx_poll_get_char()
>>
>> The patches are based off 3.15-rc4.
>>
>> ----------------------------------------------------------------
>> Andy Lowe (1):
>> serial: imx: avoid spinlock recursion deadlock
>>
>> Dirk Behme (4):
>> serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
>> serial: imx: remove uart_write_wakeup() from imx_transmit_buffer()
>> serial: imx: move imx_transmit_buffer() into imx_txint()
>> serial: imx: clean up imx_poll_get_char()
>>
>> drivers/tty/serial/imx.c | 73 ++++++++++++++--------------------------------
>> 1 file changed, 22 insertions(+), 51 deletions(-)
>
> Given the rather confusing threads based on these patches, I don't know
> what to apply.
>
> Dean, can you respin what patches you want applied
Well, we think patches #1-#4 are correct and should be applied, but
Huang has the opinion that this is fixed already in the BT stack. If
Huang doesn't change his mind, then let's drop #1-#4.
Patch #5 addresses an other topic and therefore should be resent, then.
Best regards
Dirk
WARNING: multiple messages have this Message-ID (diff)
From: dirk.behme@gmail.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] serial: imx: fixes
Date: Thu, 29 May 2014 06:58:55 +0200 [thread overview]
Message-ID: <5386BE8F.20605@gmail.com> (raw)
In-Reply-To: <20140528193442.GA7066@kroah.com>
Am 28.05.2014 21:34, schrieb Greg KH:
> On Fri, May 09, 2014 at 04:19:43PM +0100, dean_jenkins at mentor.com wrote:
>> From: Dean Jenkins <Dean_Jenkins@mentor.com>
>>
>> The following set of patches were tested on an i.MX6 multi-core platform.
>>
>> Patches 1 to 4 were tested using a Bluetooth BCSP UART connection at 115.2kbps
>> and 4Mbps. The fixes were needed because the i.MX6 UART driver caused spinlock
>> deadlocks with the HCI TTY layer.
>>
>> Patch 5 improves the i.MX6 UART driver for use with kdb.
>>
>> Patch 1: serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
>> Patch 2: serial: imx: remove uart_write_wakeup() from imx_transmit_buffer()
>> Patch 3: serial: imx: avoid spinlock recursion deadlock
>> Patch 4: serial: imx: move imx_transmit_buffer() into imx_txint()
>> Patch 5: serial: imx: clean up imx_poll_get_char()
>>
>> The patches are based off 3.15-rc4.
>>
>> ----------------------------------------------------------------
>> Andy Lowe (1):
>> serial: imx: avoid spinlock recursion deadlock
>>
>> Dirk Behme (4):
>> serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
>> serial: imx: remove uart_write_wakeup() from imx_transmit_buffer()
>> serial: imx: move imx_transmit_buffer() into imx_txint()
>> serial: imx: clean up imx_poll_get_char()
>>
>> drivers/tty/serial/imx.c | 73 ++++++++++++++--------------------------------
>> 1 file changed, 22 insertions(+), 51 deletions(-)
>
> Given the rather confusing threads based on these patches, I don't know
> what to apply.
>
> Dean, can you respin what patches you want applied
Well, we think patches #1-#4 are correct and should be applied, but
Huang has the opinion that this is fixed already in the BT stack. If
Huang doesn't change his mind, then let's drop #1-#4.
Patch #5 addresses an other topic and therefore should be resent, then.
Best regards
Dirk
next prev parent reply other threads:[~2014-05-29 4:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 15:19 [PATCH 0/5] serial: imx: fixes dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-09 15:19 ` [PATCH 1/5] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx() dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-12 3:40 ` Huang Shijie
2014-05-12 3:40 ` Huang Shijie
2014-05-12 5:45 ` Dirk Behme
2014-05-12 5:45 ` Dirk Behme
2014-05-12 6:30 ` Huang Shijie
2014-05-12 6:30 ` Huang Shijie
2014-05-12 6:40 ` Dirk Behme
2014-05-12 6:40 ` Dirk Behme
2014-05-12 6:53 ` Huang Shijie
2014-05-12 6:53 ` Huang Shijie
2014-05-12 8:03 ` Dean Jenkins
2014-05-12 8:03 ` Dean Jenkins
2014-05-12 8:17 ` Huang Shijie
2014-05-12 8:17 ` Huang Shijie
2014-05-09 15:19 ` [PATCH 2/5] serial: imx: remove uart_write_wakeup() from imx_transmit_buffer() dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-09 15:19 ` [PATCH 3/5] serial: imx: avoid spinlock recursion deadlock dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-12 3:12 ` Huang Shijie
2014-05-12 3:12 ` Huang Shijie
2014-05-14 16:24 ` Dean Jenkins
2014-05-14 16:24 ` Dean Jenkins
2014-05-09 15:19 ` [PATCH 4/5] serial: imx: move imx_transmit_buffer() into imx_txint() dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-09 15:19 ` [PATCH 5/5] serial: imx: clean up imx_poll_get_char() dean_jenkins
2014-05-09 15:19 ` dean_jenkins at mentor.com
2014-05-28 19:34 ` [PATCH 0/5] serial: imx: fixes Greg KH
2014-05-28 19:34 ` Greg KH
2014-05-29 4:58 ` Dirk Behme [this message]
2014-05-29 4:58 ` Dirk Behme
2014-05-29 4:14 ` Huang Shijie
2014-05-29 4:14 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386BE8F.20605@gmail.com \
--to=dirk.behme@gmail.com \
--cc=b32955@freescale.com \
--cc=dean_jenkins@mentor.com \
--cc=dirk.behme@de.bosch.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.