* [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
@ 2014-05-12 14:22 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-05-12 14:22 UTC (permalink / raw)
To: linux-arm-kernel
Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
Also, the at91sam9261 doesn't really have a by 3 divisor.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Changed in v2:
After getting feedback from the atmel HW engineers, it appears that PLLB is not
the same as PLLA despite what the datasheet seems to imply. The patch is updated
to reflect that.
arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
index 561addceb81e..44d9e5ab09c3 100644
--- a/arch/arm/boot/dts/at91sam9261.dtsi
+++ b/arch/arm/boot/dts/at91sam9261.dtsi
@@ -564,7 +564,8 @@
reg = <0>;
atmel,clk-input-range = <1000000 32000000>;
#atmel,pll-clk-output-range-cells = <4>;
- atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
+ atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
+ <190000000 240000000 2 1>;
};
pllb: pllbck {
@@ -573,9 +574,9 @@
interrupts-extended = <&pmc AT91_PMC_LOCKB>;
clocks = <&main>;
reg = <1>;
- atmel,clk-input-range = <1000000 32000000>;
+ atmel,clk-input-range = <1000000 5000000>;
#atmel,pll-clk-output-range-cells = <4>;
- atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
+ atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
};
mck: masterck {
@@ -584,13 +585,13 @@
interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
atmel,clk-output-range = <0 94000000>;
- atmel,clk-divisors = <1 2 4 3>;
+ atmel,clk-divisors = <1 2 4 0>;
};
usb: usbck {
compatible = "atmel,at91rm9200-clk-usb";
#clock-cells = <0>;
- atmel,clk-divisors = <1 2 4 3>;
+ atmel,clk-divisors = <1 2 4 0>;
clocks = <&pllb>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
@ 2014-05-12 14:22 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-05-12 14:22 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel,
Boris Brezillon, Alexandre Belloni
Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
Also, the at91sam9261 doesn't really have a by 3 divisor.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Changed in v2:
After getting feedback from the atmel HW engineers, it appears that PLLB is not
the same as PLLA despite what the datasheet seems to imply. The patch is updated
to reflect that.
arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
index 561addceb81e..44d9e5ab09c3 100644
--- a/arch/arm/boot/dts/at91sam9261.dtsi
+++ b/arch/arm/boot/dts/at91sam9261.dtsi
@@ -564,7 +564,8 @@
reg = <0>;
atmel,clk-input-range = <1000000 32000000>;
#atmel,pll-clk-output-range-cells = <4>;
- atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
+ atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
+ <190000000 240000000 2 1>;
};
pllb: pllbck {
@@ -573,9 +574,9 @@
interrupts-extended = <&pmc AT91_PMC_LOCKB>;
clocks = <&main>;
reg = <1>;
- atmel,clk-input-range = <1000000 32000000>;
+ atmel,clk-input-range = <1000000 5000000>;
#atmel,pll-clk-output-range-cells = <4>;
- atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
+ atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
};
mck: masterck {
@@ -584,13 +585,13 @@
interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
atmel,clk-output-range = <0 94000000>;
- atmel,clk-divisors = <1 2 4 3>;
+ atmel,clk-divisors = <1 2 4 0>;
};
usb: usbck {
compatible = "atmel,at91rm9200-clk-usb";
#clock-cells = <0>;
- atmel,clk-divisors = <1 2 4 3>;
+ atmel,clk-divisors = <1 2 4 0>;
clocks = <&pllb>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
2014-05-12 14:22 ` Alexandre Belloni
@ 2014-05-12 14:25 ` Boris BREZILLON
-1 siblings, 0 replies; 6+ messages in thread
From: Boris BREZILLON @ 2014-05-12 14:25 UTC (permalink / raw)
To: linux-arm-kernel
On 12/05/2014 16:22, Alexandre Belloni wrote:
> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
> Also, the at91sam9261 doesn't really have a by 3 divisor.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changed in v2:
> After getting feedback from the atmel HW engineers, it appears that PLLB is not
> the same as PLLA despite what the datasheet seems to imply. The patch is updated
> to reflect that.
>
> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
> index 561addceb81e..44d9e5ab09c3 100644
> --- a/arch/arm/boot/dts/at91sam9261.dtsi
> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
> @@ -564,7 +564,8 @@
> reg = <0>;
> atmel,clk-input-range = <1000000 32000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
> + <190000000 240000000 2 1>;
> };
>
> pllb: pllbck {
> @@ -573,9 +574,9 @@
> interrupts-extended = <&pmc AT91_PMC_LOCKB>;
> clocks = <&main>;
> reg = <1>;
> - atmel,clk-input-range = <1000000 32000000>;
> + atmel,clk-input-range = <1000000 5000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
> };
>
> mck: masterck {
> @@ -584,13 +585,13 @@
> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
> atmel,clk-output-range = <0 94000000>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> };
>
> usb: usbck {
> compatible = "atmel,at91rm9200-clk-usb";
> #clock-cells = <0>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> clocks = <&pllb>;
> };
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
@ 2014-05-12 14:25 ` Boris BREZILLON
0 siblings, 0 replies; 6+ messages in thread
From: Boris BREZILLON @ 2014-05-12 14:25 UTC (permalink / raw)
To: Alexandre Belloni, Nicolas Ferre
Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel
On 12/05/2014 16:22, Alexandre Belloni wrote:
> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
> Also, the at91sam9261 doesn't really have a by 3 divisor.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changed in v2:
> After getting feedback from the atmel HW engineers, it appears that PLLB is not
> the same as PLLA despite what the datasheet seems to imply. The patch is updated
> to reflect that.
>
> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
> index 561addceb81e..44d9e5ab09c3 100644
> --- a/arch/arm/boot/dts/at91sam9261.dtsi
> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
> @@ -564,7 +564,8 @@
> reg = <0>;
> atmel,clk-input-range = <1000000 32000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
> + <190000000 240000000 2 1>;
> };
>
> pllb: pllbck {
> @@ -573,9 +574,9 @@
> interrupts-extended = <&pmc AT91_PMC_LOCKB>;
> clocks = <&main>;
> reg = <1>;
> - atmel,clk-input-range = <1000000 32000000>;
> + atmel,clk-input-range = <1000000 5000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
> };
>
> mck: masterck {
> @@ -584,13 +585,13 @@
> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
> atmel,clk-output-range = <0 94000000>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> };
>
> usb: usbck {
> compatible = "atmel,at91rm9200-clk-usb";
> #clock-cells = <0>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> clocks = <&pllb>;
> };
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
2014-05-12 14:25 ` Boris BREZILLON
@ 2014-05-12 14:54 ` Nicolas Ferre
-1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2014-05-12 14:54 UTC (permalink / raw)
To: linux-arm-kernel
On 12/05/2014 16:25, Boris BREZILLON :
>
> On 12/05/2014 16:22, Alexandre Belloni wrote:
>> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
>> Also, the at91sam9261 doesn't really have a by 3 divisor.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Ok, thanks guys, I have just updated the at91-3.16-dt2 branch with this
modification.
Bye,
>> ---
>> Changed in v2:
>> After getting feedback from the atmel HW engineers, it appears that PLLB is not
>> the same as PLLA despite what the datasheet seems to imply. The patch is updated
>> to reflect that.
>>
>> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
>> index 561addceb81e..44d9e5ab09c3 100644
>> --- a/arch/arm/boot/dts/at91sam9261.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
>> @@ -564,7 +564,8 @@
>> reg = <0>;
>> atmel,clk-input-range = <1000000 32000000>;
>> #atmel,pll-clk-output-range-cells = <4>;
>> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
>> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
>> + <190000000 240000000 2 1>;
>> };
>>
>> pllb: pllbck {
>> @@ -573,9 +574,9 @@
>> interrupts-extended = <&pmc AT91_PMC_LOCKB>;
>> clocks = <&main>;
>> reg = <1>;
>> - atmel,clk-input-range = <1000000 32000000>;
>> + atmel,clk-input-range = <1000000 5000000>;
>> #atmel,pll-clk-output-range-cells = <4>;
>> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
>> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
>> };
>>
>> mck: masterck {
>> @@ -584,13 +585,13 @@
>> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
>> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
>> atmel,clk-output-range = <0 94000000>;
>> - atmel,clk-divisors = <1 2 4 3>;
>> + atmel,clk-divisors = <1 2 4 0>;
>> };
>>
>> usb: usbck {
>> compatible = "atmel,at91rm9200-clk-usb";
>> #clock-cells = <0>;
>> - atmel,clk-divisors = <1 2 4 3>;
>> + atmel,clk-divisors = <1 2 4 0>;
>> clocks = <&pllb>;
>> };
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
@ 2014-05-12 14:54 ` Nicolas Ferre
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2014-05-12 14:54 UTC (permalink / raw)
To: Boris BREZILLON, Alexandre Belloni
Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel
On 12/05/2014 16:25, Boris BREZILLON :
>
> On 12/05/2014 16:22, Alexandre Belloni wrote:
>> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
>> Also, the at91sam9261 doesn't really have a by 3 divisor.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Ok, thanks guys, I have just updated the at91-3.16-dt2 branch with this
modification.
Bye,
>> ---
>> Changed in v2:
>> After getting feedback from the atmel HW engineers, it appears that PLLB is not
>> the same as PLLA despite what the datasheet seems to imply. The patch is updated
>> to reflect that.
>>
>> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
>> index 561addceb81e..44d9e5ab09c3 100644
>> --- a/arch/arm/boot/dts/at91sam9261.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
>> @@ -564,7 +564,8 @@
>> reg = <0>;
>> atmel,clk-input-range = <1000000 32000000>;
>> #atmel,pll-clk-output-range-cells = <4>;
>> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
>> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
>> + <190000000 240000000 2 1>;
>> };
>>
>> pllb: pllbck {
>> @@ -573,9 +574,9 @@
>> interrupts-extended = <&pmc AT91_PMC_LOCKB>;
>> clocks = <&main>;
>> reg = <1>;
>> - atmel,clk-input-range = <1000000 32000000>;
>> + atmel,clk-input-range = <1000000 5000000>;
>> #atmel,pll-clk-output-range-cells = <4>;
>> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
>> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
>> };
>>
>> mck: masterck {
>> @@ -584,13 +585,13 @@
>> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
>> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
>> atmel,clk-output-range = <0 94000000>;
>> - atmel,clk-divisors = <1 2 4 3>;
>> + atmel,clk-divisors = <1 2 4 0>;
>> };
>>
>> usb: usbck {
>> compatible = "atmel,at91rm9200-clk-usb";
>> #clock-cells = <0>;
>> - atmel,clk-divisors = <1 2 4 3>;
>> + atmel,clk-divisors = <1 2 4 0>;
>> clocks = <&pllb>;
>> };
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-12 14:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 14:22 [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors Alexandre Belloni
2014-05-12 14:22 ` Alexandre Belloni
2014-05-12 14:25 ` Boris BREZILLON
2014-05-12 14:25 ` Boris BREZILLON
2014-05-12 14:54 ` Nicolas Ferre
2014-05-12 14:54 ` Nicolas Ferre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.