From: holler@ahsoftware.de (Alexander Holler)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/9] dt: deps: dependency based device creation
Date: Wed, 14 May 2014 17:51:36 +0200 [thread overview]
Message-ID: <53739108.40209@ahsoftware.de> (raw)
In-Reply-To: <20140514140534.897F8C4153D@trevor.secretlab.ca>
Am 14.05.2014 16:05, schrieb Grant Likely:
>> +
>> + if (graph.finished)
>> + return -EINVAL; /* cycle found */
>> +
>> + /* of_init_print_order(); */
>
> If you wrap of_init_print_order with a #ifdef DEBUG/#else/#endif, then
> you don't need to comment out the call to of_init_print_order().
To explain why I didn't use DEBUG here: DEBUG enables a lot of
distracting messages. which is true for CONFIG_DEBUG_DRIVER too.
Therefor I often prefer to use just pr_info("AHO: ..."); with which I
print only stuff I want (and can easily grep for).
And as said, the patches I presented are meant for evaluation. I did
patches without discussing them before in order to avoid endless
discussion which likely never would have found an end and therfor would
have prevented a start. So now you already have some to play and test
with, without anyone had to discuss stuff before. ;)
Regards,
Alexander Holler
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Holler <holler@ahsoftware.de>
To: Grant Likely <grant.likely@linaro.org>, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <linux@arm.linux.org.uk>, Jon Loeliger <jdl@jdl.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [RFC PATCH 2/9] dt: deps: dependency based device creation
Date: Wed, 14 May 2014 17:51:36 +0200 [thread overview]
Message-ID: <53739108.40209@ahsoftware.de> (raw)
In-Reply-To: <20140514140534.897F8C4153D@trevor.secretlab.ca>
Am 14.05.2014 16:05, schrieb Grant Likely:
>> +
>> + if (graph.finished)
>> + return -EINVAL; /* cycle found */
>> +
>> + /* of_init_print_order(); */
>
> If you wrap of_init_print_order with a #ifdef DEBUG/#else/#endif, then
> you don't need to comment out the call to of_init_print_order().
To explain why I didn't use DEBUG here: DEBUG enables a lot of
distracting messages. which is true for CONFIG_DEBUG_DRIVER too.
Therefor I often prefer to use just pr_info("AHO: ..."); with which I
print only stuff I want (and can easily grep for).
And as said, the patches I presented are meant for evaluation. I did
patches without discussing them before in order to avoid endless
discussion which likely never would have found an end and therfor would
have prevented a start. So now you already have some to play and test
with, without anyone had to discuss stuff before. ;)
Regards,
Alexander Holler
next prev parent reply other threads:[~2014-05-14 15:51 UTC|newest]
Thread overview: 241+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 16:47 [RFC PATCH 0/9] dt: dependencies (for deterministic driver initialization order based on the DT) Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 1/9] dt: deps: dtc: Automatically add new property 'dependencies' which contains a list of referenced phandles Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-17 12:16 ` Tomasz Figa
2014-05-17 12:16 ` Tomasz Figa
2014-05-17 12:16 ` Tomasz Figa
2014-05-19 12:35 ` Alexander Holler
2014-05-19 12:35 ` Alexander Holler
2014-05-19 15:38 ` Jon Loeliger
2014-05-19 15:49 ` Jon Loeliger
2014-05-19 17:26 ` Alexander Holler
2014-05-19 17:26 ` Alexander Holler
2014-05-19 17:26 ` Alexander Holler
2014-05-27 20:02 ` Grant Likely
2014-05-27 20:02 ` Grant Likely
2014-05-27 20:02 ` Grant Likely
2014-05-27 20:31 ` Alexander Holler
2014-05-27 20:31 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 2/9] dt: deps: dependency based device creation Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-14 14:05 ` Grant Likely
2014-05-14 14:05 ` Grant Likely
2014-05-14 14:05 ` Grant Likely
2014-05-14 14:49 ` Alexander Holler
2014-05-14 14:49 ` Alexander Holler
2014-05-14 14:49 ` Alexander Holler
2014-05-14 17:20 ` Alexander Holler
2014-05-14 17:20 ` Alexander Holler
2014-05-14 20:06 ` Grant Likely
2014-05-14 20:06 ` Grant Likely
2014-05-14 20:06 ` Grant Likely
2014-05-14 21:10 ` Alexander Holler
2014-05-14 21:10 ` Alexander Holler
2014-05-16 11:00 ` Grant Likely
2014-05-16 11:00 ` Grant Likely
2014-05-16 11:00 ` Grant Likely
2014-05-18 9:53 ` Alexander Holler
2014-05-18 9:53 ` Alexander Holler
2014-05-16 17:31 ` Alexander Shiyan
[not found] ` <5373DBCF.1080503-SXC+2es9fhnfWeYVQQPykw@public.gmane.org>
2014-05-16 17:31 ` Alexander Shiyan
2014-05-16 17:31 ` Alexander Shiyan
2014-05-16 17:31 ` Alexander Shiyan
2014-05-16 17:31 ` Alexander Shiyan
2014-05-14 15:51 ` Alexander Holler [this message]
2014-05-14 15:51 ` Alexander Holler
2014-05-17 14:24 ` Tomasz Figa
2014-05-17 14:24 ` Tomasz Figa
2014-05-18 14:59 ` Grant Likely
2014-05-18 14:59 ` Grant Likely
2014-05-19 8:41 ` Alexander Holler
2014-05-19 8:41 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 3/9] dt: deps: dtc: Add option to print initialization order Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 20:38 ` Jon Loeliger
2014-05-12 22:58 ` Alexander Holler
2014-05-12 22:58 ` Alexander Holler
2014-05-12 22:58 ` Alexander Holler
[not found] ` <537151FF.8070104-SXC+2es9fhnfWeYVQQPykw@public.gmane.org>
2014-05-13 8:54 ` [PATCH 0/3] add dependencies Alexander Holler
[not found] ` <1399971243-18153-1-git-send-email-holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org>
2014-05-13 8:54 ` [PATCH 1/3] deps: Automatically add new property 'dependencies' which contains a list of referenced phandles Alexander Holler
2014-05-13 8:54 ` [PATCH 2/3] deps: Add option to print initialization order Alexander Holler
2014-05-13 8:54 ` [PATCH 3/3] deps: Add option to print dependency graph as dot (Graphviz) Alexander Holler
2014-05-13 18:48 ` [PATCH] deps: introduce new (virtual) property no-dependencies Alexander Holler
[not found] ` <1400006923-7950-1-git-send-email-holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org>
2014-05-14 1:55 ` Alexander Holler
[not found] ` <5372CD15.5020001-SXC+2es9fhnfWeYVQQPykw@public.gmane.org>
2014-05-14 7:02 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 4/9] dt: deps: dtc: Add option to print dependency graph as dot (Graphviz) Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 5/9] dt: deps: register drivers based on the initialization order based on DT Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-14 14:13 ` Grant Likely
2014-05-14 14:13 ` Grant Likely
2014-05-14 14:13 ` Grant Likely
2014-05-14 14:58 ` Alexander Holler
2014-05-14 14:58 ` Alexander Holler
2014-05-14 14:58 ` Alexander Holler
2014-05-14 19:32 ` Grant Likely
2014-05-14 19:32 ` Grant Likely
2014-05-14 19:32 ` Grant Likely
2014-05-12 16:47 ` [RFC PATCH 6/9] dt: deps: WIP: well done drivers Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 7/9] dt: deps: kirkwood: make it possible to use CONFIG_OF_DEPENDENCIES Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 8/9] dt: deps: dts: kirkwood: dockstar: add dependency ehci -> usb power regulator Alexander Holler
2014-05-12 16:47 ` Alexander Holler
2014-05-12 16:48 ` [RFC PATCH 9/9] dt: deps: omap2: make it possible to use CONFIG_OF_DEPENDENCIES Alexander Holler
2014-05-12 16:48 ` Alexander Holler
2014-05-13 15:40 ` [PATCH 10/9] dt: deps: fix bug not registering late drivers when OF_DEPENDENCIES is disabled Alexander Holler
2014-05-13 15:40 ` Alexander Holler
2014-05-13 15:40 ` Alexander Holler
2014-05-13 19:27 ` [RFC PATCH 11/9] dt: deps: dtc: introduce new (virtual) property no-dependencies Alexander Holler
2014-05-13 19:27 ` Alexander Holler
2014-05-13 19:27 ` Alexander Holler
2014-05-14 8:20 ` dt: deps: some tips about how to debug/evaluate this feature Alexander Holler
2014-05-14 14:19 ` [RFC PATCH 0/9] dt: dependencies (for deterministic driver initialization order based on the DT) Grant Likely
2014-05-14 14:19 ` Grant Likely
2014-05-14 14:19 ` Grant Likely
2014-05-14 15:02 ` Alexander Holler
2014-05-14 15:02 ` Alexander Holler
2014-05-14 16:05 ` Grant Likely
2014-05-14 16:05 ` Grant Likely
2014-05-14 16:05 ` Grant Likely
2014-05-14 16:23 ` Alexander Holler
2014-05-14 16:23 ` Alexander Holler
2014-05-14 16:23 ` Alexander Holler
2014-05-14 17:30 ` Rob Herring
2014-05-14 17:30 ` Rob Herring
2014-05-14 17:45 ` Alexander Holler
2014-05-14 17:45 ` Alexander Holler
2014-05-14 17:53 ` Alexander Holler
2014-05-14 17:53 ` Alexander Holler
2014-05-14 18:16 ` Alexander Holler
2014-05-14 18:16 ` Alexander Holler
2014-05-14 18:16 ` Alexander Holler
2014-05-14 19:13 ` Alexander Holler
2014-05-14 19:13 ` Alexander Holler
2014-05-14 19:06 ` Rob Herring
2014-05-14 19:06 ` Rob Herring
2014-05-14 19:24 ` Alexander Holler
2014-05-14 19:24 ` Alexander Holler
2014-05-14 19:24 ` Alexander Holler
2014-05-15 1:46 ` Alexander Holler
2014-05-15 1:46 ` Alexander Holler
2014-05-15 1:46 ` Alexander Holler
2014-05-14 23:00 ` Alexander Holler
2014-05-14 23:00 ` Alexander Holler
2014-05-14 23:00 ` Alexander Holler
2014-08-21 14:02 ` Thierry Reding
2014-08-21 14:02 ` Thierry Reding
2014-08-21 14:02 ` Thierry Reding
2014-08-21 19:19 ` Alexander Holler
2014-08-21 19:19 ` Alexander Holler
2014-08-21 19:19 ` Alexander Holler
2014-08-22 13:19 ` Mark Rutland
2014-08-22 13:19 ` Mark Rutland
2014-08-22 13:19 ` Mark Rutland
2014-08-22 15:45 ` Alexander Holler
2014-08-22 15:45 ` Alexander Holler
2014-08-25 9:39 ` Thierry Reding
2014-08-25 9:39 ` Thierry Reding
2014-08-25 9:39 ` Thierry Reding
2014-08-25 13:08 ` Jon Loeliger
2014-08-25 13:08 ` Jon Loeliger
2014-08-25 13:08 ` Jon Loeliger
2014-08-25 13:37 ` Thierry Reding
2014-08-25 13:37 ` Thierry Reding
2014-08-25 13:37 ` Thierry Reding
2014-08-25 14:13 ` Jon Loeliger
2014-08-25 14:13 ` Jon Loeliger
2014-08-25 14:13 ` Jon Loeliger
2014-08-25 14:41 ` Thierry Reding
2014-08-25 14:41 ` Thierry Reding
2014-08-25 14:41 ` Thierry Reding
2014-08-26 8:42 ` Grant Likely
2014-08-26 8:42 ` Grant Likely
2014-08-26 8:42 ` Grant Likely
2014-08-26 8:49 ` Thierry Reding
2014-08-26 8:49 ` Thierry Reding
2014-08-26 9:42 ` Alexander Holler
2014-08-26 9:42 ` Alexander Holler
2014-08-26 10:11 ` Mark Rutland
2014-08-26 10:11 ` Mark Rutland
2014-08-26 10:24 ` Thierry Reding
2014-08-26 10:24 ` Thierry Reding
2014-08-26 10:24 ` Thierry Reding
2014-08-27 10:34 ` Grant Likely
2014-08-27 10:34 ` Grant Likely
2014-08-27 14:44 ` Catalin Marinas
2014-08-27 14:44 ` Catalin Marinas
2014-08-27 14:44 ` Catalin Marinas
2014-08-27 16:22 ` Stephen Warren
2014-08-27 16:22 ` Stephen Warren
2014-08-27 16:22 ` Stephen Warren
2014-08-27 16:30 ` Alexander Holler
2014-08-27 16:30 ` Alexander Holler
2014-08-27 16:30 ` Alexander Holler
2014-08-27 16:37 ` Stephen Warren
2014-08-27 16:37 ` Stephen Warren
2014-08-27 16:58 ` Alexander Holler
2014-08-27 16:58 ` Alexander Holler
2014-08-27 17:52 ` Catalin Marinas
2014-08-27 17:52 ` Catalin Marinas
2014-08-27 17:52 ` Catalin Marinas
2014-08-27 18:14 ` Alexander Holler
2014-08-27 18:14 ` Alexander Holler
2014-08-27 18:14 ` Alexander Holler
2014-08-28 6:50 ` Alexander Holler
2014-08-28 6:50 ` Alexander Holler
2014-08-28 9:23 ` Catalin Marinas
2014-08-28 9:23 ` Catalin Marinas
2014-08-29 1:43 ` Alexander Holler
2014-08-29 1:43 ` Alexander Holler
2014-08-29 1:43 ` Alexander Holler
2014-08-26 10:25 ` Thierry Reding
2014-08-26 10:25 ` Thierry Reding
2014-08-26 10:25 ` Thierry Reding
2014-08-26 10:44 ` Alexander Holler
2014-08-26 10:44 ` Alexander Holler
2014-08-26 10:44 ` Alexander Holler
2014-08-26 11:01 ` Alexander Holler
2014-08-26 11:01 ` Alexander Holler
2014-08-26 11:01 ` Alexander Holler
2014-08-26 11:08 ` Thierry Reding
2014-08-26 11:08 ` Thierry Reding
2014-08-26 11:23 ` Alexander Holler
2014-08-26 11:23 ` Alexander Holler
2014-08-26 11:23 ` Alexander Holler
2014-08-26 11:47 ` Thierry Reding
2014-08-26 11:47 ` Thierry Reding
2014-08-26 11:47 ` Thierry Reding
2014-08-26 12:00 ` Alexander Holler
2014-08-26 12:00 ` Alexander Holler
2014-08-26 12:00 ` Alexander Holler
2014-08-26 13:58 ` Jon Loeliger
2014-08-26 13:58 ` Jon Loeliger
2014-08-26 13:58 ` Jon Loeliger
2014-08-26 14:17 ` Thierry Reding
2014-08-26 14:17 ` Thierry Reding
2014-08-27 7:16 ` Alexander Holler
2014-08-27 7:16 ` Alexander Holler
2014-08-27 7:16 ` Alexander Holler
2014-08-27 9:26 ` Alexander Holler
2014-08-27 9:26 ` Alexander Holler
2014-08-26 7:56 ` Alexander Holler
2014-08-26 7:56 ` Alexander Holler
2014-08-26 7:56 ` Alexander Holler
2014-08-26 8:51 ` Grant Likely
2014-08-26 8:51 ` Grant Likely
2014-08-26 8:51 ` Grant Likely
2014-08-26 9:56 ` Alexander Holler
2014-08-26 9:56 ` Alexander Holler
2014-08-26 9:56 ` Alexander Holler
2014-08-26 10:18 ` Alexander Holler
2014-08-26 10:18 ` Alexander Holler
2014-08-26 10:18 ` Alexander Holler
2014-08-26 9:54 ` Mark Rutland
2014-08-26 9:54 ` Mark Rutland
2014-08-26 9:54 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53739108.40209@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.