From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vlad Yasevich <vyasevic@redhat.com>, netdev@vger.kernel.org
Cc: john.r.fastabend@intel.com, shemminger@vyatta.com,
bridge@lists.linux-foundation.org, jhs@mojatatu.com,
mst@redhat.com
Subject: Re: [Bridge] [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw
Date: Thu, 15 May 2014 00:47:43 +0400 [thread overview]
Message-ID: <5373D66F.4080801@cogentembedded.com> (raw)
In-Reply-To: <1400080168-16625-4-git-send-email-vyasevic@redhat.com>
On 05/14/2014 07:09 PM, Vlad Yasevich wrote:
> Add code that allows static fdb entires to be synced to the
> hw list for a specified port. This will be used later to
> program ports that can function in non-promiscuous mode.
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> ---
> net/bridge/br_fdb.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
> net/bridge/br_private.h | 2 ++
> 2 files changed, 58 insertions(+)
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index 9203d5a..9759b61 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -874,3 +874,59 @@ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
> out:
> return err;
> }
> +
> +int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p)
> +{
> + struct net_bridge_fdb_entry *fdb, *tmp = NULL;
Again, initializer doesn't seem to be needed.
> + int i;
> + int err = 0;
This one as well.
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vlad Yasevich <vyasevic@redhat.com>, netdev@vger.kernel.org
Cc: john.r.fastabend@intel.com, shemminger@vyatta.com,
bridge@lists.linux-foundation.org, jhs@mojatatu.com,
mst@redhat.com
Subject: Re: [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw
Date: Thu, 15 May 2014 00:47:43 +0400 [thread overview]
Message-ID: <5373D66F.4080801@cogentembedded.com> (raw)
In-Reply-To: <1400080168-16625-4-git-send-email-vyasevic@redhat.com>
On 05/14/2014 07:09 PM, Vlad Yasevich wrote:
> Add code that allows static fdb entires to be synced to the
> hw list for a specified port. This will be used later to
> program ports that can function in non-promiscuous mode.
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> ---
> net/bridge/br_fdb.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
> net/bridge/br_private.h | 2 ++
> 2 files changed, 58 insertions(+)
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index 9203d5a..9759b61 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -874,3 +874,59 @@ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
> out:
> return err;
> }
> +
> +int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p)
> +{
> + struct net_bridge_fdb_entry *fdb, *tmp = NULL;
Again, initializer doesn't seem to be needed.
> + int i;
> + int err = 0;
This one as well.
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-05-14 20:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:09 [Bridge] [PATCH net-next 0/8] Non-promisc bidge ports support Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 15:09 ` [Bridge] [PATCH net-next 1/8] bridge: Turn flag change macro into a function Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 15:09 ` [Bridge] [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 15:40 ` [Bridge] " Stephen Hemminger
2014-05-14 15:40 ` Stephen Hemminger
2014-05-14 15:42 ` [Bridge] " Stephen Hemminger
2014-05-14 15:42 ` Stephen Hemminger
2014-05-15 16:04 ` [Bridge] " Vlad Yasevich
2014-05-15 16:04 ` Vlad Yasevich
2014-05-14 15:09 ` [Bridge] [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 20:47 ` Sergei Shtylyov [this message]
2014-05-14 20:47 ` Sergei Shtylyov
2014-05-14 15:09 ` [Bridge] [PATCH net-next 4/8] bridge: Introduce BR_PROMISC flag Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 15:09 ` [Bridge] [PATCH net-next 5/8] bridge: Add addresses from static fdbs to non-promisc ports Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 20:44 ` [Bridge] " Sergei Shtylyov
2014-05-14 20:44 ` Sergei Shtylyov
2014-05-14 15:09 ` [Bridge] [PATCH net-next 6/8] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 15:09 ` [Bridge] [PATCH net-next 7/8] bridge: Correctly manage promiscuity when user requested it Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 15:09 ` [Bridge] [PATCH net-next 8/8] bridge: Automatically manage promisc mode when vlan filtering is on Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich
2014-05-14 20:41 ` [Bridge] " Sergei Shtylyov
2014-05-14 20:41 ` Sergei Shtylyov
2014-05-14 15:21 ` [Bridge] [PATCH net-next 0/8] Non-promisc bidge ports support Michael S. Tsirkin
2014-05-14 15:21 ` Michael S. Tsirkin
2014-05-14 19:29 ` [Bridge] " David Miller
2014-05-14 19:29 ` David Miller
2014-05-15 16:09 ` [Bridge] " Vlad Yasevich
2014-05-15 16:09 ` Vlad Yasevich
2014-05-15 12:55 ` [Bridge] " Toshiaki Makita
2014-05-15 12:55 ` Toshiaki Makita
2014-05-15 13:02 ` [Bridge] " Toshiaki Makita
2014-05-15 13:02 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5373D66F.4080801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bridge@lists.linux-foundation.org \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.