All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, joelf@ti.com, arnd@arndb.de
Cc: linux@arm.linux.org.uk, vinod.koul@intel.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	tony@atomide.com, bcousson@baylibre.com
Subject: Re: [PATCH v3 02/13] ARM: edma: Take the number of tc from edma_soc_info (pdata)
Date: Mon, 19 May 2014 16:37:18 +0530	[thread overview]
Message-ID: <5379E5E6.9080500@ti.com> (raw)
In-Reply-To: <1400242640-9902-3-git-send-email-peter.ujfalusi@ti.com>

Peter,

On Friday 16 May 2014 05:47 PM, Peter Ujfalusi wrote:
> Instead of saving the for loop length, take the num_tc value from the pdata.
> In case of DT boot set the n_tc to 3 as it is hardwired in edma_of_parse_dt()
> This is a temporary state since upcoming patch(es) will change how we are
> dealing with these parameters.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm/common/edma.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index 01707aae0a2b..d42c84a3432a 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c

> @@ -1741,9 +1743,6 @@ static int edma_probe(struct platform_device *pdev)
>  			map_queue_tc(j, queue_tc_mapping[i][0],
>  					queue_tc_mapping[i][1]);
>  
> -		/* Save the number of TCs */
> -		edma_cc[j]->num_tc = i;
> -

To which baseline do the patches apply? These lines are not present at
least in v3.15-rc5. I am applying the patch without this hunk.

Thanks,
Sekhar


WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 02/13] ARM: edma: Take the number of tc from edma_soc_info (pdata)
Date: Mon, 19 May 2014 16:37:18 +0530	[thread overview]
Message-ID: <5379E5E6.9080500@ti.com> (raw)
In-Reply-To: <1400242640-9902-3-git-send-email-peter.ujfalusi@ti.com>

Peter,

On Friday 16 May 2014 05:47 PM, Peter Ujfalusi wrote:
> Instead of saving the for loop length, take the num_tc value from the pdata.
> In case of DT boot set the n_tc to 3 as it is hardwired in edma_of_parse_dt()
> This is a temporary state since upcoming patch(es) will change how we are
> dealing with these parameters.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm/common/edma.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index 01707aae0a2b..d42c84a3432a 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c

> @@ -1741,9 +1743,6 @@ static int edma_probe(struct platform_device *pdev)
>  			map_queue_tc(j, queue_tc_mapping[i][0],
>  					queue_tc_mapping[i][1]);
>  
> -		/* Save the number of TCs */
> -		edma_cc[j]->num_tc = i;
> -

To which baseline do the patches apply? These lines are not present at
least in v3.15-rc5. I am applying the patch without this hunk.

Thanks,
Sekhar

WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, <joelf@ti.com>, <arnd@arndb.de>
Cc: <linux@arm.linux.org.uk>, <vinod.koul@intel.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<tony@atomide.com>, <bcousson@baylibre.com>
Subject: Re: [PATCH v3 02/13] ARM: edma: Take the number of tc from edma_soc_info (pdata)
Date: Mon, 19 May 2014 16:37:18 +0530	[thread overview]
Message-ID: <5379E5E6.9080500@ti.com> (raw)
In-Reply-To: <1400242640-9902-3-git-send-email-peter.ujfalusi@ti.com>

Peter,

On Friday 16 May 2014 05:47 PM, Peter Ujfalusi wrote:
> Instead of saving the for loop length, take the num_tc value from the pdata.
> In case of DT boot set the n_tc to 3 as it is hardwired in edma_of_parse_dt()
> This is a temporary state since upcoming patch(es) will change how we are
> dealing with these parameters.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm/common/edma.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index 01707aae0a2b..d42c84a3432a 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c

> @@ -1741,9 +1743,6 @@ static int edma_probe(struct platform_device *pdev)
>  			map_queue_tc(j, queue_tc_mapping[i][0],
>  					queue_tc_mapping[i][1]);
>  
> -		/* Save the number of TCs */
> -		edma_cc[j]->num_tc = i;
> -

To which baseline do the patches apply? These lines are not present at
least in v3.15-rc5. I am applying the patch without this hunk.

Thanks,
Sekhar


  reply	other threads:[~2014-05-19 11:07 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 12:17 [PATCH v3 00/13] ARM/DT: edma: IP configuration from hardware and cleanups Peter Ujfalusi
2014-05-16 12:17 ` Peter Ujfalusi
2014-05-16 12:17 ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 01/13] ARM: edma: No need to clean the pdata in edma_of_parse_dt() Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 02/13] ARM: edma: Take the number of tc from edma_soc_info (pdata) Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-19 11:07   ` Sekhar Nori [this message]
2014-05-19 11:07     ` Sekhar Nori
2014-05-19 11:07     ` Sekhar Nori
2014-05-19 16:37     ` Peter Ujfalusi
2014-05-19 16:37       ` Peter Ujfalusi
2014-05-19 16:37       ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 03/13] ARM: edma: Do not change TC -> Queue mapping, leave it to default Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 04/13] ARM: davinci: Remove eDMA3 queue_tc_mapping data from edma_soc_info Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 05/13] ARM/platform_data: edma: Remove " Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-19 13:02   ` Sekhar Nori
2014-05-19 13:02     ` Sekhar Nori
2014-05-19 13:02     ` Sekhar Nori
2014-05-16 12:17 ` [PATCH v3 06/13] ARM: edma: Remove num_cc member from struct edma Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 07/13] ARM: edma: Save number of regions from pdata to " Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 08/13] ARM: edma: Get IP configuration from HW (number of channels, tc, etc) Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 17:33   ` Joel Fernandes
2014-05-16 17:33     ` Joel Fernandes
2014-05-16 17:33     ` Joel Fernandes
     [not found] ` <1400242640-9902-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2014-05-16 12:17   ` [PATCH v3 09/13] dt/bindings: ti,edma: Remove redundant properties from documentation Peter Ujfalusi
2014-05-16 12:17     ` Peter Ujfalusi
2014-05-16 12:17     ` [PATCH v3 09/13] dt/bindings: ti, edma: " Peter Ujfalusi
2014-05-19  8:15     ` [PATCH v3 09/13] dt/bindings: ti,edma: " Sekhar Nori
2014-05-19  8:15       ` Sekhar Nori
2014-05-19  8:15       ` [PATCH v3 09/13] dt/bindings: ti, edma: " Sekhar Nori
2014-05-22  9:53       ` [PATCH v3 09/13] dt/bindings: ti,edma: " Sekhar Nori
2014-05-22  9:53         ` Sekhar Nori
2014-05-22  9:53         ` [PATCH v3 09/13] dt/bindings: ti, edma: " Sekhar Nori
2014-05-16 12:17 ` [PATCH v3 10/13] ARM: dts: am33xx: Remove obsolete properties from edma node Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 15:02   ` Tony Lindgren
2014-05-16 15:02     ` Tony Lindgren
2014-05-16 12:17 ` [PATCH v3 11/13] ARM: dts: am4372: " Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 15:02   ` Tony Lindgren
2014-05-16 15:02     ` Tony Lindgren
2014-05-16 12:17 ` [PATCH v3 12/13] ARM: davinci: Remove redundant/unused parameters for edma Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17 ` [PATCH v3 13/13] ARM/platform_data: edma: Remove redundant/unused parameters from edma_soc_info Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-16 12:17   ` Peter Ujfalusi
2014-05-19 13:06 ` [PATCH v3 00/13] ARM/DT: edma: IP configuration from hardware and cleanups Sekhar Nori
2014-05-19 13:06   ` Sekhar Nori
2014-05-19 13:06   ` Sekhar Nori
2014-05-19 16:53   ` Peter Ujfalusi
2014-05-19 16:53     ` Peter Ujfalusi
2014-05-19 16:53     ` Peter Ujfalusi
2014-05-20 10:56     ` Sekhar Nori
2014-05-20 10:56       ` Sekhar Nori
2014-05-20 10:56       ` Sekhar Nori
2014-05-22  2:45       ` Vinod Koul
2014-05-22  2:45         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5379E5E6.9080500@ti.com \
    --to=nsekhar@ti.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joelf@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.