Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

On 05/17/2014 05:03 PM, Marc Marí wrote:
> Modify debug macros to have the same format through the codebase and use regular
> ifs instead of ifdef.
> 
> As the debug printf is always put in code, some formats had to be changed to
> avoid warnings treated as errors at compile time..
> 
> Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
> ---
>  hw/isa/vt82c686.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

>  
> -    DPRINTF("superio_ioport_writeb  address 0x%x  val 0x%x\n", addr, data);
> +    DPRINTF("superio_ioport_writeb address 0x%" PRIx64 "  val 0x%" PRIx64 "\n",

Any reason you shortened one double space but left the other intact?  I
would have expected both or none.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]