From: Richard Henderson <rth@twiddle.net>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
Overall <kvm@vger.kernel.org>, "Alexander Graf" <agraf@suse.de>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF
Date: Mon, 19 May 2014 09:50:06 -0700 [thread overview]
Message-ID: <537A363E.309@twiddle.net> (raw)
In-Reply-To: <20140519184526.00364e81@crunchbang>
On 05/19/2014 09:45 AM, Marc Marí wrote:
>> > This STDOUT vs _log() choice is a bit irregular, and I think you might
>> > be better off abandoning it completely. Richard, Alex, do we really
>> > need to optionally route printfery to log or stderr? (considering _log
>> > is NOW stderr by default now, and -D option gives you some flexibility
>> > there). Can we have just log and drop STDOUT mode?
>> >
>> > Regards,
>> > Peter
> QEMU_DPRINTF outputs to stderr, and, as you say qemu_log does it too.
> Should QEMU_DPRINTF be removed and leave only qemu_log?
Yes, I think that all debug output like this should go via qemu_log.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
Overall <kvm@vger.kernel.org>, "Alexander Graf" <agraf@suse.de>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF
Date: Mon, 19 May 2014 09:50:06 -0700 [thread overview]
Message-ID: <537A363E.309@twiddle.net> (raw)
In-Reply-To: <20140519184526.00364e81@crunchbang>
On 05/19/2014 09:45 AM, Marc Marí wrote:
>> > This STDOUT vs _log() choice is a bit irregular, and I think you might
>> > be better off abandoning it completely. Richard, Alex, do we really
>> > need to optionally route printfery to log or stderr? (considering _log
>> > is NOW stderr by default now, and -D option gives you some flexibility
>> > there). Can we have just log and drop STDOUT mode?
>> >
>> > Regards,
>> > Peter
> QEMU_DPRINTF outputs to stderr, and, as you say qemu_log does it too.
> Should QEMU_DPRINTF be removed and leave only qemu_log?
Yes, I think that all debug output like this should go via qemu_log.
r~
next prev parent reply other threads:[~2014-05-19 16:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 23:03 [Qemu-devel] [PATCH v3 00/16] Convert debug printfs to QEMU_DPRINTF Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 01/16] include/qemu-common.h: Add QEMU_DPRINTF macro Marc Marí
2014-05-19 15:28 ` Eric Blake
2014-05-17 23:03 ` [PATCH v3 02/16] x86: Convert debug printfs to QEMU_DPRINTF Marc Marí
2014-05-17 23:03 ` Marc Marí
2014-05-17 23:03 ` [Qemu-devel] " Marc Marí
2014-05-19 15:35 ` Eric Blake
2014-05-19 15:45 ` Eric Blake
2014-05-19 15:48 ` Eric Blake
2014-05-19 15:48 ` Eric Blake
2014-05-17 23:03 ` [PATCH v3 03/16] s390: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] " Marc Marí
2014-05-18 9:37 ` Peter Crosthwaite
2014-05-18 9:37 ` Peter Crosthwaite
2014-05-19 11:50 ` Alexander Graf
2014-05-19 11:50 ` [Qemu-devel] " Alexander Graf
2014-05-19 16:45 ` Marc Marí
2014-05-19 16:45 ` Marc Marí
2014-05-19 16:50 ` Richard Henderson [this message]
2014-05-19 16:50 ` Richard Henderson
2014-05-19 20:33 ` Peter Crosthwaite
2014-05-19 20:33 ` Peter Crosthwaite
2014-05-19 20:34 ` Alexander Graf
2014-05-19 20:34 ` Alexander Graf
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 04/16] scsi: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 05/16] highbank: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 06/16] xilinx: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 07/16] spapr: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 08/16] stellaris: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 09/16] i82374: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 10/16] i8257: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 11/16] rc4030: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 12/16] sd: " Marc Marí
2014-05-19 21:05 ` Eric Blake
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 13/16] isa: " Marc Marí
2014-05-19 21:07 ` Eric Blake
2014-05-20 6:39 ` Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 14/16] lan9118: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 15/16] pci-host: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 16/16] common: " Marc Marí
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A363E.309@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marc.mari.barcelo@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.