Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

[Alexander Graf <agraf@suse.de>]

On 19.05.14 22:33, Peter Crosthwaite wrote:
> On Tue, May 20, 2014 at 2:50 AM, Richard Henderson <rth@twiddle.net> wrote:
>> On 05/19/2014 09:45 AM, Marc Marí wrote:
>>>>> This STDOUT vs _log() choice is a bit irregular, and I think you might
>>>>> be better off abandoning it completely. Richard, Alex, do we really
>>>>> need to optionally route printfery to log or stderr? (considering _log
>>>>> is NOW stderr by default now, and -D option gives you some flexibility
>>>>> there). Can we have just log and drop STDOUT mode?
>>>>>
>>>>> Regards,
>>>>> Peter
>>> QEMU_DPRINTF outputs to stderr, and, as you say qemu_log does it too.
>>> Should QEMU_DPRINTF be removed and leave only qemu_log?
> Ahh I see now, you want to use the common factored-out code in P1
> which is stderr specific. Perhaps that should use qemu_log. One option
> would be to create a variant of it in common code that does uses
> qemu_log instead of stderr and use that variant here. That way you can
> preserve existing behaviour (and maintainer expectations), as much as
> possible.

I think it's safe to assume that all TCG code wants to use qemu_log.


Alex