From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp
Date: Wed, 21 May 2014 12:44:54 +0000 [thread overview]
Message-ID: <537C9FC6.8020104@ti.com> (raw)
In-Reply-To: <20140513213205.GB18001@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On 14/05/14 00:32, Tony Lindgren wrote:
> +&dss {
> + status = "ok";
> + vdds_dsi-supply = <&vpll2>;
> + port {
> + dpi_out: endpoint {
> + remote-endpoint = <&lcd_in>;
> + data-lines = <18>;
> + };
> + };
> +};
I just noticed the vdds_dsi-supply there. While the driver currently
uses that if available, I think it should be removed, and done the same
way Florian did with his overo patches:
/* Needed to power the DPI pins */
&vpll2 {
regulator-always-on;
};
That supply is not DSS's supply, but it's used to power up the pins. If
the pins were used as GPIOs, that power should be enabled.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Joachim Eastwood <manabian@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org,
Florian Vaussard <florian.vaussard@epfl.ch>
Subject: Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp
Date: Wed, 21 May 2014 15:44:54 +0300 [thread overview]
Message-ID: <537C9FC6.8020104@ti.com> (raw)
In-Reply-To: <20140513213205.GB18001@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On 14/05/14 00:32, Tony Lindgren wrote:
> +&dss {
> + status = "ok";
> + vdds_dsi-supply = <&vpll2>;
> + port {
> + dpi_out: endpoint {
> + remote-endpoint = <&lcd_in>;
> + data-lines = <18>;
> + };
> + };
> +};
I just noticed the vdds_dsi-supply there. While the driver currently
uses that if available, I think it should be removed, and done the same
way Florian did with his overo patches:
/* Needed to power the DPI pins */
&vpll2 {
regulator-always-on;
};
That supply is not DSS's supply, but it's used to power up the pins. If
the pins were used as GPIOs, that power should be enabled.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp
Date: Wed, 21 May 2014 15:44:54 +0300 [thread overview]
Message-ID: <537C9FC6.8020104@ti.com> (raw)
In-Reply-To: <20140513213205.GB18001@atomide.com>
On 14/05/14 00:32, Tony Lindgren wrote:
> +&dss {
> + status = "ok";
> + vdds_dsi-supply = <&vpll2>;
> + port {
> + dpi_out: endpoint {
> + remote-endpoint = <&lcd_in>;
> + data-lines = <18>;
> + };
> + };
> +};
I just noticed the vdds_dsi-supply there. While the driver currently
uses that if available, I think it should be removed, and done the same
way Florian did with his overo patches:
/* Needed to power the DPI pins */
&vpll2 {
regulator-always-on;
};
That supply is not DSS's supply, but it's used to power up the pins. If
the pins were used as GPIOs, that power should be enabled.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140521/611db154/attachment.sig>
next prev parent reply other threads:[~2014-05-21 12:44 UTC|newest]
Thread overview: 270+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 23:52 [PATCH 0/4] OMAPDSS: Add support for panel ls037v7dw01 Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-29 23:52 ` [PATCH 1/4] OMAPDSS: Fix DSS clock multiplier issue on 3703 and probably 3630 Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-05-08 23:20 ` Tony Lindgren
2014-05-08 23:20 ` Tony Lindgren
2014-05-08 23:20 ` Tony Lindgren
2014-05-09 8:01 ` Tomi Valkeinen
2014-05-09 8:01 ` Tomi Valkeinen
2014-05-09 8:01 ` Tomi Valkeinen
2014-05-09 14:37 ` Tony Lindgren
2014-05-09 14:37 ` Tony Lindgren
2014-05-09 14:37 ` Tony Lindgren
2014-05-12 11:38 ` Tomi Valkeinen
2014-05-12 11:38 ` Tomi Valkeinen
2014-05-12 11:38 ` Tomi Valkeinen
2014-05-09 7:38 ` Tomi Valkeinen
2014-05-09 7:38 ` Tomi Valkeinen
2014-05-09 7:38 ` Tomi Valkeinen
2014-05-09 14:37 ` Tony Lindgren
2014-05-09 14:37 ` Tony Lindgren
2014-05-09 14:37 ` Tony Lindgren
2014-05-12 11:36 ` Tomi Valkeinen
2014-05-12 11:36 ` Tomi Valkeinen
2014-05-12 11:36 ` Tomi Valkeinen
2014-05-12 14:39 ` Tony Lindgren
2014-05-12 14:39 ` Tony Lindgren
2014-05-12 14:39 ` Tony Lindgren
2014-05-12 14:44 ` Tomi Valkeinen
2014-05-12 14:44 ` Tomi Valkeinen
2014-05-12 14:44 ` Tomi Valkeinen
2014-05-13 15:26 ` Tony Lindgren
2014-05-13 15:26 ` Tony Lindgren
2014-05-13 15:26 ` Tony Lindgren
2014-05-14 6:41 ` Tomi Valkeinen
2014-05-14 6:41 ` Tomi Valkeinen
2014-05-14 6:41 ` Tomi Valkeinen
2014-05-09 21:06 ` Andreas Müller
2014-05-09 21:06 ` Andreas Müller
2014-05-09 21:06 ` Andreas Müller
2014-05-11 14:42 ` Tony Lindgren
2014-05-11 14:42 ` Tony Lindgren
2014-05-11 14:42 ` Tony Lindgren
2014-05-12 8:20 ` Andreas Müller
2014-05-12 8:20 ` Andreas Müller
2014-05-12 8:20 ` Andreas Müller
2014-05-12 14:40 ` Tony Lindgren
2014-05-12 14:40 ` Tony Lindgren
2014-05-12 14:40 ` Tony Lindgren
2014-04-29 23:52 ` [PATCH 2/4] OMAPDSS: panel-sharp-ls037v7dw01: update to use gpiod Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-05-07 8:15 ` Tomi Valkeinen
2014-05-07 8:15 ` Tomi Valkeinen
2014-05-07 8:15 ` Tomi Valkeinen
2014-05-08 23:25 ` Tony Lindgren
2014-05-08 23:25 ` Tony Lindgren
2014-05-08 23:25 ` Tony Lindgren
2014-04-29 23:52 ` [PATCH 3/4] OMAPDSS: panel-sharp-ls037v7dw01: add device tree support Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-05-07 8:12 ` Tomi Valkeinen
2014-05-07 8:12 ` Tomi Valkeinen
2014-05-07 8:12 ` Tomi Valkeinen
2014-05-07 15:03 ` Tony Lindgren
2014-05-07 15:03 ` Tony Lindgren
2014-05-07 15:03 ` Tony Lindgren
2014-05-07 16:02 ` Tomi Valkeinen
2014-05-07 16:02 ` Tomi Valkeinen
2014-05-07 16:02 ` Tomi Valkeinen
2014-05-07 17:59 ` Tony Lindgren
2014-05-07 17:59 ` Tony Lindgren
2014-05-07 17:59 ` Tony Lindgren
2014-05-08 23:33 ` Tony Lindgren
2014-05-08 23:33 ` Tony Lindgren
2014-05-08 23:33 ` Tony Lindgren
2014-05-09 7:24 ` Tomi Valkeinen
2014-05-09 7:24 ` Tomi Valkeinen
2014-05-09 7:24 ` Tomi Valkeinen
2014-05-09 15:55 ` Tony Lindgren
2014-05-09 15:55 ` Tony Lindgren
2014-05-09 15:55 ` Tony Lindgren
2014-05-12 7:38 ` Tomi Valkeinen
2014-05-12 7:38 ` Tomi Valkeinen
2014-05-12 7:38 ` Tomi Valkeinen
2014-05-12 9:34 ` Javier Martinez Canillas
2014-05-12 9:34 ` Javier Martinez Canillas
2014-05-12 9:34 ` Javier Martinez Canillas
2014-05-12 9:40 ` Tomi Valkeinen
2014-05-12 9:40 ` Tomi Valkeinen
2014-05-12 9:40 ` Tomi Valkeinen
2014-05-12 10:00 ` Javier Martinez Canillas
2014-05-12 10:00 ` Javier Martinez Canillas
2014-05-12 10:00 ` Javier Martinez Canillas
2014-05-12 14:26 ` Tony Lindgren
2014-05-12 14:26 ` Tony Lindgren
2014-05-12 14:26 ` Tony Lindgren
2014-05-12 14:55 ` Tomi Valkeinen
2014-05-12 14:55 ` Tomi Valkeinen
2014-05-12 14:55 ` Tomi Valkeinen
2014-05-12 15:51 ` Tony Lindgren
2014-05-12 15:51 ` Tony Lindgren
2014-05-12 15:51 ` Tony Lindgren
2014-05-13 10:51 ` Tomi Valkeinen
2014-05-13 10:51 ` Tomi Valkeinen
2014-05-13 10:51 ` Tomi Valkeinen
2014-05-13 11:39 ` Javier Martinez Canillas
2014-05-13 11:39 ` Javier Martinez Canillas
2014-05-13 11:39 ` Javier Martinez Canillas
2014-05-13 15:25 ` Tony Lindgren
2014-05-13 15:25 ` Tony Lindgren
2014-05-13 15:25 ` Tony Lindgren
2014-05-14 6:19 ` Tomi Valkeinen
2014-05-14 6:19 ` Tomi Valkeinen
2014-05-14 6:19 ` Tomi Valkeinen
2014-05-14 16:02 ` Tony Lindgren
2014-05-14 16:02 ` Tony Lindgren
2014-05-14 16:02 ` Tony Lindgren
2014-05-15 9:23 ` Tomi Valkeinen
2014-05-15 9:23 ` Tomi Valkeinen
2014-05-15 9:23 ` Tomi Valkeinen
2014-05-15 18:21 ` Tony Lindgren
2014-05-15 18:21 ` Tony Lindgren
2014-05-15 18:21 ` Tony Lindgren
2014-05-16 5:56 ` Tomi Valkeinen
2014-05-16 5:56 ` Tomi Valkeinen
2014-05-16 5:56 ` Tomi Valkeinen
2014-05-16 16:07 ` Tony Lindgren
2014-05-16 16:07 ` Tony Lindgren
2014-05-16 16:07 ` Tony Lindgren
2014-05-16 17:41 ` Sebastian Reichel
2014-05-16 17:41 ` Sebastian Reichel
2014-05-16 17:41 ` Sebastian Reichel
2014-05-16 18:01 ` Tony Lindgren
2014-05-16 18:01 ` Tony Lindgren
2014-05-16 18:01 ` Tony Lindgren
2014-05-16 21:39 ` Tony Lindgren
2014-05-16 21:39 ` Tony Lindgren
2014-05-16 21:39 ` Tony Lindgren
2014-05-19 9:48 ` Tomi Valkeinen
2014-05-19 9:48 ` Tomi Valkeinen
2014-05-19 9:48 ` Tomi Valkeinen
2014-05-19 15:57 ` Tony Lindgren
2014-05-19 15:57 ` Tony Lindgren
2014-05-19 15:57 ` Tony Lindgren
2014-05-19 16:43 ` Arnd Bergmann
2014-05-19 16:43 ` Arnd Bergmann
2014-05-19 16:43 ` Arnd Bergmann
2014-05-19 18:57 ` Tomi Valkeinen
2014-05-19 18:57 ` Tomi Valkeinen
2014-05-19 18:57 ` Tomi Valkeinen
2014-05-19 19:51 ` Tony Lindgren
2014-05-19 19:51 ` Tony Lindgren
2014-05-19 19:51 ` Tony Lindgren
2014-05-21 13:05 ` Tomi Valkeinen
2014-05-21 13:05 ` Tomi Valkeinen
2014-05-21 13:05 ` Tomi Valkeinen
2014-05-21 14:24 ` Sebastian Reichel
2014-05-21 14:24 ` Sebastian Reichel
2014-05-21 14:24 ` Sebastian Reichel
2014-05-20 4:57 ` Sebastian Reichel
2014-05-20 4:57 ` Sebastian Reichel
2014-05-20 4:57 ` Sebastian Reichel
2014-05-20 5:21 ` Tomi Valkeinen
2014-05-20 5:21 ` Tomi Valkeinen
2014-05-20 5:21 ` Tomi Valkeinen
2014-05-19 9:21 ` Tomi Valkeinen
2014-05-19 9:21 ` Tomi Valkeinen
2014-05-19 9:21 ` Tomi Valkeinen
2014-05-19 16:04 ` Tony Lindgren
2014-05-19 16:04 ` Tony Lindgren
2014-05-19 16:04 ` Tony Lindgren
2014-05-19 19:05 ` Tomi Valkeinen
2014-05-19 19:05 ` Tomi Valkeinen
2014-05-19 19:05 ` Tomi Valkeinen
2014-05-20 5:12 ` Sebastian Reichel
2014-05-20 5:12 ` Sebastian Reichel
2014-05-20 5:12 ` Sebastian Reichel
2014-05-20 5:48 ` Tony Lindgren
2014-05-20 5:48 ` Tony Lindgren
2014-05-20 5:48 ` Tony Lindgren
2014-05-20 21:10 ` Sebastian Reichel
2014-05-20 21:10 ` Sebastian Reichel
2014-05-20 21:10 ` Sebastian Reichel
2014-05-09 8:31 ` Tomi Valkeinen
2014-05-09 8:31 ` Tomi Valkeinen
2014-05-09 8:31 ` Tomi Valkeinen
2014-05-09 15:30 ` Tony Lindgren
2014-05-09 15:30 ` Tony Lindgren
2014-05-09 15:30 ` Tony Lindgren
2014-05-13 21:26 ` Tony Lindgren
2014-05-13 21:26 ` Tony Lindgren
2014-05-13 21:26 ` Tony Lindgren
2014-05-15 8:41 ` Tomi Valkeinen
2014-05-15 8:41 ` Tomi Valkeinen
2014-05-15 8:41 ` Tomi Valkeinen
2014-05-15 18:25 ` Tony Lindgren
2014-05-15 18:25 ` Tony Lindgren
2014-05-15 18:25 ` Tony Lindgren
2014-05-16 5:50 ` Tomi Valkeinen
2014-05-16 5:50 ` Tomi Valkeinen
2014-05-16 5:50 ` Tomi Valkeinen
2014-05-16 15:59 ` Tony Lindgren
2014-05-16 15:59 ` Tony Lindgren
2014-05-16 15:59 ` Tony Lindgren
2014-05-15 13:07 ` Tomi Valkeinen
2014-05-15 13:07 ` Tomi Valkeinen
2014-05-15 13:07 ` Tomi Valkeinen
2014-05-15 18:27 ` Tony Lindgren
2014-05-15 18:27 ` Tony Lindgren
2014-05-15 18:27 ` Tony Lindgren
2014-04-29 23:52 ` [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-29 23:52 ` Tony Lindgren
2014-04-30 1:07 ` Joachim Eastwood
2014-04-30 1:07 ` Joachim Eastwood
2014-04-30 1:07 ` Joachim Eastwood
2014-04-30 17:47 ` Tony Lindgren
2014-04-30 17:47 ` Tony Lindgren
2014-04-30 17:47 ` Tony Lindgren
2014-05-05 18:39 ` Tony Lindgren
2014-05-05 18:39 ` Tony Lindgren
2014-05-05 18:39 ` Tony Lindgren
2014-05-08 23:36 ` Tony Lindgren
2014-05-08 23:36 ` Tony Lindgren
2014-05-08 23:36 ` Tony Lindgren
2014-05-09 7:07 ` Tomi Valkeinen
2014-05-09 7:07 ` Tomi Valkeinen
2014-05-09 7:07 ` Tomi Valkeinen
2014-05-09 15:37 ` Tony Lindgren
2014-05-09 15:37 ` Tony Lindgren
2014-05-09 15:37 ` Tony Lindgren
2014-05-13 21:32 ` Tony Lindgren
2014-05-13 21:32 ` Tony Lindgren
2014-05-13 21:32 ` Tony Lindgren
2014-05-15 8:57 ` Tomi Valkeinen
2014-05-15 8:57 ` Tomi Valkeinen
2014-05-15 8:57 ` Tomi Valkeinen
2014-05-21 12:44 ` Tomi Valkeinen [this message]
2014-05-21 12:44 ` Tomi Valkeinen
2014-05-21 12:44 ` Tomi Valkeinen
2014-05-21 14:50 ` Tony Lindgren
2014-05-21 14:50 ` Tony Lindgren
2014-05-21 14:50 ` Tony Lindgren
2014-05-27 20:59 ` Tony Lindgren
2014-05-27 20:59 ` Tony Lindgren
2014-05-27 20:59 ` Tony Lindgren
2014-05-27 21:14 ` Tony Lindgren
2014-05-27 21:14 ` Tony Lindgren
2014-05-27 21:14 ` Tony Lindgren
2014-05-28 6:31 ` Tomi Valkeinen
2014-05-28 6:31 ` Tomi Valkeinen
2014-05-28 6:31 ` Tomi Valkeinen
2014-05-28 6:34 ` Tomi Valkeinen
2014-05-28 6:34 ` Tomi Valkeinen
2014-05-28 6:34 ` Tomi Valkeinen
2014-05-05 18:41 ` [PATCH 0/4] OMAPDSS: Add support for panel ls037v7dw01 Tony Lindgren
2014-05-05 18:41 ` Tony Lindgren
2014-05-05 18:41 ` Tony Lindgren
2014-05-09 9:34 ` Tomi Valkeinen
2014-05-09 9:34 ` Tomi Valkeinen
2014-05-09 9:34 ` Tomi Valkeinen
2014-05-09 15:55 ` Tony Lindgren
2014-05-09 15:55 ` Tony Lindgren
2014-05-09 15:55 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2014-05-16 7:29 [PATCH 0/4] OMAPDSS: sharp-ls037v7dw01 DT support Tomi Valkeinen
2014-05-16 7:30 ` [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp Tomi Valkeinen
2014-05-16 7:30 ` Tomi Valkeinen
2014-05-16 7:30 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C9FC6.8020104@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.