From: zhangfei.gao@linaro.org (zhangfei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver
Date: Wed, 28 May 2014 13:48:18 +0800 [thread overview]
Message-ID: <538578A2.7060600@linaro.org> (raw)
In-Reply-To: <20140527130236.GA26163@distanz.ch>
On 05/27/2014 09:02 PM, Tobias Klauser wrote:
> On 2014-05-27 at 14:44:27 +0200, Zhangfei Gao <zhangfei.gao@linaro.org> wrote:
>
>> +static struct net_device_stats *hix5hd2_net_get_stats(struct net_device *dev)
>> +{
>> + return &dev->stats;
>> +}
>
> This function can be omitted, since it corresponds to the default
> behavior if neither .ndo_get_stats or .ndo_get_stats64 is set.
>
>> +
>> +static const struct net_device_ops hix5hd2_netdev_ops = {
>> + .ndo_open = hix5hd2_net_open,
>> + .ndo_stop = hix5hd2_net_close,
>> + .ndo_start_xmit = hix5hd2_net_xmit,
>> + .ndo_tx_timeout = hix5hd2_net_timeout,
>> + .ndo_set_mac_address = hix5hd2_net_set_mac_address,
>> + .ndo_get_stats = hix5hd2_net_get_stats,
>
> Thus the line above can then be omitted as well.
Thanks Tobias.
Have double checked dev_get_stats, the .ndo_get_stats can be removed here.
Thanks for the remainder.
WARNING: multiple messages have this Message-ID (diff)
From: zhangfei <zhangfei.gao@linaro.org>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: davem@davemloft.net, arnd@arndb.de, f.fainelli@gmail.com,
sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com,
David.Laight@ACULAB.COM, eric.dumazet@gmail.com,
haifeng.yan@linaro.org, jchxue@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver
Date: Wed, 28 May 2014 13:48:18 +0800 [thread overview]
Message-ID: <538578A2.7060600@linaro.org> (raw)
In-Reply-To: <20140527130236.GA26163@distanz.ch>
On 05/27/2014 09:02 PM, Tobias Klauser wrote:
> On 2014-05-27 at 14:44:27 +0200, Zhangfei Gao <zhangfei.gao@linaro.org> wrote:
>
>> +static struct net_device_stats *hix5hd2_net_get_stats(struct net_device *dev)
>> +{
>> + return &dev->stats;
>> +}
>
> This function can be omitted, since it corresponds to the default
> behavior if neither .ndo_get_stats or .ndo_get_stats64 is set.
>
>> +
>> +static const struct net_device_ops hix5hd2_netdev_ops = {
>> + .ndo_open = hix5hd2_net_open,
>> + .ndo_stop = hix5hd2_net_close,
>> + .ndo_start_xmit = hix5hd2_net_xmit,
>> + .ndo_tx_timeout = hix5hd2_net_timeout,
>> + .ndo_set_mac_address = hix5hd2_net_set_mac_address,
>> + .ndo_get_stats = hix5hd2_net_get_stats,
>
> Thus the line above can then be omitted as well.
Thanks Tobias.
Have double checked dev_get_stats, the .ndo_get_stats can be removed here.
Thanks for the remainder.
next prev parent reply other threads:[~2014-05-28 5:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 12:44 [PATCH v2 0/2] add hix5hd2 mac driver Zhangfei Gao
2014-05-27 12:44 ` Zhangfei Gao
2014-05-27 12:44 ` [PATCH v2 1/2] Documentation: add Device tree bindings for Hisilicon hix5hd2 ethernet Zhangfei Gao
2014-05-27 12:44 ` Zhangfei Gao
2014-05-27 13:34 ` Mark Rutland
2014-05-27 13:34 ` Mark Rutland
2014-05-28 5:41 ` zhangfei
2014-05-28 5:41 ` zhangfei
2014-05-28 12:53 ` Mark Rutland
2014-05-28 12:53 ` Mark Rutland
2014-05-28 13:25 ` zhangfei
2014-05-28 13:25 ` zhangfei
2014-05-28 14:58 ` Mark Rutland
2014-05-28 14:58 ` Mark Rutland
2014-05-29 11:52 ` zhangfei
2014-05-29 11:52 ` zhangfei
2014-05-27 12:44 ` [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver Zhangfei Gao
2014-05-27 12:44 ` Zhangfei Gao
2014-05-27 13:02 ` Tobias Klauser
2014-05-27 13:02 ` Tobias Klauser
2014-05-28 5:48 ` zhangfei [this message]
2014-05-28 5:48 ` zhangfei
2014-05-27 13:57 ` Mark Rutland
2014-05-27 13:57 ` Mark Rutland
2014-05-28 6:09 ` zhangfei
2014-05-28 6:09 ` zhangfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538578A2.7060600@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.